diff options
author | Ole André Vadla Ravnås <oleavr@gmail.com> | 2015-03-05 20:56:00 +0100 |
---|---|---|
committer | Ben Noordhuis <info@bnoordhuis.nl> | 2015-03-05 21:05:00 +0100 |
commit | d557ad73e04b188edaa287f962f000b8b332b73b (patch) | |
tree | 25cfc770ed0534e7657586372f53ecb06e8db1a4 /docs/src | |
parent | c272f1f1bc0bda625e6441d798c110b4064a6ce2 (diff) | |
download | libuv-d557ad73e04b188edaa287f962f000b8b332b73b.tar.gz libuv-d557ad73e04b188edaa287f962f000b8b332b73b.zip |
darwin: fix size calculation in select() fallback
Apple's `fd_set` stores its bits in an array of 32-bit integers, which
means `FD_ISSET()` may read out of bounds if we allocate storage at
byte granularity. There's also a chance that the `select()` call could
corrupt the heap, although I didn't investigate that.
This issue was discovered by LLVM's AddressSanitizer which caught
`FD_ISSET()` trying to read out of bounds.
PR-URL: https://github.com/libuv/libuv/pull/241
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Diffstat (limited to 'docs/src')
0 files changed, 0 insertions, 0 deletions