diff options
author | Jeremy Whitlock <jwhitlock@apache.org> | 2015-09-03 09:58:48 -0600 |
---|---|---|
committer | Saúl Ibarra Corretgé <saghul@gmail.com> | 2015-09-03 23:47:54 +0200 |
commit | 30fc36256057b9790118b79e7cfed9f42a579f7f (patch) | |
tree | 41326062f091866e6567e928b02ef10225853709 /docs/src | |
parent | 866dc3f98bdf58357b0053e6de90cdcbd59f7efc (diff) | |
download | libuv-30fc36256057b9790118b79e7cfed9f42a579f7f.tar.gz libuv-30fc36256057b9790118b79e7cfed9f42a579f7f.zip |
tests: fix fs tests run w/o full getdents support
fs_access, fs_async_dir and fs_symlink_dir could fail when the
filesystem where the tests are run does not fully support getting the
file type via getdents. Having getdents support does not imply that the
underlying filesystem fully supports what is necessary for these tests
to have passed prior to this commit. So the failing tests were updated
to check for UV_DIRENT_FILE as it did previously but it will also check for
UV_DIRENT_UNKNOWN as well to handle the filesystems that do not fully support
getting the file type via getdents. For OS X and Windows, which are
known to fully support getting the file type, the tests work as they did
before and will not check for UV_DIRENT_UNKNOWN. We could/should update the
preprocessor directive that chooses "rigorous" or "lax" checks
accordingly when we learn of new environments that should always do the
original "rigorous" checks.
Fixes: https://github.com/libuv/libuv/issues/501
PR-URL: https://github.com/libuv/libuv/pull/508
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Diffstat (limited to 'docs/src')
0 files changed, 0 insertions, 0 deletions