diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-09-06 22:49:21 +0200 |
---|---|---|
committer | Ben Noordhuis <info@bnoordhuis.nl> | 2019-09-06 22:49:22 +0200 |
commit | 1f63e287b62c340deba23a0ec23560db0813242e (patch) | |
tree | eedc5ebdd978e35ccd14c1ad8762fb0dd2743fc6 /docs/src | |
parent | c898f2e838bc087364e7a30b74fe1b864b226738 (diff) | |
download | libuv-1f63e287b62c340deba23a0ec23560db0813242e.tar.gz libuv-1f63e287b62c340deba23a0ec23560db0813242e.zip |
unix: simplify open(O_CLOEXEC) feature detection
Platforms that support O_CLOEXEC have supported it for a long time
and don't need feature detection. Libuv can just assume it works as
advertised.
The feature detection was broken for old Linux kernels because they
don't report EINVAL for unknown open() flags, they simply open the
file without setting the FD_CLOEXEC flag.
Libuv could fix that by checking afterwards with fcntl() if the flag
was actually set but it doesn't support kernels that old in the first
place so let's simplify the logic.
Fixes: https://github.com/libuv/libuv/issues/2450
PR-URL: https://github.com/libuv/libuv/pull/2454
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Diffstat (limited to 'docs/src')
0 files changed, 0 insertions, 0 deletions