Add new eslint rules (#2121)

The largest changes here are:
- enforcing single quotes for strings
- enforcing trailing commas where possible

In addition to those we have enabled several eslint plugins:
- plugin:requirejs/recommended, to enforce some conventions in require statements
- plugin:node/recommended, to enforce correct usage of various node.js APIs
- plugin:unicorn/recommended, which contains a pretty mixed bag of useful rules

This PR attempts to not change code behavior when possible.  In cases where fixing
existing code would change semantics, a linting exclusion has been placed in the 
code base to silence the error.  You can find these by searching for `eslint-disable-next-line`.

Co-authored-by: Austin Morton <austinpmorton@gmail.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/lib/compilers/ppci.js b/lib/compilers/ppci.js
index 0ad446071..cd23c9121 100644
--- a/lib/compilers/ppci.js
+++ b/lib/compilers/ppci.js
@@ -26,18 +26,18 @@ const BaseCompiler = require('../base-compiler'),
     exec = require('../exec'),
     logger = require('../logger').logger;
 
-const forbiddenOptions = [
+const forbiddenOptions = new Set([
     '--report',
     '--text-report',
-    '--html-report'
-];
+    '--html-report',
+]);
 
 class PPCICompiler extends BaseCompiler {
     filterUserOptions(args) {
         return args.filter((item) => {
-            if (typeof item !== "string") return true;
+            if (typeof item !== 'string') return true;
 
-            return !forbiddenOptions.includes(item.toLowerCase());
+            return !forbiddenOptions.has(item.toLowerCase());
         });
     }