Add new eslint rules (#2121)

The largest changes here are:
- enforcing single quotes for strings
- enforcing trailing commas where possible

In addition to those we have enabled several eslint plugins:
- plugin:requirejs/recommended, to enforce some conventions in require statements
- plugin:node/recommended, to enforce correct usage of various node.js APIs
- plugin:unicorn/recommended, which contains a pretty mixed bag of useful rules

This PR attempts to not change code behavior when possible.  In cases where fixing
existing code would change semantics, a linting exclusion has been placed in the 
code base to silence the error.  You can find these by searching for `eslint-disable-next-line`.

Co-authored-by: Austin Morton <austinpmorton@gmail.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/lib/compilers/nvcc.js b/lib/compilers/nvcc.js
index 7aed5a4c6..6f337cfd8 100644
--- a/lib/compilers/nvcc.js
+++ b/lib/compilers/nvcc.js
@@ -24,13 +24,13 @@
 
 const BaseCompiler = require('../base-compiler'),
     path = require('path'),
-    argumentParsers = require("./argument-parsers");
+    argumentParsers = require('./argument-parsers');
 
 class NvccCompiler extends BaseCompiler {
     constructor(info, env) {
         super(info, env);
         // These are for parsing the output of nvdisasm.
-        this.asm.asmOpcodeRe = /^\s*\/\*([^*]+)\*\/()()\s*{?\s*([^};]+)(?:}|;\s*\/\* 0x([0-9a-f]+) \*\/)$/;
+        this.asm.asmOpcodeRe = /^\s*\/\*([^*]+)\*\/()()\s*{?\s*([^;}]+)(?:}|;\s*\/\* 0x([\da-f]+) \*\/)$/;
         this.asm.lineRe = /^\s*\/\/## File "([^"]+)", line (\d+)$/;
         this.asm.labelRe = /^(?!\.text\.)()(\S[^:]+):$/;
     }
@@ -51,7 +51,7 @@ class NvccCompiler extends BaseCompiler {
 
     async objdump(outputFilename, result, maxSize) {
         // For nvdisasm.
-        const args = [outputFilename, "-c", "-g", "-hex"];
+        const args = [outputFilename, '-c', '-g', '-hex'];
         const execOptions = {maxOutput: maxSize, customCwd: path.dirname(outputFilename)};
 
         const objResult = await this.exec(this.compiler.objdumper, args, execOptions);