Add new eslint rules (#2121)

The largest changes here are:
- enforcing single quotes for strings
- enforcing trailing commas where possible

In addition to those we have enabled several eslint plugins:
- plugin:requirejs/recommended, to enforce some conventions in require statements
- plugin:node/recommended, to enforce correct usage of various node.js APIs
- plugin:unicorn/recommended, which contains a pretty mixed bag of useful rules

This PR attempts to not change code behavior when possible.  In cases where fixing
existing code would change semantics, a linting exclusion has been placed in the 
code base to silence the error.  You can find these by searching for `eslint-disable-next-line`.

Co-authored-by: Austin Morton <austinpmorton@gmail.com>

1 files changed, 7 insertions, 7 deletions

diff --git a/lib/compilers/dmd.js b/lib/compilers/dmd.js
index 89a8d753d..562108bfe 100644
--- a/lib/compilers/dmd.js
+++ b/lib/compilers/dmd.js
@@ -23,7 +23,7 @@
 // POSSIBILITY OF SUCH DAMAGE.
 
 const BaseCompiler = require('../base-compiler'),
-    argumentParsers = require("./argument-parsers"),
+    argumentParsers = require('./argument-parsers'),
     path = require('path');
 
 class DMDCompiler extends BaseCompiler {
@@ -45,7 +45,7 @@ class DMDCompiler extends BaseCompiler {
         const lPath = path.basename(outputFilename);
         return this.handlePostProcessResult(
             result,
-            await this.exec(postProcesses[0], ["-l", lPath], {customCwd: dirPath, maxOutput: maxSize}));
+            await this.exec(postProcesses[0], ['-l', lPath], {customCwd: dirPath, maxOutput: maxSize}));
     }
 
     getOutputFilename(dirPath, outputFilebase) {
@@ -53,16 +53,16 @@ class DMDCompiler extends BaseCompiler {
     }
 
     buildExecutable(compiler, options, inputFilename, execOptions) {
-        options = options.filter((param) => param !== "-c");
+        options = options.filter((param) => param !== '-c');
 
         return this.runCompiler(compiler, options, inputFilename, execOptions);
     }
 
     async objdump(outputFilename, result, maxSize, intelAsm, demangle) {
         const dirPath = path.dirname(outputFilename);
-        let args = ["-d", outputFilename, "-l", "--insn-width=16"];
-        if (demangle) args = args.concat("-C");
-        if (intelAsm) args = args.concat(["-M", "intel"]);
+        let args = ['-d', outputFilename, '-l', '--insn-width=16'];
+        if (demangle) args = args.concat('-C');
+        if (intelAsm) args = args.concat(['-M', 'intel']);
         const objResult = await this.exec(
             this.compiler.objdumper, args, {maxOutput: maxSize, customCwd: dirPath});
         result.asm = objResult.stdout;
@@ -77,7 +77,7 @@ class DMDCompiler extends BaseCompiler {
     }
 
     filterUserOptions(userOptions) {
-        return userOptions.filter(option => option !== '-run' && option !== '-man' && !option.startsWith("-Xf"));
+        return userOptions.filter(option => option !== '-run' && option !== '-man' && !option.startsWith('-Xf'));
     }
 }