Add new eslint rules (#2121)

The largest changes here are:
- enforcing single quotes for strings
- enforcing trailing commas where possible

In addition to those we have enabled several eslint plugins:
- plugin:requirejs/recommended, to enforce some conventions in require statements
- plugin:node/recommended, to enforce correct usage of various node.js APIs
- plugin:unicorn/recommended, which contains a pretty mixed bag of useful rules

This PR attempts to not change code behavior when possible.  In cases where fixing
existing code would change semantics, a linting exclusion has been placed in the 
code base to silence the error.  You can find these by searching for `eslint-disable-next-line`.

Co-authored-by: Austin Morton <austinpmorton@gmail.com>

1 files changed, 5 insertions, 5 deletions

diff --git a/lib/compilers/ada.js b/lib/compilers/ada.js
index 1f3c58e52..c77d7c02f 100644
--- a/lib/compilers/ada.js
+++ b/lib/compilers/ada.js
@@ -24,7 +24,7 @@
 
 const BaseCompiler = require('../base-compiler'),
     utils = require('../utils'),
-    path = require("path");
+    path = require('path');
 
 class AdaCompiler extends BaseCompiler {
     constructor(info, env) {
@@ -34,11 +34,11 @@ class AdaCompiler extends BaseCompiler {
     }
 
     getExecutableFilename(dirPath) {
-        return path.join(dirPath, "example");
+        return path.join(dirPath, 'example');
     }
 
     getOutputFilename(dirPath) {
-        return path.join(dirPath, "example.o");
+        return path.join(dirPath, 'example.o');
     }
 
     optionsForFilter(filters, outputFilename) {
@@ -59,7 +59,7 @@ class AdaCompiler extends BaseCompiler {
             );
 
             if (this.compiler.intelAsm && filters.intel) {
-                options = options.concat(this.compiler.intelAsm.split(" "));
+                options = options.concat(this.compiler.intelAsm.split(' '));
             }
         } else {
             options.push(
@@ -67,7 +67,7 @@ class AdaCompiler extends BaseCompiler {
                 '-eS',
                 '-g',
                 'example',
-                '-cargs'
+                '-cargs',
             );
         }