diff options
| author | drh <> | 2023-03-28 11:18:04 +0000 |
|---|---|---|
| committer | drh <> | 2023-03-28 11:18:04 +0000 |
| commit | 3cbf38c7832e234aab1848e32c104fe345e19e4f (patch) | |
| tree | 6821e5e42b3e349d1c92cd308aed7df4a655cf32 /src/where.c | |
| parent | fc6c3936aac93d7c47c2780b0254422737a23090 (diff) | |
| download | sqlite-3cbf38c7832e234aab1848e32c104fe345e19e4f.tar.gz sqlite-3cbf38c7832e234aab1848e32c104fe345e19e4f.zip | |
Fix multiple problems with RETURNING on a DML statement against a view,
all inspired by [forum:/forumpost/dc3b92cfa0|forum post dc3b92cfa0].
(1) Do not allow a RETURNING clause to trick the code generator into thinking
that the view being updated has an INSTEAD OF trigger.
(2) Generate all result columns for a view in a DML statement.
(3) The automatic covering index for a view should cover all result columns
of the view.
FossilOrigin-Name: c8bedef0d61731c29ae34de1594222d15b578f9e2cddbbd5b74fb3059644fe0f
Diffstat (limited to 'src/where.c')
| -rw-r--r-- | src/where.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/src/where.c b/src/where.c index dd2b8b73c..509d14ff7 100644 --- a/src/where.c +++ b/src/where.c @@ -963,7 +963,11 @@ static SQLITE_NOINLINE void constructAutomaticIndex( ** original table changes and the index and table cannot both be used ** if they go out of sync. */ - extraCols = pSrc->colUsed & (~idxCols | MASKBIT(BMS-1)); + if( IsView(pTable) ){ + extraCols = ALLBITS; + }else{ + extraCols = pSrc->colUsed & (~idxCols | MASKBIT(BMS-1)); + } mxBitCol = MIN(BMS-1,pTable->nCol); testcase( pTable->nCol==BMS-1 ); testcase( pTable->nCol==BMS-2 ); |