aboutsummaryrefslogtreecommitdiff
path: root/src/select.c
diff options
context:
space:
mode:
authordrh <>2021-01-13 15:23:17 +0000
committerdrh <>2021-01-13 15:23:17 +0000
commitd193057ad147fe038d0f85c68cd914fa9d91c40c (patch)
treead74415cb2afab0b6056dfa9c7edea0f684d579e /src/select.c
parentaa556b0fa7ae3f96df773f20d86c51186be25f52 (diff)
downloadsqlite-d193057ad147fe038d0f85c68cd914fa9d91c40c.tar.gz
sqlite-d193057ad147fe038d0f85c68cd914fa9d91c40c.zip
Further enhancements to the min/max optimization of
[/info/b8ba2f17f938c035|check-in b8ba2f17f938c035] to fix the performance regression identified by [forum:/forumpost/623f571482|forum post 623f571482]. FossilOrigin-Name: 188772a1dbaf066fbddd39c718fdd87478b19a920622f4640bcb79d4ef065331
Diffstat (limited to 'src/select.c')
-rw-r--r--src/select.c8
1 files changed, 3 insertions, 5 deletions
diff --git a/src/select.c b/src/select.c
index f00a3acd8..76806b66e 100644
--- a/src/select.c
+++ b/src/select.c
@@ -6773,7 +6773,7 @@ int sqlite3Select(
/* End of the loop
*/
if( groupBySort ){
- sqlite3VdbeAddOp2(v, OP_SorterNext, pAggInfo->sortingIdx, addrTopOfLoop);
+ sqlite3VdbeAddOp2(v, OP_SorterNext, pAggInfo->sortingIdx,addrTopOfLoop);
VdbeCoverage(v);
}else{
sqlite3WhereEnd(pWInfo);
@@ -6885,7 +6885,6 @@ int sqlite3Select(
explainSimpleCount(pParse, pTab, pBest);
}else{
int regAcc = 0; /* "populate accumulators" flag */
- int addrSkip;
/* If there are accumulator registers but no min() or max() functions
** without FILTER clauses, allocate register regAcc. Register regAcc
@@ -6934,9 +6933,8 @@ int sqlite3Select(
}
updateAccumulator(pParse, regAcc, pAggInfo);
if( regAcc ) sqlite3VdbeAddOp2(v, OP_Integer, 1, regAcc);
- addrSkip = sqlite3WhereOrderByLimitOptLabel(pWInfo);
- if( addrSkip!=sqlite3WhereContinueLabel(pWInfo) ){
- sqlite3VdbeGoto(v, addrSkip);
+ if( minMaxFlag ){
+ sqlite3WhereMinMaxOptEarlyOut(v, pWInfo);
}
sqlite3WhereEnd(pWInfo);
finalizeAggFunctions(pParse, pAggInfo);