]> git.kaiwu.me - haproxy.git/commit
BUG/MEDIUM: acme: fix stalled renewal when opportunistic DNS check fails
authorWilliam Lallemand <wlallemand@irq6.net>
Thu, 30 Apr 2026 18:24:59 +0000 (20:24 +0200)
committerWilliam Lallemand <wlallemand@haproxy.com>
Mon, 4 May 2026 09:06:12 +0000 (11:06 +0200)
commit71267bc6a504fa7cfabf265c4eff9a9e4eb431ed
tree38e726a1bc1614fe66c68e71e682d77ab7576bfe
parent63f853957af3ee062493bb3700f964ce456125b0
BUG/MEDIUM: acme: fix stalled renewal when opportunistic DNS check fails

In ACME_INITIAL_RSLV_READY, when the opportunistic DNS propagation check
fails and the code falls back to ACME_CLI_WAIT, ACME_RDY_INITIAL_DNS was
left set in cond_ready. Since the CLI-wait path only ever sets ACME_RDY_CLI
on auth->ready, the readiness check in ACME_CLI_WAIT could never be
satisfied, permanently stalling certificate renewal.

Fix this by stripping ACME_RDY_INITIAL_DNS from cond_ready before falling
back to the regular CLI-wait flow. Also replace the &= with a plain
assignment in the success path to make the intent explicit.

No backport needed, 3.4 only.
src/acme.c