From 3c86223c998280ea313480d319ec39f802453218 Mon Sep 17 00:00:00 2001 From: Thomas Munro Date: Tue, 25 Mar 2025 20:17:53 +1300 Subject: libpq: Deprecate pg_int64. Previously we used pg_int64 in three function prototypes in libpq. It was added by commit 461ef73f to expose the platform-dependent type used for int64 in the C89 era. As of commit 962da900 it is defined as standard int64_t, and the dust seems to have settled. Let's just use int64_t directly in these three client-facing functions instead of (yet) another name. We've required C99 and thus since PostgreSQL 12, C89 and C++98 compilers are long gone, and client applications very likely use standard types for their own 64-bit needs. This also cleans up the obscure placement of a new #include directive in postgres_ext.h, required for the new definition. The typedef was hiding in there for historical reasons, but it doesn't fit postgres_ext.h's own description of its purpose and there is no evidence of client applications including postgres_ext.h directly to see it. Keep a typedef marked deprecated for backward compatibility, but move it into libpq-fe.h where it was used. Reviewed-by: Peter Eisentraut Discussion: https://postgr.es/m/CA%2BhUKGKn_EkNNGMY5RzMcKP%2Ba6urT4JF%3DCPhw_zHtQwjvX6P2g%40mail.gmail.com --- src/include/postgres_ext.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/include/postgres_ext.h') diff --git a/src/include/postgres_ext.h b/src/include/postgres_ext.h index 9f2e3c52972..bf45c50dcf3 100644 --- a/src/include/postgres_ext.h +++ b/src/include/postgres_ext.h @@ -24,8 +24,6 @@ #ifndef POSTGRES_EXT_H #define POSTGRES_EXT_H -#include - /* * Object ID is a fundamental type in Postgres. */ @@ -44,9 +42,6 @@ typedef unsigned int Oid; /* the above needs */ -/* Define a signed 64-bit integer type for use in client API declarations. */ -typedef int64_t pg_int64; - /* * Identifiers of error message fields. Kept here to keep common * between frontend and backend, and also to export them to libpq -- cgit v1.2.3