From 694e3d139a9d090c58494428bebfadad216419da Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Wed, 19 Feb 2014 10:06:59 -0500 Subject: Further code review for pg_lsn data type. Change input function error messages to be more consistent with what is done elsewhere. Remove a bunch of redundant type casts, so that the compiler will warn us if we screw up. Don't pass LSNs by value on platforms where a Datum is only 32 bytes, per buildfarm. Move macros for packing and unpacking LSNs to pg_lsn.h so that we can include access/xlogdefs.h, to avoid an unsatisfied dependency on XLogRecPtr. --- src/include/postgres.h | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'src/include/postgres.h') diff --git a/src/include/postgres.h b/src/include/postgres.h index c8b311fa22e..a8a206d988b 100644 --- a/src/include/postgres.h +++ b/src/include/postgres.h @@ -483,20 +483,6 @@ typedef Datum *DatumPtr; #define ObjectIdGetDatum(X) ((Datum) SET_4_BYTES(X)) -/* - * DatumGetLSN - * Returns PostgreSQL log sequence number of a datum. - */ - -#define DatumGetLSN(X) ((XLogRecPtr) GET_8_BYTES(X)) - -/* - * LSNGetDatum - * Returns datum representation for a PostgreSQL log sequence number. - */ - -#define LSNGetDatum(X) ((Datum) SET_8_BYTES(X)) - /* * DatumGetTransactionId * Returns transaction identifier value of a datum. -- cgit v1.2.3