From 341b328b180e65d1fa5c8f2235cf101c8a12824f Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 17 Mar 2000 02:36:41 +0000 Subject: Fix a bunch of minor portability problems and maybe-bugs revealed by running gcc and HP's cc with warnings cranked way up. Signed vs unsigned comparisons, routines declared static and then defined not-static, that kind of thing. Tedious, but perhaps useful... --- src/backend/utils/adt/ruleutils.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/backend/utils/adt/ruleutils.c') diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index 1a740048c6e..9397ec6c0d3 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -3,7 +3,7 @@ * out of its tuple * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.46 2000/03/15 23:42:14 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.47 2000/03/17 02:36:23 tgl Exp $ * * This software is copyrighted by Jan Wieck - Hamburg. * @@ -1555,21 +1555,21 @@ get_func_expr(Expr *expr, deparse_context *context) */ if (strcmp(proname, "bpchar") == 0) { - if (coercedTypmod > VARHDRSZ) + if (coercedTypmod > (int32) VARHDRSZ) appendStringInfo(buf, "char(%d)", coercedTypmod - VARHDRSZ); else appendStringInfo(buf, "char"); } else if (strcmp(proname, "varchar") == 0) { - if (coercedTypmod > VARHDRSZ) + if (coercedTypmod > (int32) VARHDRSZ) appendStringInfo(buf, "varchar(%d)", coercedTypmod - VARHDRSZ); else appendStringInfo(buf, "varchar"); } else if (strcmp(proname, "numeric") == 0) { - if (coercedTypmod >= VARHDRSZ) + if (coercedTypmod >= (int32) VARHDRSZ) appendStringInfo(buf, "numeric(%d,%d)", ((coercedTypmod - VARHDRSZ) >> 16) & 0xffff, (coercedTypmod - VARHDRSZ) & 0xffff); -- cgit v1.2.3