From 112caf9039f4c8fb286bb610461ced8253313e9f Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 12 Nov 2019 16:58:00 -0500 Subject: Finish reverting commit 0a52d378b. Apply the solution adopted in commit dcb7d3caf (ie, explicitly don't call memcmp for a zero-length comparison) to func_get_detail() as well, removing one other place where we were passing an uninitialized array to a parse_func.c entry point. Discussion: https://postgr.es/m/MN2PR18MB2927F24692485D754794F01BE3740@MN2PR18MB2927.namprd18.prod.outlook.com Discussion: https://postgr.es/m/MN2PR18MB2927F6873DF2774A505AC298E3740@MN2PR18MB2927.namprd18.prod.outlook.com --- src/backend/utils/adt/ruleutils.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/backend/utils/adt/ruleutils.c') diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c index c1de869c521..4c83cae5e92 100644 --- a/src/backend/utils/adt/ruleutils.c +++ b/src/backend/utils/adt/ruleutils.c @@ -833,7 +833,6 @@ pg_get_triggerdef_worker(Oid trigid, bool pretty) char *tgname; char *tgoldtable; char *tgnewtable; - Oid argtypes[1]; /* dummy */ Datum value; bool isnull; @@ -1045,7 +1044,7 @@ pg_get_triggerdef_worker(Oid trigid, bool pretty) appendStringInfo(&buf, "EXECUTE FUNCTION %s(", generate_function_name(trigrec->tgfoid, 0, - NIL, argtypes, + NIL, NULL, false, NULL, EXPR_KIND_NONE)); if (trigrec->tgnargs > 0) -- cgit v1.2.3