From 73508475d69e90f98ebd9b7e1a5933a26a49c5e9 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 14 Feb 2022 21:29:45 +0100 Subject: Remove pg_atoi() The last caller was int2vectorin(), and having such a general function for one user didn't seem useful, so just put the required parts inline and remove the function. Reviewed-by: John Naylor Discussion: https://www.postgresql.org/message-id/flat/b239564c-cad0-b23e-c57e-166d883cb97d@enterprisedb.com --- src/backend/utils/adt/numutils.c | 88 ---------------------------------------- 1 file changed, 88 deletions(-) (limited to 'src/backend/utils/adt/numutils.c') diff --git a/src/backend/utils/adt/numutils.c b/src/backend/utils/adt/numutils.c index e82d23a325e..cc3f95d3990 100644 --- a/src/backend/utils/adt/numutils.c +++ b/src/backend/utils/adt/numutils.c @@ -85,94 +85,6 @@ decimalLength64(const uint64 v) return t + (v >= PowersOfTen[t]); } -/* - * pg_atoi: convert string to integer - * - * allows any number of leading or trailing whitespace characters. - * - * 'size' is the sizeof() the desired integral result (1, 2, or 4 bytes). - * - * c, if not 0, is a terminator character that may appear after the - * integer (plus whitespace). If 0, the string must end after the integer. - * - * Unlike plain atoi(), this will throw ereport() upon bad input format or - * overflow. - */ -int32 -pg_atoi(const char *s, int size, int c) -{ - long l; - char *badp; - - /* - * Some versions of strtol treat the empty string as an error, but some - * seem not to. Make an explicit test to be sure we catch it. - */ - if (s == NULL) - elog(ERROR, "NULL pointer"); - if (*s == 0) - ereport(ERROR, - (errcode(ERRCODE_INVALID_TEXT_REPRESENTATION), - errmsg("invalid input syntax for type %s: \"%s\"", - "integer", s))); - - errno = 0; - l = strtol(s, &badp, 10); - - /* We made no progress parsing the string, so bail out */ - if (s == badp) - ereport(ERROR, - (errcode(ERRCODE_INVALID_TEXT_REPRESENTATION), - errmsg("invalid input syntax for type %s: \"%s\"", - "integer", s))); - - switch (size) - { - case sizeof(int32): - if (errno == ERANGE -#if defined(HAVE_LONG_INT_64) - /* won't get ERANGE on these with 64-bit longs... */ - || l < INT_MIN || l > INT_MAX -#endif - ) - ereport(ERROR, - (errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE), - errmsg("value \"%s\" is out of range for type %s", s, - "integer"))); - break; - case sizeof(int16): - if (errno == ERANGE || l < SHRT_MIN || l > SHRT_MAX) - ereport(ERROR, - (errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE), - errmsg("value \"%s\" is out of range for type %s", s, - "smallint"))); - break; - case sizeof(int8): - if (errno == ERANGE || l < SCHAR_MIN || l > SCHAR_MAX) - ereport(ERROR, - (errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE), - errmsg("value \"%s\" is out of range for 8-bit integer", s))); - break; - default: - elog(ERROR, "unsupported result size: %d", size); - } - - /* - * Skip any trailing whitespace; if anything but whitespace remains before - * the terminating character, bail out - */ - while (*badp && *badp != c && isspace((unsigned char) *badp)) - badp++; - - if (*badp && *badp != c) - ereport(ERROR, - (errcode(ERRCODE_INVALID_TEXT_REPRESENTATION), - errmsg("invalid input syntax for type %s: \"%s\"", - "integer", s))); - - return (int32) l; -} - /* * Convert input string to a signed 16 bit integer. * -- cgit v1.2.3