From 858e776c84f48841e7e16fba7b690b76e54f3675 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 27 Dec 2022 12:26:01 -0500 Subject: Convert the reg* input functions to report (most) errors softly. This is not really complete, but it catches most cases of practical interest. The main omissions are: * regtype, regprocedure, and regoperator parse type names by calling the main grammar, so any grammar-detected syntax error will still be a hard error. Also, if one includes a type modifier in such a type specification, errors detected by the typmodin function will be hard errors. * Lookup errors are handled just by passing missing_ok = true to the relevant catalog lookup function. Because we've used quite a restrictive definition of "missing_ok", this means that edge cases such as "the named schema exists, but you lack USAGE permission on it" are still hard errors. It would make sense to me to replace most/all missing_ok parameters with an escontext parameter and then allow these additional lookup failure cases to be trapped too. But that's a job for some other day. Discussion: https://postgr.es/m/3342239.1671988406@sss.pgh.pa.us --- src/backend/utils/adt/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/backend/utils/adt/misc.c') diff --git a/src/backend/utils/adt/misc.c b/src/backend/utils/adt/misc.c index 7808fbd4486..40ac4d4c342 100644 --- a/src/backend/utils/adt/misc.c +++ b/src/backend/utils/adt/misc.c @@ -724,7 +724,7 @@ pg_input_is_valid_common(FunctionCallInfo fcinfo, Oid typoid; /* Parse type-name argument to obtain type OID and encoded typmod. */ - parseTypeString(typnamestr, &typoid, &my_extra->typmod, false); + (void) parseTypeString(typnamestr, &typoid, &my_extra->typmod, NULL); /* Update type-specific info if typoid changed. */ if (my_extra->typoid != typoid) -- cgit v1.2.3