From 06a66d87dbc7e06581af6765131ea250063fb4ac Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Thu, 25 Jan 2024 16:21:57 -0500 Subject: Clean up a bug in sql/json items commit 66ea94e8e6 Remove a buggy and unnecessary test, along with an unnecessary pstrdup() and a line of dead code. Per report, diagnosis and fix from Tom Lane Discussion: https://postgr.es/m/439811.1706211069@sss.pgh.pa.us --- src/backend/utils/adt/jsonpath_exec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/backend/utils/adt/jsonpath_exec.c') diff --git a/src/backend/utils/adt/jsonpath_exec.c b/src/backend/utils/adt/jsonpath_exec.c index bf37f0195c8..02a700292bb 100644 --- a/src/backend/utils/adt/jsonpath_exec.c +++ b/src/backend/utils/adt/jsonpath_exec.c @@ -1540,11 +1540,9 @@ executeItemOptUnwrapTarget(JsonPathExecContext *cxt, JsonPathItem *jsp, break; } - res = jperOk; - jb = &jbv; Assert(tmp != NULL); /* We must have set tmp above */ - jb->val.string.val = (jb->type == jbvString) ? tmp : pstrdup(tmp); + jb->val.string.val = tmp; jb->val.string.len = strlen(jb->val.string.val); jb->type = jbvString; -- cgit v1.2.3