From 2146bfc869bfd4967b0bbf260f386344f02506b9 Mon Sep 17 00:00:00 2001
From: Neil Conway <neilc@samurai.com>
Date: Thu, 4 Mar 2004 21:47:18 +0000
Subject: Emit a warning when an empty string is input to the oid, float4, and
 float8 types. This begins the deprecation of this feature: in 7.6, this input
 will be rejected.

Also added a new error code for warnings about deprecated features,
and updated the regression tests.
---
 src/backend/utils/adt/float.c | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

(limited to 'src/backend/utils/adt/float.c')

diff --git a/src/backend/utils/adt/float.c b/src/backend/utils/adt/float.c
index 7a869e2b3a3..f9c4894794f 100644
--- a/src/backend/utils/adt/float.c
+++ b/src/backend/utils/adt/float.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.96 2003/11/29 19:51:58 pgsql Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.97 2004/03/04 21:47:18 neilc Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -208,6 +208,19 @@ float4in(PG_FUNCTION_ARGS)
 					 errmsg("\"%s\" is out of range for type real", num)));
 	}
 
+	/*
+	 * In releases prior to 7.5, we accepted an empty string as valid
+	 * input (yielding a float4 of 0). In 7.5, we accept empty
+	 * strings, but emit a warning noting that the feature is
+	 * deprecated. In 7.6+, the warning should be replaced by an error.
+	 */
+	if (num == endptr)
+		ereport(WARNING,
+				(errcode(ERRCODE_WARNING_DEPRECATED_FEATURE),
+				 errmsg("deprecated input syntax for type real: \"\""),
+				 errdetail("This input will be rejected in "
+						   "a future release of PostgreSQL.")));
+
 	/*
 	 * if we get here, we have a legal double, still need to check to see
 	 * if it's a legal float
@@ -309,6 +322,19 @@ float8in(PG_FUNCTION_ARGS)
 					 errmsg("\"%s\" is out of range for type double precision", num)));
 	}
 
+	/*
+	 * In releases prior to 7.5, we accepted an empty string as valid
+	 * input (yielding a float8 of 0). In 7.5, we accept empty
+	 * strings, but emit a warning noting that the feature is
+	 * deprecated. In 7.6+, the warning should be replaced by an error.
+	 */
+	if (num == endptr)
+		ereport(WARNING,
+				(errcode(ERRCODE_WARNING_DEPRECATED_FEATURE),
+				 errmsg("deprecated input syntax for type double precision: \"\""),
+				 errdetail("This input will be rejected in "
+						   "a future release of PostgreSQL.")));
+
 	CheckFloat8Val(val);
 
 	PG_RETURN_FLOAT8(val);
-- 
cgit v1.2.3