From 7f798aca1d5df290aafad41180baea0ae311b4ee Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 28 Nov 2024 08:19:22 +0100 Subject: Remove useless casts to (void *) Many of them just seem to have been copied around for no real reason. Their presence causes (small) risks of hiding actual type mismatches or silently discarding qualifiers Discussion: https://www.postgresql.org/message-id/flat/461ea37c-8b58-43b4-9736-52884e862820@eisentraut.org --- src/backend/utils/adt/arrayfuncs.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'src/backend/utils/adt/arrayfuncs.c') diff --git a/src/backend/utils/adt/arrayfuncs.c b/src/backend/utils/adt/arrayfuncs.c index a715e7e0b8e..593775c27f3 100644 --- a/src/backend/utils/adt/arrayfuncs.c +++ b/src/backend/utils/adt/arrayfuncs.c @@ -3863,7 +3863,7 @@ array_eq(PG_FUNCTION_ARGS) (errcode(ERRCODE_UNDEFINED_FUNCTION), errmsg("could not identify an equality operator for type %s", format_type_be(element_type)))); - fcinfo->flinfo->fn_extra = (void *) typentry; + fcinfo->flinfo->fn_extra = typentry; } typlen = typentry->typlen; typbyval = typentry->typbyval; @@ -4027,7 +4027,7 @@ array_cmp(FunctionCallInfo fcinfo) (errcode(ERRCODE_UNDEFINED_FUNCTION), errmsg("could not identify a comparison function for type %s", format_type_be(element_type)))); - fcinfo->flinfo->fn_extra = (void *) typentry; + fcinfo->flinfo->fn_extra = typentry; } typlen = typentry->typlen; typbyval = typentry->typbyval; @@ -4222,7 +4222,7 @@ hash_array(PG_FUNCTION_ARGS) typentry = record_typentry; } - fcinfo->flinfo->fn_extra = (void *) typentry; + fcinfo->flinfo->fn_extra = typentry; } typlen = typentry->typlen; @@ -4316,7 +4316,7 @@ hash_array_extended(PG_FUNCTION_ARGS) (errcode(ERRCODE_UNDEFINED_FUNCTION), errmsg("could not identify an extended hash function for type %s", format_type_be(element_type)))); - fcinfo->flinfo->fn_extra = (void *) typentry; + fcinfo->flinfo->fn_extra = typentry; } typlen = typentry->typlen; typbyval = typentry->typbyval; @@ -4418,7 +4418,7 @@ array_contain_compare(AnyArrayType *array1, AnyArrayType *array2, Oid collation, (errcode(ERRCODE_UNDEFINED_FUNCTION), errmsg("could not identify an equality operator for type %s", format_type_be(element_type)))); - *fn_extra = (void *) typentry; + *fn_extra = typentry; } typlen = typentry->typlen; typbyval = typentry->typbyval; @@ -6437,7 +6437,7 @@ array_replace_internal(ArrayType *array, (errcode(ERRCODE_UNDEFINED_FUNCTION), errmsg("could not identify an equality operator for type %s", format_type_be(element_type)))); - fcinfo->flinfo->fn_extra = (void *) typentry; + fcinfo->flinfo->fn_extra = typentry; } typlen = typentry->typlen; typbyval = typentry->typbyval; @@ -6723,7 +6723,7 @@ width_bucket_array(PG_FUNCTION_ARGS) (errcode(ERRCODE_UNDEFINED_FUNCTION), errmsg("could not identify a comparison function for type %s", format_type_be(element_type)))); - fcinfo->flinfo->fn_extra = (void *) typentry; + fcinfo->flinfo->fn_extra = typentry; } /* -- cgit v1.2.3