From 2432b1a04087edc2fd9536c7c9aa4ca03fd1b363 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 25 Nov 2020 11:40:44 -0500 Subject: Avoid spamming the client with multiple ParameterStatus messages. Up to now, we sent a ParameterStatus message to the client immediately upon any change in the active value of any GUC_REPORT variable. This was only barely okay when the feature was designed; now that we have things like function SET clauses, there are very plausible use-cases where a GUC_REPORT variable might change many times within a query --- and even end up back at its original value, perhaps. Fortunately most of our GUC_REPORT variables are unlikely to be changed often; but there are proposals in play to enlarge that set, or even make it user-configurable. Hence, let's fix things to not generate more than one ParameterStatus message per variable per query, and to not send any message at all unless the end-of-query value is different from what we last reported. Discussion: https://postgr.es/m/5708.1601145259@sss.pgh.pa.us --- src/backend/tcop/postgres.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/backend/tcop/postgres.c') diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c index 7c5f7c775b9..34ed0e7558c 100644 --- a/src/backend/tcop/postgres.c +++ b/src/backend/tcop/postgres.c @@ -4229,6 +4229,9 @@ PostgresMain(int argc, char *argv[], pgstat_report_activity(STATE_IDLE, NULL); } + /* Report any recently-changed GUC options */ + ReportChangedGUCOptions(); + ReadyForQuery(whereToSendOutput); send_ready_for_query = false; } -- cgit v1.2.3