From 223b813d0ef76eebcb74f405cb77ed8855b37f4b Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 4 Jun 2004 03:24:04 +0000 Subject: Remove some long-obsolete code that was causing a strange error message when someone attempts to create a column of a composite datatype. For now, just make sure we produce a reasonable error at the 'right place'. Not sure if this will be made to work before 7.5, but make it act reasonably in case nothing more gets done. --- src/backend/parser/analyze.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) (limited to 'src/backend/parser') diff --git a/src/backend/parser/analyze.c b/src/backend/parser/analyze.c index 525c2eef251..104716bf455 100644 --- a/src/backend/parser/analyze.c +++ b/src/backend/parser/analyze.c @@ -6,7 +6,7 @@ * Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/backend/parser/analyze.c,v 1.302 2004/05/30 23:40:32 neilc Exp $ + * $PostgreSQL: pgsql/src/backend/parser/analyze.c,v 1.303 2004/06/04 03:24:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -3049,23 +3049,10 @@ makeFromExpr(List *fromlist, Node *quals) static void transformColumnType(ParseState *pstate, ColumnDef *column) { - TypeName *typename = column->typename; - Type ctype = typenameType(typename); - /* - * Is this the name of a complex type? If so, implement it as a set. - * - * XXX this is a hangover from ancient Berkeley code that probably - * doesn't work anymore anyway. + * All we really need to do here is verify that the type is valid. */ - if (typeTypeRelid(ctype) != InvalidOid) - { - /* - * (Eventually add in here that the set can only contain one - * element.) - */ - typename->setof = true; - } + Type ctype = typenameType(column->typename); ReleaseSysCache(ctype); } -- cgit v1.2.3