From 94150513ec12c13eb7c98430fc34f477896d38c9 Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Tue, 20 Mar 2018 11:33:44 -0400 Subject: Don't pass the grouping target around unnecessarily. Since commit 4f15e5d09de276fb77326be5567dd9796008ca2e made grouped_rel set reltarget, a variety of other functions can just get it from grouped_rel instead of having to pass it around explicitly. Simplify accordingly. Patch by me, reviewed by Ashutosh Bapat. Discussion: http://postgr.es/m/CA+TgmoZ+ZJTVad-=vEq393N99KTooxv9k7M+z73qnTAqkb49BQ@mail.gmail.com --- src/backend/optimizer/util/pathnode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/backend/optimizer/util/pathnode.c') diff --git a/src/backend/optimizer/util/pathnode.c b/src/backend/optimizer/util/pathnode.c index fe3b4582d42..22133fcf120 100644 --- a/src/backend/optimizer/util/pathnode.c +++ b/src/backend/optimizer/util/pathnode.c @@ -2651,12 +2651,12 @@ GroupPath * create_group_path(PlannerInfo *root, RelOptInfo *rel, Path *subpath, - PathTarget *target, List *groupClause, List *qual, double numGroups) { GroupPath *pathnode = makeNode(GroupPath); + PathTarget *target = rel->reltarget; pathnode->path.pathtype = T_Group; pathnode->path.parent = rel; @@ -2828,7 +2828,6 @@ GroupingSetsPath * create_groupingsets_path(PlannerInfo *root, RelOptInfo *rel, Path *subpath, - PathTarget *target, List *having_qual, AggStrategy aggstrategy, List *rollups, @@ -2836,6 +2835,7 @@ create_groupingsets_path(PlannerInfo *root, double numGroups) { GroupingSetsPath *pathnode = makeNode(GroupingSetsPath); + PathTarget *target = rel->reltarget; ListCell *lc; bool is_first = true; bool is_first_sort = true; -- cgit v1.2.3