From f9b5b41ef993a9b76b7f97b271df8034f1a24154 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 11 Nov 2002 22:19:25 +0000 Subject: Code review for ON COMMIT patch. Make the actual on-commit action happen before commit, not after :-( --- the original coding is not only unsafe if an error occurs while it's processing, but it generates an invalid sequence of WAL entries. Resurrect 7.2 logic for deleting items when no longer needed. Use an enum instead of random macros. Editorialize on names used for routines and constants. Teach backend/nodes routines about new field in CreateTable struct. Add a regression test. --- src/backend/nodes/outfuncs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/backend/nodes/outfuncs.c') diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c index b35763f23da..c5b5a493583 100644 --- a/src/backend/nodes/outfuncs.c +++ b/src/backend/nodes/outfuncs.c @@ -5,7 +5,7 @@ * Portions Copyright (c) 1996-2002, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $Header: /cvsroot/pgsql/src/backend/nodes/outfuncs.c,v 1.178 2002/11/06 22:31:24 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/nodes/outfuncs.c,v 1.179 2002/11/11 22:19:22 tgl Exp $ * * NOTES * Every (plan) node in POSTGRES has an associated "out" routine which @@ -117,8 +117,9 @@ _outCreateStmt(StringInfo str, CreateStmt *node) appendStringInfo(str, " :constraints "); _outNode(str, node->constraints); - appendStringInfo(str, " :hasoids %s ", - booltostr(node->hasoids)); + appendStringInfo(str, " :hasoids %s :oncommit %d ", + booltostr(node->hasoids), + (int) node->oncommit); } static void -- cgit v1.2.3