From 001bb9f3ed05e7c370151f7aad3a83447c52c157 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 10 Dec 2018 11:12:43 -0500 Subject: Add stack depth checks to key recursive functions in backend/nodes/*.c. Although copyfuncs.c has a check_stack_depth call in its recursion, equalfuncs.c, outfuncs.c, and readfuncs.c lacked one. This seems unwise. Likewise fix planstate_tree_walker(), in branches where that exists. Discussion: https://postgr.es/m/30253.1544286631@sss.pgh.pa.us --- src/backend/nodes/nodeFuncs.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/backend/nodes/nodeFuncs.c') diff --git a/src/backend/nodes/nodeFuncs.c b/src/backend/nodes/nodeFuncs.c index a10014f755b..54b3dcff3ec 100644 --- a/src/backend/nodes/nodeFuncs.c +++ b/src/backend/nodes/nodeFuncs.c @@ -3726,6 +3726,9 @@ planstate_tree_walker(PlanState *planstate, Plan *plan = planstate->plan; ListCell *lc; + /* Guard against stack overflow due to overly complex plan trees */ + check_stack_depth(); + /* initPlan-s */ if (planstate_walk_subplans(planstate->initPlan, walker, context)) return true; -- cgit v1.2.3