From 3a7ae6b3d91e0d011dba1eb8a29e1836c6a33c75 Mon Sep 17 00:00:00 2001 From: Alexander Korotkov Date: Mon, 4 Nov 2024 22:43:08 +0200 Subject: Revert pg_wal_replay_wait() stored procedure This commit reverts 3c5db1d6b0, and subsequent improvements and fixes including 8036d73ae3, 867d396ccd, 3ac3ec580c, 0868d7ae70, 85b98b8d5a, 2520226c95, 014f9f34d2, e658038772, e1555645d7, 5035172e4a, 6cfebfe88b, 73da6b8d1b, and e546989a26. The reason for reverting is a set of remaining issues. Most notably, the stored procedure appears to need more effort than the utility statement to turn the backend into a "snapshot-less" state. This makes an approach to use stored procedures questionable. Catversion is bumped. Discussion: https://postgr.es/m/Zyhj2anOPRKtb0xW%40paquier.xyz --- src/backend/lib/pairingheap.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) (limited to 'src/backend/lib/pairingheap.c') diff --git a/src/backend/lib/pairingheap.c b/src/backend/lib/pairingheap.c index 7858e5e076b..fe1deba13ec 100644 --- a/src/backend/lib/pairingheap.c +++ b/src/backend/lib/pairingheap.c @@ -44,26 +44,12 @@ pairingheap_allocate(pairingheap_comparator compare, void *arg) pairingheap *heap; heap = (pairingheap *) palloc(sizeof(pairingheap)); - pairingheap_initialize(heap, compare, arg); - - return heap; -} - -/* - * pairingheap_initialize - * - * Same as pairingheap_allocate(), but initializes the pairing heap in-place - * rather than allocating a new chunk of memory. Useful to store the pairing - * heap in a shared memory. - */ -void -pairingheap_initialize(pairingheap *heap, pairingheap_comparator compare, - void *arg) -{ heap->ph_compare = compare; heap->ph_arg = arg; heap->ph_root = NULL; + + return heap; } /* -- cgit v1.2.3