From 8dd7c7cd0a2605d5301266a6b67a569d6a305106 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Tue, 11 Mar 2025 12:02:38 +0100 Subject: Replace EEOP_DONE with special steps for return/no return Knowing when the side-effects of an expression is the intended result of the execution, rather than the returnvalue, is important for being able generate more efficient JITed code. This replaces EEOP_DONE with two new steps: EEOP_DONE_RETURN and EEOP_DONE_NO_RETURN. Expressions which return a value should use the former step; expressions used for their side-effects which don't return value should use the latter. Author: Andres Freund Co-authored-by: Daniel Gustafsson Reviewed-by: Andreas Karlsson Discussion: https://postgr.es/m/415721CE-7D2E-4B74-B5D9-1950083BA03E@yesql.se Discussion: https://postgr.es/m/20191023163849.sosqbfs5yenocez3@alap3.anarazel.de --- src/backend/jit/llvm/llvmjit_expr.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/backend/jit/llvm/llvmjit_expr.c') diff --git a/src/backend/jit/llvm/llvmjit_expr.c b/src/backend/jit/llvm/llvmjit_expr.c index f0f5c3bd49f..4080b01c17e 100644 --- a/src/backend/jit/llvm/llvmjit_expr.c +++ b/src/backend/jit/llvm/llvmjit_expr.c @@ -321,7 +321,7 @@ llvm_compile_expr(ExprState *state) switch (opcode) { - case EEOP_DONE: + case EEOP_DONE_RETURN: { LLVMValueRef v_tmpisnull; LLVMValueRef v_tmpvalue; @@ -335,6 +335,10 @@ llvm_compile_expr(ExprState *state) break; } + case EEOP_DONE_NO_RETURN: + LLVMBuildRet(b, l_sizet_const(0)); + break; + case EEOP_INNER_FETCHSOME: case EEOP_OUTER_FETCHSOME: case EEOP_SCAN_FETCHSOME: -- cgit v1.2.3