From d64713df7e5996ab3ab337b5e0901cf2c53773f9 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 12 Apr 2011 19:19:24 -0400 Subject: Pass collations to functions in FunctionCallInfoData, not FmgrInfo. Since collation is effectively an argument, not a property of the function, FmgrInfo is really the wrong place for it; and this becomes critical in cases where a cached FmgrInfo is used for varying purposes that might need different collation settings. Fix by passing it in FunctionCallInfoData instead. In particular this allows a clean fix for bug #5970 (record_cmp not working). This requires touching a bit more code than the original method, but nobody ever thought that collations would not be an invasive patch... --- src/backend/executor/execGrouping.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/backend/executor/execGrouping.c') diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index 1f02428a5b3..bfb8cbb303c 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -3,6 +3,10 @@ * execGrouping.c * executor utility routines for grouping, hashing, and aggregation * + * Note: we currently assume that equality and hashing functions are not + * collation-sensitive, so the code in this file has no support for passing + * collation settings through from callers. That may have to change someday. + * * Portions Copyright (c) 1996-2011, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * -- cgit v1.2.3