From bf56f0759bdfa87f143c3abd09f893a5f530fe88 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 10 Aug 2001 18:57:42 +0000 Subject: Make OIDs optional, per discussions in pghackers. WITH OIDS is still the default, but OIDS are removed from many system catalogs that don't need them. Some interesting side effects: TOAST pointers are 20 bytes not 32 now; pg_description has a three-column key instead of one. Bugs fixed in passing: BINARY cursors work again; pg_class.relhaspkey has some usefulness; pg_dump dumps comments on indexes, rules, and triggers in a valid order. initdb forced. --- src/backend/commands/cluster.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'src/backend/commands/cluster.c') diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c index e72d13897dc..0d76c6e8d37 100644 --- a/src/backend/commands/cluster.c +++ b/src/backend/commands/cluster.c @@ -15,7 +15,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/commands/cluster.c,v 1.67 2001/07/12 20:35:54 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/commands/cluster.c,v 1.68 2001/08/10 18:57:34 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -160,7 +160,9 @@ copy_heap(Oid OIDOldHeap, char *NewName, bool istemp) tupdesc = CreateTupleDescCopyConstr(OldHeapDesc); OIDNewHeap = heap_create_with_catalog(NewName, tupdesc, - RELKIND_RELATION, istemp, + OldHeap->rd_rel->relkind, + OldHeap->rd_rel->relhasoids, + istemp, allowSystemTableMods); /* @@ -227,7 +229,8 @@ copy_index(Oid OIDOldIndex, Oid OIDNewHeap, char *NewIndexName) Old_pg_index_Form->indisprimary, allowSystemTableMods); - setRelhasindex(OIDNewHeap, true); + setRelhasindex(OIDNewHeap, true, + Old_pg_index_Form->indisprimary, InvalidOid); ReleaseSysCache(Old_pg_index_Tuple); ReleaseSysCache(Old_pg_index_relation_Tuple); -- cgit v1.2.3