From cbdf75bf8053f88bbae6b307f34ab057424a370f Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 9 Sep 2021 07:58:12 +0200 Subject: Remove useless casts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Casting the argument of strVal() to (Value *) is useless, since strVal() already does that. Most code didn't do that anyway; this was apparently just a style that snuck into certain files. Reviewed-by: Dagfinn Ilmari Mannsåker Reviewed-by: Kyotaro Horiguchi Discussion: https://www.postgresql.org/message-id/flat/5ba6bc5b-3f95-04f2-2419-f8ddb4c046fb@enterprisedb.com --- src/backend/commands/alter.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src/backend/commands/alter.c') diff --git a/src/backend/commands/alter.c b/src/backend/commands/alter.c index 29249498a91..c47d54e96bb 100644 --- a/src/backend/commands/alter.c +++ b/src/backend/commands/alter.c @@ -501,7 +501,7 @@ ExecAlterObjectSchemaStmt(AlterObjectSchemaStmt *stmt, switch (stmt->objectType) { case OBJECT_EXTENSION: - address = AlterExtensionNamespace(strVal((Value *) stmt->object), stmt->newschema, + address = AlterExtensionNamespace(strVal(stmt->object), stmt->newschema, oldSchemaAddr ? &oldNspOid : NULL); break; @@ -837,10 +837,10 @@ ExecAlterOwnerStmt(AlterOwnerStmt *stmt) switch (stmt->objectType) { case OBJECT_DATABASE: - return AlterDatabaseOwner(strVal((Value *) stmt->object), newowner); + return AlterDatabaseOwner(strVal(stmt->object), newowner); case OBJECT_SCHEMA: - return AlterSchemaOwner(strVal((Value *) stmt->object), newowner); + return AlterSchemaOwner(strVal(stmt->object), newowner); case OBJECT_TYPE: case OBJECT_DOMAIN: /* same as TYPE */ @@ -848,23 +848,23 @@ ExecAlterOwnerStmt(AlterOwnerStmt *stmt) break; case OBJECT_FDW: - return AlterForeignDataWrapperOwner(strVal((Value *) stmt->object), + return AlterForeignDataWrapperOwner(strVal(stmt->object), newowner); case OBJECT_FOREIGN_SERVER: - return AlterForeignServerOwner(strVal((Value *) stmt->object), + return AlterForeignServerOwner(strVal(stmt->object), newowner); case OBJECT_EVENT_TRIGGER: - return AlterEventTriggerOwner(strVal((Value *) stmt->object), + return AlterEventTriggerOwner(strVal(stmt->object), newowner); case OBJECT_PUBLICATION: - return AlterPublicationOwner(strVal((Value *) stmt->object), + return AlterPublicationOwner(strVal(stmt->object), newowner); case OBJECT_SUBSCRIPTION: - return AlterSubscriptionOwner(strVal((Value *) stmt->object), + return AlterSubscriptionOwner(strVal(stmt->object), newowner); /* Generic cases */ -- cgit v1.2.3