From 4171c44c9b791da3c00386dc6d8e6b1842e3036b Mon Sep 17 00:00:00 2001 From: David Rowley Date: Tue, 3 Dec 2024 17:12:38 +1300 Subject: Revert "Introduce CompactAttribute array in TupleDesc" This reverts commit d28dff3f6cd6a7562fb2c211ac0fb74a33ffd032. Quite a large number of buildfarm members didn't like this commit and it's not yet clear why. Reverting this before too many animals turn red. Discussion: https://postgr.es/m/CAApHDvr9i6T5=iAwQCxFDgMsthr_obVxgwBaEJkC8KUH6yM3Hw@mail.gmail.com --- src/backend/access/spgist/spgutils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/backend/access/spgist/spgutils.c') diff --git a/src/backend/access/spgist/spgutils.c b/src/backend/access/spgist/spgutils.c index da858182173..e93d9869b27 100644 --- a/src/backend/access/spgist/spgutils.c +++ b/src/backend/access/spgist/spgutils.c @@ -331,9 +331,7 @@ getSpGistTupleDesc(Relation index, SpGistTypeDesc *keyType) att->attcollation = InvalidOid; /* In case we changed typlen, we'd better reset following offsets */ for (int i = spgFirstIncludeColumn; i < outTupDesc->natts; i++) - TupleDescCompactAttr(outTupDesc, i)->attcacheoff = -1; - - populate_compact_attribute(outTupDesc, spgKeyColumn); + TupleDescAttr(outTupDesc, i)->attcacheoff = -1; } return outTupDesc; } -- cgit v1.2.3