From aa6954104644334c53838f181053b9f7aa13f58c Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 7 Feb 2023 06:53:05 +0100 Subject: Remove useless casts to (void *) in arguments of some system functions The affected functions are: bsearch, memcmp, memcpy, memset, memmove, qsort, repalloc Reviewed-by: Corey Huinker Discussion: https://www.postgresql.org/message-id/flat/fd9adf5d-b1aa-e82f-e4c7-263c30145807%40enterprisedb.com --- src/backend/access/gist/gistproc.c | 4 ++-- src/backend/access/gist/gistutil.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/backend/access/gist') diff --git a/src/backend/access/gist/gistproc.c b/src/backend/access/gist/gistproc.c index eb9178d4560..4881034069b 100644 --- a/src/backend/access/gist/gistproc.c +++ b/src/backend/access/gist/gistproc.c @@ -173,7 +173,7 @@ gist_box_union(PG_FUNCTION_ARGS) numranges = entryvec->n; pageunion = (BOX *) palloc(sizeof(BOX)); cur = DatumGetBoxP(entryvec->vector[0].key); - memcpy((void *) pageunion, (void *) cur, sizeof(BOX)); + memcpy(pageunion, cur, sizeof(BOX)); for (i = 1; i < numranges; i++) { @@ -1043,7 +1043,7 @@ gist_poly_compress(PG_FUNCTION_ARGS) BOX *r; r = (BOX *) palloc(sizeof(BOX)); - memcpy((void *) r, (void *) &(in->boundbox), sizeof(BOX)); + memcpy(r, &(in->boundbox), sizeof(BOX)); retval = (GISTENTRY *) palloc(sizeof(GISTENTRY)); gistentryinit(*retval, PointerGetDatum(r), diff --git a/src/backend/access/gist/gistutil.c b/src/backend/access/gist/gistutil.c index 56451fede10..b4d843a0ff1 100644 --- a/src/backend/access/gist/gistutil.c +++ b/src/backend/access/gist/gistutil.c @@ -113,7 +113,7 @@ gistextractpage(Page page, int *len /* out */ ) IndexTuple * gistjoinvector(IndexTuple *itvec, int *len, IndexTuple *additvec, int addlen) { - itvec = (IndexTuple *) repalloc((void *) itvec, sizeof(IndexTuple) * ((*len) + addlen)); + itvec = (IndexTuple *) repalloc(itvec, sizeof(IndexTuple) * ((*len) + addlen)); memmove(&itvec[*len], additvec, sizeof(IndexTuple) * addlen); *len += addlen; return itvec; -- cgit v1.2.3