From 54a3615f15b9b2e1433bc47cfb150317885d7c1f Mon Sep 17 00:00:00 2001 From: Melanie Plageman Date: Thu, 3 Apr 2025 18:22:37 -0400 Subject: Remove misleading read stream asserts in a few users Several read stream users asserted that the read stream was exhausted after looping on that very condition. It was pointed out in an a review of an as-of-yet uncommitted read stream user [1] that this was confusing and could lead the reader to think there was a possibility of some kind of race condition. Remove these asserts. [1] https://postgr.es/m/F9ACE8D0-B807-4A17-B6BD-87EF0717983D%40yesql.se --- src/backend/access/gist/gistvacuum.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/backend/access/gist/gistvacuum.c') diff --git a/src/backend/access/gist/gistvacuum.c b/src/backend/access/gist/gistvacuum.c index ce9d78d78d6..6a359c98c60 100644 --- a/src/backend/access/gist/gistvacuum.c +++ b/src/backend/access/gist/gistvacuum.c @@ -254,8 +254,6 @@ gistvacuumscan(IndexVacuumInfo *info, IndexBulkDeleteResult *stats, gistvacuumpage(&vstate, buf); } - Assert(read_stream_next_buffer(stream, NULL) == InvalidBuffer); - /* * We have to reset the read stream to use it again. After returning * InvalidBuffer, the read stream API won't invoke our callback again -- cgit v1.2.3