From 8aa538cfd5a2bcdfc54aced86c7c17b502742fc6 Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Thu, 29 Nov 2001 19:40:37 +0000 Subject: * When postgres.h does not define BYTE_ENDIAN pgcrypto produces garbage. I learned the hard way that #if UNDEFINED_1 == UNDEFINED_2 #error "gcc is idiot" #endif prints "gcc is idiot" ... Affected are MD5/SHA1 in internal library, and also HMAC-MD5/HMAC-SHA1/ crypt-md5 which use them. Blowfish is ok, also Rijndael on at least x86. Big thanks to Daniel Holtzman who send me a build log which contained warning: md5.c:246: warning: `X' defined but not used Yes, gcc is that helpful... Please apply this. -- marko --- contrib/pgcrypto/crypt-des.c | 1 + 1 file changed, 1 insertion(+) (limited to 'contrib/pgcrypto/crypt-des.c') diff --git a/contrib/pgcrypto/crypt-des.c b/contrib/pgcrypto/crypt-des.c index 782f4c0ddbd..dc14ceae66d 100644 --- a/contrib/pgcrypto/crypt-des.c +++ b/contrib/pgcrypto/crypt-des.c @@ -60,6 +60,7 @@ #include "postgres.h" +#include "px.h" #include "px-crypt.h" /* for ntohl/htonl */ -- cgit v1.2.3