From 6278a2a262b63faaf47eb2371f6bcb5b6e3ff118 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 2 Apr 2018 12:36:21 -0400 Subject: Remove contrib/jsonb_plpython's tests for infinity and NaN conversions. These tests don't work reliably with pre-2.6 Python versions, since Python code like float('inf') was not guaranteed to work before that, even granting an IEEE-compliant platform. Since there's no explicit handling of these cases in jsonb_plpython, we're not adding any real code coverage by testing them, and thus it doesn't seem to make sense to go to any great lengths to work around the test instability. Discussion: https://postgr.es/m/E1f1AMU-00031c-9N@gemulon.postgresql.org --- contrib/jsonb_plpython/sql/jsonb_plpython.sql | 35 --------------------------- 1 file changed, 35 deletions(-) (limited to 'contrib/jsonb_plpython/sql/jsonb_plpython.sql') diff --git a/contrib/jsonb_plpython/sql/jsonb_plpython.sql b/contrib/jsonb_plpython/sql/jsonb_plpython.sql index b4b0820afe6..2ee1bca0a98 100644 --- a/contrib/jsonb_plpython/sql/jsonb_plpython.sql +++ b/contrib/jsonb_plpython/sql/jsonb_plpython.sql @@ -127,41 +127,6 @@ SELECT roundtrip('[1, true]'::jsonb); SELECT roundtrip('[true, "string"]'::jsonb); SELECT roundtrip('["string", "string2"]'::jsonb); --- test python infinity -> jsonb -CREATE FUNCTION test1inf() RETURNS jsonb -LANGUAGE plpythonu -TRANSFORM FOR TYPE jsonb -AS $$ -x = float('inf') -print(x) -return x -$$; - -SELECT test1inf(); - --- test python -infinity -> jsonb -CREATE FUNCTION test2inf() RETURNS jsonb -LANGUAGE plpythonu -TRANSFORM FOR TYPE jsonb -AS $$ -x = float('-inf') -print(x) -return x -$$; - -SELECT test2inf(); - --- test python NaN -> jsonb -CREATE FUNCTION test1nan() RETURNS jsonb -LANGUAGE plpythonu -TRANSFORM FOR TYPE jsonb -AS $$ -x = float('nan') -return x -$$; - -SELECT test1nan(); - -- complex numbers -> jsonb CREATE FUNCTION testComplexNumbers() RETURNS jsonb LANGUAGE plpythonu -- cgit v1.2.3