aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* may -> mightPeter Eisentraut2007-12-28
|
* Sorry, hit the wrong button with my last commit. Here's the correct changelog:Michael Meskes2007-12-28
| | | | | Applied patch send by ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> to fix bug in connect statement if user name is a variable. Also fixed test case that didn't detect this.
* *** empty log message ***Michael Meskes2007-12-28
|
* Improve consistency of error reporting in GUC assign_hook routines. SomeTom Lane2007-12-28
| | | | | | | | | | | | | | were reporting ERROR for interactive assignments and LOG for other cases, some were saying nothing for non-interactive cases, and a few did yet other things. Make them use a new function GUC_complaint_elevel() to establish a reasonably uniform policy about how to report. There are still a few edge cases such as assign_search_path(), but it's much better than before. Per gripe from Devrim Gunduz and subsequent discussion. As noted by Alvaro, it'd be better to fold these custom messages into the standard "invalid parameter value" complaint from guc.c, perhaps as the DETAIL field. However that will require more redesign than seems prudent for 8.3. This is a relatively safe, low-impact change that we can afford to risk now.
* Disallow digits and lower-case ASCII letters as the delimiter in non-CSVTom Lane2007-12-27
| | | | | | | | | | | | COPY. We need a restriction here because when the delimiter occurs as a data character, it is emitted with a backslash, and that will only work as desired if CopyReadAttributesText() will interpret the backslash sequence as representing the second character literally. This is currently untrue for 'b', 'f', 'n', 'r', 't', 'v', 'x', and octal digits. For future-proofing and simplicity of explanation, it seems best to disallow a-z and 0-9. We must also disallow dot, since "\." by itself would look like copy EOF. Note: "\N" is by default the null print string, so N would also cause a problem, but that is already tested for.
* Fix ill-advised usage of x?y:z expressions in errmsg() and errhint() calls.Tom Lane2007-12-27
| | | | | This prevented gettext from recognizing the strings that need to be translated.
* Swap the order of testing for control characters and for column delimiter inTom Lane2007-12-27
| | | | | | | | CopyAttributeOutText(), so that control characters are converted to the C-style escape sequences even if they happen to be equal to the column delimiter (as is true by default for tab, for example). Oversight in my previous patch to restore pre-8.3 behavior of COPY OUT escaping. Per report from Tomas Szepe.
* Wording improvementsPeter Eisentraut2007-12-27
|
* Update find_typedefs to handle simple 'typedef X' cases, per requestBruce Momjian2007-12-21
| | | | from Tom.
* Fixed a few minor glitches pointed out by splint.Michael Meskes2007-12-21
|
* Modify pgindent to use an external typedefs file rather than includedBruce Momjian2007-12-21
| | | | | | list. Remove pgjindent.
* libpq needs pgsleep on win32 because of the changes to port/open.c.Magnus Hagander2007-12-21
|
* On win32, loop when opening files if sharing- och lock-violation errorsMagnus Hagander2007-12-20
| | | | | occur. Hopefully, this will make it possible to recover from broken antivirus and/or backup software that locks our files.
* When given a nonzero column number, pg_get_indexdef() is only supposed toTom Lane2007-12-20
| | | | | | | | | print the index key variable or expression for that column. It was mistakenly printing ASC/DESC/NULLS FIRST/NULLS LAST decoration too --- and not only for the target column, but all columns. Someday we should have an option to extract that info (and the opclass decoration as well) for a single index column ... but today is not that day. Per bug #3829 and subsequent discussion.
* Remove unnecessary logo output from msbuild when cleaning ecpg regressionMagnus Hagander2007-12-19
| | | | test outputs.
* Make all msvc build scripts use buildenv.pl, not buildenv.bat.Magnus Hagander2007-12-19
| | | | Andrew Dunstan
* Fix thinko in encoding check for chr()Andrew Dunstan2007-12-18
|
* Make archiver process report its progress in PS display. PerTom Lane2007-12-18
| | | | proposal by Simon Riggs, though not exactly his patch.
* Make path_recv() and poly_recv() reject paths/polygons containing no points.Tom Lane2007-12-18
| | | | | | | | The zero-point case is sensible so far as the data structure is concerned, so maybe we ought to allow it sometime; but right now the textual input routines for these types don't allow it, and it seems that not all the functions for the types are prepared to cope. Report and patch by Merlin Moncure.
* Mention use all configure options when getting pgindent typedefs.Bruce Momjian2007-12-17
|
* Mention installing /contrib libraries for pgindent.Bruce Momjian2007-12-17
|
* Get dllwrap name from variable instead of hardcoded.Magnus Hagander2007-12-15
| | | | Per complaint from Richard Evans
* Clarify log messagesPeter Eisentraut2007-12-13
|
* Mark items needing updating for beta stamping.Bruce Momjian2007-12-13
|
* Improve the method of localizing column names and other fixed strings inTom Lane2007-12-12
| | | | | | | | | | | | | | | psql's \d commands and other uses of printQuery(). Previously we would pass these strings through gettext() and then send them to the server as literals in the SQL query. But the code was not set up to handle doubling of quotes in the strings, causing failure if a translation attempted to use the wrong kind of quote marks, as indeed is now the case for (at least) the French translation of \dFp. Another hazard was that gettext() would translate to whatever encoding was implied by the client's LC_CTYPE setting, which might be different from the client_encoding setting, which would probably cause the server to reject the query as mis-encoded. The new arrangement is to send the untranslated ASCII strings to the server, and do the translations inside printQuery() after the query results come back. Per report from Guillaume Lelarge and subsequent discussion.
* Clean up unportable attempt to use #if inside a macro call, alsoTom Lane2007-12-12
| | | | faulty code in third arm of #if. Per buildfarm reports.
* Provide a more accurate, detailed log message when the archive command fails.Peter Eisentraut2007-12-12
|
* Make CSV column ordering a bit more logical.Alvaro Herrera2007-12-11
|
* Make documentation of -W options more accurate and uniform.Tom Lane2007-12-11
|
* Remove the long-deprecated -u option from psql, since it does nothing veryTom Lane2007-12-11
| | | | | | | | useful and confuses people who think it is the same as -U. (Eventually we might want to re-introduce it as being an alias for -U, but that should not happen until the switch has actually not been there for a few releases.) Likewise in pg_dump and pg_restore. Per gripe from Robert Treat and subsequent discussion.
* Extend the format of CSV logs to include the additional information suppliedAlvaro Herrera2007-12-11
| | | | | | | with the logged event. CSV logs are now a first-class citizen along plain text logs in that they carry much of the same information. Per complaint from depesz on bug #3799.
* Use _USE_32BIT_TIME_T when building with MSVC. Also, enforce that it'sMagnus Hagander2007-12-11
| | | | | | used when building addons. Dave Page
* Fix attribution for Rime of the Ancient Mariner (obviously it's beenTom Lane2007-12-10
| | | | too long since freshman English :-()
* The E. J. Pratt verse used as a tsearch test case is unfortunately stillTom Lane2007-12-09
| | | | | under copyright in the US and many other places. Substitute a little something from a poet who's more safely dead. Per gripe from Bjorn Munch.
* Fix bogus prompt for password in -u case. Per gripe from Robert Treat.Tom Lane2007-12-09
|
* Fix up the PQconnectionUsedPassword mess: create a separateTom Lane2007-12-09
| | | | | | | | PQconnectionNeedsPassword function that tells the right thing for whether to prompt for a password, and improve PQconnectionUsedPassword so that it checks whether the password used by the connection was actually supplied as a connection argument, instead of coming from environment or a password file. Per bug report from Mark Cave-Ayland and subsequent discussion.
* Fix mergejoin cost estimation so that we consider the statistical ranges ofTom Lane2007-12-08
| | | | | | | | | | the two join variables at both ends: not only trailing rows that need not be scanned because there cannot be a match on the other side, but initial rows that will be scanned without possibly having a match. This allows a more realistic estimate of startup cost to be made, per recent pgsql-performance discussion. In passing, fix a couple of bugs that had crept into mergejoinscansel: it was not quite up to speed for the task of estimating descending-order scans, which is a new requirement in 8.3.
* Realign the running text in this file to 79 characters wide. Some otherPeter Eisentraut2007-12-07
| | | | copy-editing.
* Disable asserts by default on msvc build (to make it the sameMagnus Hagander2007-12-06
| | | | as in unix)
* Change wording of logged message when cancelling an autovacuum task, usingAlvaro Herrera2007-12-06
| | | | | american speling (unlike this commit message). Per complaint from Mike C. on bug #3790 and subsequent discussion.
* Don't send an empty SSPI negotiation packet at the end of the negotiation.Magnus Hagander2007-12-04
| | | | Fixes bug #3750
* Fix build_minmax_path() to cope if an IS NULL clause turns up in theTom Lane2007-12-03
| | | | | | indexable-clauses list for a btree index. Formerly it just Asserted that all such clauses were opclauses, but that's no longer true in 8.3. Per bug #3796 from Matthias Schoeneich.
* Default to integer timestamps being off until 8.4, to correspondMagnus Hagander2007-12-03
| | | | to the settings used for other platforms.
* Don't try to install README.spiMagnus Hagander2007-12-03
| | | | Hannes Eder
* Stamp 8.3beta4.REL8_3_BETA4Tom Lane2007-12-03
|
* Revert COPY OUT to follow the pre-8.3 handling of ASCII control characters,Tom Lane2007-12-03
| | | | | | | | | | namely that \r, \n, \t, \b, \f, \v are dumped as those two-character representations rather than a backslash and the literal control character. I had made it do the other to save some code, but this was ill-advised, because dump files in which these characters appear literally are prone to newline mangling. Fortunately, doing it the old way should only cost a few more lines of code, and not slow down the copy loop materially. Per bug #3795 from Lou Duchez.
* Code review for LIKE ... INCLUDING INDEXES patch. Fix failure to propagateTom Lane2007-12-01
| | | | | | | | | | constraint status of copied indexes (bug #3774), as well as various other small bugs such as failure to pstrdup when needed. Allow INCLUDING INDEXES indexes to be merged with identical declared indexes (perhaps not real useful, but the code is there and having it not apply to LIKE indexes seems pretty unorthogonal). Avoid useless work in generateClonedIndexStmt(). Undo some poorly chosen API changes, and put a couple of routines in modules that seem to be better places for them.
* Suppress compiler warnings in recent plperl patch. Avoid uselessly expensiveTom Lane2007-12-01
| | | | lookup of the well-known OID of textout().
* Revert inadvertantly committed change.Andrew Dunstan2007-12-01
|
* Workaround for perl problem where evaluating UTF8 regexes can causeAndrew Dunstan2007-12-01
| | | | | | implicit loading of modules, thereby breaking Safe rules. We compile and call a tiny perl function on trusted interpreter init, after which the problem does not occur.