aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Use Unix line endings instead of DOS ones, per Magnus.Bruce Momjian2006-06-26
|
* Update include files to Unix newline format, per report from Magnus.Bruce Momjian2006-06-26
|
* Update comment description of geo routines and move comment to moreBruce Momjian2006-06-26
| | | | relevant location.
* Added some more coverity report patches send in by Joachim Wieland ↵Michael Meskes2006-06-26
| | | | <joe@mcknight.de>.
* Tweak dynahash.c to avoid wasting memory space in non-shared hash tables.Tom Lane2006-06-25
| | | | | | | | palloc() will normally round allocation requests up to the next power of 2, so make dynahash choose allocation sizes that are as close to a power of 2 as possible. Back-patch to 8.1 --- the problem exists further back, but a much larger patch would be needed and it doesn't seem worth taking any risks.
* Moved some free() calls that coverity correctly complains about.Michael Meskes2006-06-25
|
* Our version of getopt_long does not set optarg upon detecting an error, asAlvaro Herrera2006-06-25
| | | | | | opposed to what other versions apparently do, so it's not safe to print an error message. Besides, getopt_long itself already did, so it's redundant anyway.
* Remove individual user copyright because the code is contributed toBruce Momjian2006-06-25
| | | | | | | | | PGDG: > Yes. In fact the copyright belongs to credativ GmbH the company that > paid Carsten for his work. As you may or may not know I'm the CEO of > that company and can assure you that his work was contributed to the > PostgreSQL project.
* Fix GEVHDRSZ for Win32.Bruce Momjian2006-06-25
| | | | Magnus Hagander
* Fix Win32/Cygwin problems:Bruce Momjian2006-06-25
| | | | | | | | | | | | | | After updating to the latest cvs, and also building most of the addons (like PLs), the following patch is neededf for win32 + Visual C++. * Switch to use the new win32 semaphore code * Rename win32_open to pgwin32_open. win32_open collides with symbols defined in Perl. MingW didn't detect ig, MSVC did. And it's a bit too generic a name to export globally, imho... * Python defines some partially broken #pragmas in the headers when doing a debug build. Workaround. Magnus Hagander
* Fix re-inclusion of port header file on Windows, per Magnus.Tom Lane2006-06-24
|
* Clarified copyright noticeMichael Meskes2006-06-23
|
* Remove dllinit.c; it was only needed for long-obsolete Cygwin versions,Tom Lane2006-06-22
| | | | and there was some question about its copyright status.
* pg_stop_backup was calling XLogArchiveNotify() twice for the newly createdTom Lane2006-06-22
| | | | | backup history file. Bug introduced by the 8.1 change to make pg_stop_backup delete older history files. Per report from Masao Fujii.
* Standalone backends need pgstat_bestart() too, per Qingqing Zhou.Tom Lane2006-06-22
|
* Move setup_cancel_handler() up near start of psql main(), where theTom Lane2006-06-21
| | | | | setup_win32_locks() call formerly was, to ensure that cancelConnLock is valid when it needs to be. Per Yoshiyuki Asaba.
* Remove ancient kluge that kept nodeAgg.c from crashing on UPDATEs involvingTom Lane2006-06-21
| | | | | | aggregates. We just disallowed that, and AFAICS there should be no other cases where direct (non-aggregated) references to input columns are allowed in a query with aggregation and no GROUP BY.
* Disallow aggregate functions in UPDATE commands (unless within a sub-SELECT).Tom Lane2006-06-21
| | | | | | | | This is disallowed by the SQL spec because it doesn't have any very sensible interpretation. Historically Postgres has allowed it but behaved strangely. As of PG 8.1 a server crash is possible if the MIN/MAX index optimization gets applied; rather than try to "fix" that, it seems best to just enforce the spec restriction. Per report from Josh Drake and Alvaro Herrera.
* Eliminate a gratuitously different wording of the 'cannot use aggregate ↵Tom Lane2006-06-21
| | | | function in check constraint' error message.
* Clean up psql variable code a little: eliminate unnecessary tests inTom Lane2006-06-21
| | | | | | | GetVariable() and be consistent about treatment of the list header. Motivated by noticing strspn() taking an unreasonable percentage of runtime --- the call removed from GetVariable() was the only one that could be in a high-usage path ...
* Added some more coverity report patches send in by Martijn van Oosterhout ↵Michael Meskes2006-06-21
| | | | <kleptog@svana.org>.
* Fixed small typo in changelogMichael Meskes2006-06-21
|
* Added fixed from the coverity report send in by Joachim Wieland ↵Michael Meskes2006-06-21
| | | | | | <joe@mcknight.de> Added missing error handling in a few functions in ecpglib
* Remove redundant gettimeofday() calls to the extent practical withoutTom Lane2006-06-20
| | | | | | | | | | | changing semantics too much. statement_timestamp is now set immediately upon receipt of a client command message, and the various places that used to do their own gettimeofday() calls to mark command startup are referenced to that instead. I have also made stats_command_string use that same value for pg_stat_activity.query_start for both the command itself and its eventual replacement by <IDLE> or <idle in transaction>. There was some debate about that, but no argument that seemed convincing enough to justify an extra gettimeofday() call.
* Split definitions for md5.c out of crypt.h and into their own headerTom Lane2006-06-20
| | | | | | | | | libpq/md5.h, so that there's a clear separation between backend-only definitions and shared frontend/backend definitions. (Turns out this is reversing a bad decision from some years ago...) Fix up references to crypt.h as needed. I looked into moving the code into src/port, but the headers in src/include/libpq are sufficiently intertwined that it seems more work than it's worth to do that.
* Do not use already free'ed errmsg, bug found by Joachim WielandMichael Meskes2006-06-19
| | | | <joachim.wieland@credativ.de>
* Take the statistics collector out of the loop for monitoring backends'Tom Lane2006-06-19
| | | | | | | current commands; instead, store current-status information in shared memory. This substantially reduces the overhead of stats_command_string and also ensures that pg_stat_activity is fully up to date at all times. Per my recent proposal.
* Don't try to call posix_fadvise() unless <fcntl.h> supplies a declarationTom Lane2006-06-18
| | | | | | | | for it. Hopefully will fix core dump evidenced by some buildfarm members since fadvise patch went in. The actual definition of the function is not ABI-compatible with compiler's default assumption in the absence of any declaration, so it's clearly unsafe to try to call it without seeing a declaration.
* Fix saveHistory() to not emit bogus complaint during psql exit when usingTom Lane2006-06-18
| | | | | Darwin's libedit; per my proposal last August. Also, suppress cast-away- const warnings.
* Increase timeout in statement_timeout test from 1 second to 2 seconds.Tom Lane2006-06-18
| | | | | | | | | We have once or twice seen failures suggesting that control didn't get to the exception block before the timeout elapsed, which is unlikely but not impossible in a parallel regression test (with a dozen other backends competing for cycles). This change doesn't completely prevent the problem of course, but it should reduce the probability enough that we don't see it anymore. Per buildfarm results.
* Merge postmaster and postgres command into just postgres. postmasterPeter Eisentraut2006-06-18
| | | | | symlink is kept for now for compatibility. To call single-user mode, use postgres --single.
* Fix a couple of obvious problems in DROP IF EXISTS patch.Tom Lane2006-06-16
|
* Code review for SELECT INTO STRICT patch: use saner choices of errorTom Lane2006-06-16
| | | | SQLSTATEs, fix some documentation problems.
* Document issues with non-default tablespaces and pg_dumpall restores.Bruce Momjian2006-06-16
| | | | Backpatch documentation addition to 8.1.X.
* DROP ... IF EXISTS for the following cases:Andrew Dunstan2006-06-16
| | | | language, tablespace, trigger, rule, opclass, function, aggregate. operator, and cast.
* Fix problems with cached tuple descriptors disappearing while still in useTom Lane2006-06-16
| | | | | | | | | | by creating a reference-count mechanism, similar to what we did a long time ago for catcache entries. The back branches have an ugly solution involving lots of extra copies, but this way is more efficient. Reference counting is only applied to tupdescs that are actually in caches --- there seems no need to use it for tupdescs that are generated in the executor, since they'll go away during plan shutdown by virtue of being in the per-query memory context. Neil Conway and Tom Lane
* Test for POSIX_FADV_DONTNEED to use posix_fadvise().Bruce Momjian2006-06-16
|
* Use posix_fadvise() to avoid kernel caching of WAL contents on WAL fileBruce Momjian2006-06-15
| | | | | | close. ITAGAKI Takahiro
* Add STRICT to PL/pgSQL SELECT INTO, so exceptions are thrown if more orBruce Momjian2006-06-15
| | | | | | | | | less than one row is returned by the SELECT, for Oracle PL/SQL compatibility. Improve SELECT INTO documentation. Matt Miller
* Remove the limit on the number of entries allowed in catcaches, andTom Lane2006-06-15
| | | | | | | | | | | | | | | | | | remove the infrastructure needed to enforce the limit, ie, the global LRU list of cache entries. On small-to-middling databases this wins because maintaining the LRU list is a waste of time. On large databases this wins because it's better to keep more cache entries (we assume such users can afford to use some more per-backend memory than was contemplated in the Berkeley-era catcache design). This provides a noticeable improvement in the speed of psql \d on a 10000-table database, though it doesn't make it instantaneous. While at it, use per-catcache settings for the number of hash buckets per catcache, rather than the former one-size-fits-all value. It's a bit silly to be using the same number of hash buckets for, eg, pg_am and pg_attribute. The specific values I used might need some tuning, but they seem to be in the right ballpark based on CATCACHE_STATS results from the standard regression tests.
* Further thoughts about lo_export/lo_import error handling: if one ofTom Lane2006-06-14
| | | | | | | the lower-level large object functions fails, it will have already set a suitable error message --- probably something from the backend --- and it is not useful to overwrite that with a generic 'error while reading large object' message. So remove redundant messages.
* Clean up psql's control-C handling to avoid longjmp'ing out of randomTom Lane2006-06-14
| | | | | | | | | places --- that risks corrupting data structures, losing sync with the backend, etc. We now longjmp only from calls to readline, fgets, and fread, which we assume are coded to protect themselves against interrupts at undesirable times. This requires adding explicit tests for cancel_pressed in long-running loops, but on the whole it's far cleaner. Martijn van Oosterhout and Tom Lane.
* Improve error detection and recovery in lo_import()/lo_export().Tom Lane2006-06-14
| | | | Problems noted while experimenting with new control-C code for psql.
* Do a CHECK_FOR_INTERRUPTS immediately before terminating a fastpathTom Lane2006-06-14
| | | | | | | | | function call. Previously, there may have been no CHECK_FOR_INTERRUPTS at all in the fastpath code path, making it impossible to cancel an operation such as \lo_import externally. This addition doesn't ensure you can cancel, since your SIGINT may arrive while the backend is idle waiting for the client, but it gives the largest window we can easily provide. Noted while experimenting with new control-C code for psql.
* Add BY clause to PL/PgSQL FOR loop, to control the iteration increment.Bruce Momjian2006-06-12
| | | | Jaime Casanova
* Avoid use of C commment inside C comment from recent Win32 int overflow patch.Bruce Momjian2006-06-12
|
* Prevent Win32 from displaying a popup box on backend crash. Instead letBruce Momjian2006-06-12
| | | | | | the postmaster deal with it. Magnus Hagander
* Win32 can't catch the exception thrown by INT_MIN / -1 or INT_MIN * -1,Bruce Momjian2006-06-12
| | | | | | | so on that platform we test for those before the computation and throw an "out of range" error. Backpatch to 8.1.X.
* Minor code cleanup: make the WIN32 case less gratuitously different fromTom Lane2006-06-12
| | | | the other platform-specific cases in ps_status.
* Code review for psql multiline history patch(es). Fix memory leak,Tom Lane2006-06-11
| | | | | failure to enter commands in history if canceled by control-C, other infelicities.