aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
...
* Fix Assert failure when a fastpath function call is attempted inside anTom Lane2006-06-11
| | | | | | | | | | | | | | | already-aborted transaction block. GetSnapshotData throws an Assert if not in a valid transaction; hence we mustn't attempt to set a snapshot for the function until after checking for aborted transaction. This is harmless AFAICT if Asserts aren't enabled (GetSnapshotData will compute a bogus snapshot, but it doesn't matter since HandleFunctionRequest will throw an error shortly anywy). Hence, not a major bug. Along the way, add some ability to log fastpath calls when statement logging is turned on. This could probably stand to be improved further, but not logging anything is clearly undesirable. Backpatched as far as 8.0; bug doesn't exist before that.
* Repair remarkably-inefficient query for dumping large object comments: itTom Lane2006-06-09
| | | | | | was invoking obj_description() for each large object chunk, instead of once per large object. This code is new as of 8.1, which may explain why the problem hadn't been noticed already.
* Revert sampling patch for EXPLAIN ANALYZE; it turns out to be too unreliableTom Lane2006-06-09
| | | | | because node timing is much less predictable than the patch expects. I kept the API change for InstrStopNode, however.
* Fix bootstrap.c so that database startup process and bgwriter properly releaseTom Lane2006-06-08
| | | | | | | | | | | | LWLocks during a panic exit. This avoids the possible self-deadlock pointed out by Qingqing Zhou. Also, I noted that an error during LoadFreeSpaceMap() or BuildFlatFiles() would result in exit(0) which would leave the postmaster thinking all is well. Added a critical section to ensure such errors don't allow startup to proceed. Backpatched to 8.1. The 8.0 code is a bit different and I'm not sure if the problem exists there; given we've not seen this reported from the field, I'm going to be conservative about backpatching any further.
* Remove Win32 file, moved to /port.Bruce Momjian2006-06-08
| | | | Magnus Hagander
* Remove obsolete comment about VACUUM FULL: it takes buffer content locksTom Lane2006-06-08
| | | | | now, and must do so to ensure bgwriter doesn't write a page that is in process of being compacted.
* Allow timezone names in SQL strings,Bruce Momjian2006-06-07
| | | | | | '2006-05-24 21:11 Americas/New_York'::timestamptz Joachim Wieland
* Prepare code to be built by MSVC:Bruce Momjian2006-06-07
| | | | | | | | | | o remove many WIN32_CLIENT_ONLY defines o add WIN32_ONLY_COMPILER define o add 3rd argument to open() for portability o add include/port/win32_msvc directory for system includes Magnus Hagander
* Per previous analysis, the most correct notion of SampleOverhead is thatTom Lane2006-06-07
| | | | | | | it is just the total time to do INSTR_TIME_SET_CURRENT(), and not any of the other code involved in InstrStartNode/InstrStopNode. Even though I fear we may end up reverting this patch altogether, we may as well have the most correct version in our CVS archive.
* Have REINDEX use NOTICE, so it can be suppressed.Bruce Momjian2006-06-07
|
* Remove "fuzzy comparison" logic in qsort comparison function forTom Lane2006-06-07
| | | | | | | | | | | | choose_bitmap_and(). It was way too fuzzy --- per comment, it was meant to be 1% relative difference, but was actually coded as 0.01 absolute difference, thus causing selectivities of say 0.001 and 0.000000000001 to be treated as equal. I believe this thinko explains Maxim Boguk's recent complaint. While we could change it to a relative test coded like compare_fuzzy_path_costs(), there's a bigger problem here, which is that any fuzziness at all renders the comparison function non-transitive, which could confuse qsort() to the point of delivering completely wrong results. So forget the whole thing and just do an exact comparison.
* For psql multi-line history, save backslash commands right away, ratherBruce Momjian2006-06-07
| | | | than only if there is already history.
* Use INFO-level for reindex messages, rather than NOTICE.Bruce Momjian2006-06-07
| | | | Euler Taveira de Oliveira
* Update comment.Bruce Momjian2006-06-06
|
* On Win32, return original patch if GetShortPathName() fails (no shortBruce Momjian2006-06-06
| | | | | | name, path does not exist), rather than returning nothing. Backpatch to 8.1.X.
* Make the planner estimate costs for nestloop inner indexscans on the basisTom Lane2006-06-06
| | | | | | | | | | | | | | | | | | | | | that the Mackert-Lohmann formula applies across all the repetitions of the nestloop, not just each scan independently. We use the M-L formula to estimate the number of pages fetched from the index as well as from the table; that isn't what it was designed for, but it seems reasonably applicable anyway. This makes large numbers of repetitions look much cheaper than before, which accords with many reports we've received of overestimation of the cost of a nestloop. Also, change the index access cost model to charge random_page_cost per index leaf page touched, while explicitly not counting anything for access to metapage or upper tree pages. This may all need tweaking after we get some field experience, but in simple tests it seems to be giving saner results than before. The main thing is to get the infrastructure in place to let cost_index() and amcostestimate functions take repeated scans into account at all. Per my recent proposal. Note: this patch changes pg_proc.h, but I did not force initdb because the changes are basically cosmetic --- the system does not look into pg_proc to decide how to call an index amcostestimate function, and there's no way to call such a function from SQL at all.
* Remove ancient AIX structure workaround.Bruce Momjian2006-06-06
|
* Have BCC echo output "" using "", rather than \"\" as earlier reported.Bruce Momjian2006-06-06
| | | | Backpatch to 8.1.X.
* Fixed two more memory leaks in ecpglib.Michael Meskes2006-06-06
| | | | Synced parser.
* Remove extremely old, incomplete, broken example code.Tom Lane2006-06-05
| | | | Per my proposal a few days ago.
* While making the seq_page_cost changes, I was struck by the fact thatTom Lane2006-06-05
| | | | | | | | | | | | | cost_nonsequential_access() is really totally inappropriate for its only remaining use, namely estimating I/O costs in cost_sort(). The routine was designed on the assumption that disk caching might eliminate the need for some re-reads on a random basis, but there's nothing very random in that sense about sort's access pattern --- it'll always be picking up the oldest outputs. If we had a good fix on the effective cache size we might consider charging zero for I/O unless the sort temp file size exceeds it, but that's probably putting much too much faith in the parameter. Instead just drop the logic in favor of a fixed compromise between seq_page_cost and random_page_cost per page of sort I/O.
* Avoid longjump/vfork warning about line_saved_in_history variable byBruce Momjian2006-06-05
| | | | making it volatile.
* Have psql history save \e editor contents to history before query isBruce Momjian2006-06-05
| | | | executed, like it did for 8.1.X.
* Increase the default value of cpu_index_tuple_cost from 0.001 to 0.005.Tom Lane2006-06-05
| | | | | | This shouldn't affect simple indexscans much, while for bitmap scans that are touching a lot of index rows, this seems to bring the estimates more in line with reality. Per recent discussion.
* Add a GUC parameter seq_page_cost, and use that everywhere we formerlyTom Lane2006-06-05
| | | | | | | | assumed that a sequential page fetch has cost 1.0. This patch doesn't in itself change the system's behavior at all, but it opens the door to people adopting other units of measurement for EXPLAIN costs. Also, if we ever decide it's worth inventing per-tablespace access cost settings, this change provides a workable intellectual framework for that.
* Fix psql so \r is separate in the history, rather than at the end ofBruce Momjian2006-06-04
| | | | the query.
* Don't choke during startup if the environment offers an invalid valueTom Lane2006-06-03
| | | | | | | | | | for LC_MESSAGES; instead, just press forward, leaving the effective setting at 'C'. There is not any very good reason to complain when we are going to replace the value soon with whatever postgresql.conf says. This change should solve the occasionally-reported problem of initdb failing with 'failed to initialize lc_messages'; the current theory is that that is a reflection of either wrong LANG/LC_MESSAGES or completely broken locale support.
* Fix copy-and-pasteo in Russian translation: message complaining aboutTom Lane2006-06-03
| | | | | HAVE_INT64_TIMESTAMP was mentioning PG_CONTROL_VERSION instead. Victor Snezhko
* Remove pg_resetxlog -r flag, feature has problems referenced here:Bruce Momjian2006-06-03
| | | | http://archives.postgresql.org/pgsql-hackers/2006-05/msg00002.php
* Respond to Jeremy Drake's original gripe that \copy needs to recognizeTom Lane2006-06-01
| | | | E'...' syntax for strings in order to track the backend.
* Fix up hack to suppress escape_string_warning so that it actually worksTom Lane2006-06-01
| | | | | | and there's only one place that's a kluge, ie, appendStringLiteralConn. Note that pg_dump itself doesn't use appendStringLiteralConn, so its behavior is not affected; only the other utility programs care.
* Fix seriously broken patch for psql '' ... per its comment, emit() isTom Lane2006-05-31
| | | | NOT the thing to use here.
* Make PG_MODULE_MAGIC required in shared libraries that are loaded intoTom Lane2006-05-31
| | | | | the server. Per discussion, there seems no point in a waiting period before making this required.
* Support '' for literal ' in psql single-quote strings, documentation update.Bruce Momjian2006-05-31
|
* Escape processing patch:Bruce Momjian2006-05-31
| | | | | | | | | | o turns off escape_string_warning in pg_dumpall.c o optionally use E'' for \password (undocumented option?) o honor standard_conforming-strings for \copy (but not support literal E'' strings) o optionally use E'' for \d commands o turn off escape_string_warning for createdb, createuser, droplang
* Update cvs command example to show diff -rBASE.Bruce Momjian2006-05-31
|
* Somehow a ";" got lost which changed the logic. This btw is the first fix ↵Michael Meskes2006-05-31
| | | | resulting from SoC.
* Magic blocks don't do us any good unless we use 'em ... so install oneTom Lane2006-05-30
| | | | in every shared library.
* Code review for magic-block patch. Remove separate header file pgmagic.h,Tom Lane2006-05-30
| | | | | | | | | | as this seems only likely to create headaches for module developers. Put the macro in the pre-existing fmgr.h file instead. Avoid being too cute about how many fields we can cram into a word, and avoid trying to fetch from a library we've already unlinked. Along the way, it occurred to me that the magic block really ought to be 'const' so it can be stored in the program text area. Do the same for the existing data blocks for PG_FUNCTION_INFO_V1 functions.
* Code review for EXPLAIN patch. Fix some typos, make it behave sanelyTom Lane2006-05-30
| | | | | across multiple loops, get rid of the shaky assumption that exactly one tuple is returned per node iteration.
* PostmasterIsAlive test really ought to be in the inner loop for safety.Tom Lane2006-05-30
|
* Remove pqsignalinquire(), which is unused and has portability issues.Tom Lane2006-05-30
|
* Update ppport.h to not cause warnings with newest Perl versions.Tom Lane2006-05-30
| | | | | This is just the minimal necessary change; we might want to adopt later PPPort output instead.
* Add pgmagic header block to store compile-time constants:Bruce Momjian2006-05-30
| | | | | | | | | | | | | | | | | | | | | It now only checks four things: Major version number (7.4 or 8.1 for example) NAMEDATALEN FUNC_MAX_ARGS INDEX_MAX_KEYS The three constants were chosen because: 1. We document them in the config page in the docs 2. We mark them as changable in pg_config_manual.h 3. Changing any of these will break some of the more popular modules: FUNC_MAX_ARGS changes fmgr interface, every module uses this NAMEDATALEN changes syscache interface, every PL as well as tsearch uses this INDEX_MAX_KEYS breaks tsearch and anything using GiST. Martijn van Oosterhout
* Make EXPLAIN sampling smarter, to avoid excessive sampling delay.Bruce Momjian2006-05-30
| | | | Martijn van Oosterhout
* Clarify the HINT for 'checkpoint request failed', per recent complaintTom Lane2006-05-30
| | | | demonstrating that its intent wasn't obvious.
* Revert patch, needs more work:Bruce Momjian2006-05-30
| | | | | | | | | | | | | | --------------------------------------------------------------------------- Add dynamic record inspection to PL/PgSQL, useful for generic triggers: tval2 := r.(cname); or columns := r.(*); Titus von Boxberg
* Move conversion dependency patch to the proper branch, out of 8.1.X,Bruce Momjian2006-05-30
| | | | into HEAD.
* Prevent multiple archivers from starting. Backpatch to 8.1.X.Bruce Momjian2006-05-30
| | | | Simon Riggs
* Fix printf mask for SizeVfdCacheBruce Momjian2006-05-30
| | | | Qingqing Zhou