aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
...
* Fix choose_bitmap_and() so that partial index predicates are considered whenTom Lane2006-05-18
| | | | | | | | | | | deciding whether a potential additional indexscan is redundant or not. As now coded, any use of a partial index that was already used in a previous AND arm will be rejected as redundant. This might be overly restrictive, but not considering the point at all is definitely bad, as per example in bug #2441 from Arjen van der Meijden. In particular, a clauseless scan of a partial index was *never* considered redundant by the previous coding, and that's surely wrong. Being more flexible would also require some consideration of how not to double-count the index predicate's selectivity.
* When a bitmap indexscan is using a partial index, it is necessary to includeTom Lane2006-05-18
| | | | | | | the partial index predicate in the scan's "recheck condition". Otherwise, if the scan becomes lossy for lack of bitmap memory, we would fail to enforce that returned rows satisfy the predicate. Noted while studying bug #2441 from Arjen van der Meijden.
* Allow sparcv8plus to use "cas".Bruce Momjian2006-05-18
| | | | Theo Schlossnagle
* Code alignment fix.Bruce Momjian2006-05-18
|
* Fix thinko in recent changes to handle ScalarArrayOpExpr as an indexableTom Lane2006-05-18
| | | | | | | | | | | condition: when there are multiple possible index paths involving ScalarArrayOpExprs, they are logically to be ANDed together not ORed. This thinko was a direct consequence of trying to put the processing inside generate_bitmap_or_paths(), which I now see was a bit too cute. So pull it out and make the callers do it separately (there are only two that need it anyway). Partially responds to bug #2441 from Arjen van der Meijden. There are some additional infelicities exposed by his example, but they are also in 8.1.x, while this mistake is not.
* Remove canonicalize_path() call for .pgpass socket directory comparison;Bruce Momjian2006-05-18
| | | | not worth adding path.c to libpq.
* Mention that gcc/sparc generates sparcv7 binaries.Bruce Momjian2006-05-18
|
* Add more sparcv8plus comments.Bruce Momjian2006-05-18
|
* Add mention of -xarch=v8plus for "cas" usage on Solaris/sparc.Bruce Momjian2006-05-18
|
* Add simplified sparc8 ASM for solaris_sparc.s, from Alan Stange.Bruce Momjian2006-05-18
|
* Add comments that Solaris Sun compiler only supports sparc9 ASM,Bruce Momjian2006-05-17
|
* Change spaces to tabs, for consistency. (Caused by email cut/paste.)Bruce Momjian2006-05-17
|
* Allow the .pgpass hostname to match the default socket directory, asBruce Momjian2006-05-17
| | | | well as a blank pghost.
* Change catalog version due to WAL protocol changes in GiSTTeodor Sigaev2006-05-17
|
* Reduce size of critial section during vacuum full, criticalTeodor Sigaev2006-05-17
| | | | | | | | sections now isn't nested. All user-defined functions now is called outside critsections. Small improvements in WAL protocol. TODO: improve XLOG replay
* Rename macro parameter, for clarity.Bruce Momjian2006-05-17
|
* Fix the sense of the test on DH_check()'s return value. This was preventingTom Lane2006-05-12
| | | | | custom-generated DH parameters from actually being used by the server. Found by Michael Fuhr.
* Upon closer inspection, the sparc code in s_lock.c is dead code, andTom Lane2006-05-12
| | | | | | always has been, because it's not got any .globl declaration! We've been relying on the solaris_sparc.s code instead. Rip it out. (Not back-patched, since this is just cosmetic cleanup.)
* Fix typo in comment.Bruce Momjian2006-05-11
|
* Remove unnecessary .seg/.section directives, per Alan Stange.Tom Lane2006-05-11
|
* Use SQL standard '' rather than \' for tutorial/sample code.Bruce Momjian2006-05-11
| | | | Backpatch to 8.1.X.
* Code review for standard_conforming_strings patch. Fix it so it does notTom Lane2006-05-11
| | | | | | | throw warnings for 100%-SQL-standard constructs, clean up some minor infelicities, try to un-break ecpg to the best of my ability. (It's not clear how ecpg is going to find out the setting of standard_conforming_strings, though.) I think pg_dump still needs work, too.
* Clean up code associated with updating pg_class statistics columnsTom Lane2006-05-10
| | | | | | | | | | | (relpages/reltuples). To do this, create formal support in heapam.c for "overwrite" tuple updates (including xlog replay capability) and use that instead of the ad-hoc overwrites we'd been using in VACUUM and CREATE INDEX. Take the responsibility for updating stats during CREATE INDEX out of the individual index AMs, and do it where it belongs, in catalog/index.c. Aside from being more modular, this avoids having to update the same tuple twice in some paths through CREATE INDEX. It's probably not measurably faster, but for sure it's a lot cleaner than before.
* Reduce size of critical section and remove call of user-defined functions inTeodor Sigaev2006-05-10
| | | | | | insertion and deletion, modify gistSplit() to do not use buffers. TODO: gistvacuumcleanup and XLOG
* Build server libpgport with all non-FRONTEND object files. This is toBruce Momjian2006-05-08
| | | | | fix a Win32 bug where pipe.c included a file that used FRONTEND, but it wasn't on the server-build list.
* Rewrite btree vacuuming to fold the former bulkdelete and cleanup operationsTom Lane2006-05-08
| | | | | | | | | | | | | into a single mostly-physical-order scan of the index. This requires some ticklish interlocking considerations, but should create no material performance impact on normal index operations (at least given the already-committed changes to make scans work a page at a time). VACUUM itself should get significantly faster in any index that's degenerated to a very nonlinear page order. Also, we save one pass over the index entirely, except in the case where there were no deletions to do and so only one pass happened anyway. Original patch by Heikki Linnakangas, rework by Tom Lane.
* Rewrite btree index scans to work a page at a time in all cases (bothTom Lane2006-05-07
| | | | | | | | | | | | | | | | btgettuple and btgetmulti). This eliminates the problem of "re-finding" the exact stopping point, since the stopping point is effectively always a page boundary, and index items are never moved across pre-existing page boundaries. A small penalty is that the keys_are_unique optimization is effectively disabled (and, therefore, is removed in this patch), causing us to apply _bt_checkkeys() to at least one more tuple than necessary when looking up a unique key. However, the advantages for non-unique cases seem great enough to accept this tradeoff. Aside from simplifying and (sometimes) speeding up the indexscan code, this will allow us to reimplement btbulkdelete as a largely sequential scan instead of index-order traversal, thereby significantly reducing the cost of VACUUM. Those changes will come in a separate patch. Original patch by Heikki Linnakangas, rework by Tom Lane.
* Use $(LIBS:-lpgport=) rather than $(patsubst -lpgport,, $(LIBS)), for ↵Bruce Momjian2006-05-07
| | | | consistency.
* Further minor simplification of relcache startup: don't need a staticTom Lane2006-05-06
| | | | needNewCacheFile flag anymore, it can just be local in RelationCacheInitializePhase2.
* Add SSL CRL support to libpq. Recently added to the backend.Bruce Momjian2006-05-06
|
* Issue a log message if a CRL file exists and the SSL library does notBruce Momjian2006-05-06
| | | | support CRL certificates.
* Seems some NetBSD 3.0 x86 systems still need float8-small-is-zero, soBruce Momjian2006-05-05
| | | | patch reverted.
* On Solaris ASM, / '/' is the comment for x86, while '!' is the commentBruce Momjian2006-05-05
| | | | | | for Sparc Robert Lor
* Use regression results float8-small-is-zero only for NetBSD < 3.0.Bruce Momjian2006-05-05
| | | | | | Backpatch to 8.1.X. Simon Burge
* Change Solaris comments from / to !.Bruce Momjian2006-05-05
| | | | Robert Lor
* Don't try to compile SSL CRL support if local SSL installation hasn'tTom Lane2006-05-04
| | | | got it. Per buildfarm failure on 'canary'.
* Simplify relcache startup sequence. With the new design of InitPostgresTom Lane2006-05-04
| | | | | | | it's not necessary to have three separate calls anymore. This patch also fixes things so we don't try to read pg_internal.init until after we've obtained lock on the target database; which was fairly harmless, but it's certainly cleaner this way.
* Rethink the locking mechanisms used for CREATE/DROP/RENAME DATABASE.Tom Lane2006-05-04
| | | | | | | | | | | | | The former approach used ExclusiveLock on pg_database, which being a cluster-wide lock meant only one of these operations could proceed at a time; worse, it also blocked all incoming connections in ReverifyMyDatabase. Now that we have LockSharedObject(), we can use locks of different types applied to databases considered as objects. This allows much more flexible management of the interlocking: two CREATE DATABASEs need not block each other, and need not block connections except to the template database being used. Similarly DROP DATABASE doesn't block unrelated operations. The locking used in flatfiles.c is also much narrower in scope than before. Per recent proposal.
* Create a syscache for pg_database-indexed-by-oid, and make use of itTom Lane2006-05-03
| | | | | | | | | | in various places that were previously doing ad hoc pg_database searches. This may speed up database-related privilege checks a little bit, but the main motivation is to eliminate the performance reason for having ReverifyMyDatabase do such a lot of stuff (viz, avoiding repeat scans of pg_database during backend startup). The locking reason for having that routine is about to go away, and it'd be good to have the option to break it up.
* Fix typo noticed by Alvaro HerreraTeodor Sigaev2006-05-03
|
* Fix calculation of plan node extParams to account for the possibility that oneTom Lane2006-05-03
| | | | | | | | | | | | initPlan sets a parameter for another. This could not (I think) happen before 8.1, but it's possible now because the initPlans generated by MIN/MAX optimization might themselves use initPlans. We attach those initPlans as siblings of the MIN/MAX ones, not children, to avoid duplicate computation when multiple MIN/MAX aggregates are present; so this leads to the case of an initPlan needing the result of a sibling initPlan, which is not possible with ordinary query nesting. Hadn't been noticed because in most contexts having too much stuff listed in extParam is fairly harmless. Fixes "plan should not reference subplan's variable" bug reported by Catalin Pitis.
* Clean up API for ambulkdelete/amvacuumcleanup as per today's discussion.Tom Lane2006-05-02
| | | | | | This formulation requires every AM to provide amvacuumcleanup, unlike before, but it's surely a whole lot cleaner. Also, add an 'amstorage' column to pg_am so that we can get rid of hardwired knowledge in DefineOpClass().
* Suppress some gcc warnings.Tom Lane2006-05-02
|
* Fix grammar of new error message.Tom Lane2006-05-02
|
* Add GIN opclases for another typesTeodor Sigaev2006-05-02
|
* GIN: Generalized Inverted iNdex.Teodor Sigaev2006-05-02
| | | | text[], int4[], Tsearch2 support for GIN.
* Avoid assuming that statistics for a parent relation reflect the properties ofTom Lane2006-05-02
| | | | | | | | | | | | | the union of its child relations as well. This might have been a good idea when it was originally coded, but it's a fatally bad idea when inheritance is being used for partitioning. It's better to have no stats at all than completely misleading stats. Per report from Mark Liberman. The bug arguably exists all the way back, but I've only patched HEAD and 8.1 because we weren't particularly trying to support partitioning before 8.1. Eventually we ought to look at deriving union statistics instead of just punting, but for now the drop kick looks good.
* Provide a namespace.c function for lookup of an operator with exactTom Lane2006-05-01
| | | | | | | | input datatypes given, and use this before trying OpernameGetCandidates. This is faster than the old method when there's an exact match, and it does not seem materially slower when there's not. And it definitely makes some of the callers cleaner, because they didn't really want to know about a list of candidates anyway. Per discussion with Atsushi Ogawa.
* Code review for GRANT CONNECT patch. Spell the privilege as CONNECT notTom Lane2006-04-30
| | | | | CONNECTION, fix a number of places that were missed (eg pg_dump support), avoid executing an extra search of pg_database during startup.
* Improve the representation of FOR UPDATE/FOR SHARE so that we canTom Lane2006-04-30
| | | | | | support both FOR UPDATE and FOR SHARE in one command, as well as both NOWAIT and normal WAIT behavior. The more general code is actually simpler and cleaner.