aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* On further testing, PQping also needs an explicit check for AUTH_REQ.Tom Lane2010-11-27
| | | | | The pg_fe_sendauth code might fail if it can't handle the authentication request message type --- if so, ping should still say the server is up.
* Rewrite PQping to be more like what we agreed to last week.Tom Lane2010-11-27
| | | | | | | | | | | | | | | | | | | | | | | Basically, we want to distinguish all cases where the connection was not made from those where it was. A convenient proxy for this is to see if we got a message with a SQLSTATE code back from the postmaster. This presumes that the postmaster will always send us a SQLSTATE in a failure message, which is true for 7.4 and later postmasters in every case except fork failure. (We could possibly complicate the postmaster code to do something about that, but it seems not worth the trouble, especially since pg_ctl's response for that case should be to keep waiting anyway.) If we did get a SQLSTATE from the postmaster, there are basically only two cases, as per last week's discussion: ERRCODE_CANNOT_CONNECT_NOW and everything else. Any other error code implies that the postmaster is in principle willing to accept connections, it just didn't like or couldn't handle this particular request. We want to make a special case for ERRCODE_CANNOT_CONNECT_NOW so that "pg_ctl start -w" knows it should keep waiting. In passing, pick names for the enum constants that are a tad less likely to present collision hazards in future.
* Clean up IPv4 vs IPv6 bogosity in connectFailureMessage().Tom Lane2010-11-26
| | | | Newly added code was supposing that "struct sockaddr_in" applies to IPv6.
* Fix portability issues in new src/port/inet_net_ntop.c file.Tom Lane2010-11-26
| | | | | | | | | | 1. Don't #include postgres.h in a frontend build. 2. Don't assume that the backend's symbol PGSQL_AF_INET6 has anything to do with the constant that will be used by system library functions (because, in point of fact, it usually doesn't). Fortunately, PGSQL_AF_INET is equal to AF_INET, so we can just cater for both sets of values in one case construct without fear of conflict.
* Add more ALTER <object> .. SET SCHEMA commands.Robert Haas2010-11-26
| | | | | | | | This adds support for changing the schema of a conversion, operator, operator class, operator family, text search configuration, text search dictionary, text search parser, or text search template. Dimitri Fontaine, with assorted corrections and other kibitzing.
* Remove bogus use of PGDLLIMPORT.Tom Lane2010-11-26
| | | | | That macro should be attached to extern declarations, not actual definitions of variables.
* Add inet_net_ntop.c as needed by MSVC, per Magnus.Bruce Momjian2010-11-26
|
* Use conn->raddr consistently for non-connect libpq error reporting.Bruce Momjian2010-11-26
|
* Update comment that says we only report last libpq connection failure,Bruce Momjian2010-11-26
| | | | per Peter.
* Use only addr_cur when reporting connection failures in libpq.Bruce Momjian2010-11-26
|
* Abandon use of Makefile variables in libpq/Makefile because MSVC scrapesBruce Momjian2010-11-26
| | | | | | the OBJS lines from that file. Cleanup where possible.
* In libpq/Makefile, merge PERM_PGPORT and OPT_PGPORT into a singleBruce Momjian2010-11-26
| | | | Makefile variable PGPORT, for clarity.
* Improve pg_ctl "cannot connect" spacing, per Tom, and wording.Bruce Momjian2010-11-26
|
* Improve pg_ctl "cannot connect" warning, per suggestion from Magnus.Bruce Momjian2010-11-25
|
* For libpq/Makefile OPT_PGPORT, remove .o extension after we testBruce Momjian2010-11-25
| | | | configure's LIBOBJS. Should fix buildfarm failures.
* Add PQping and PQpingParams to libpq to allow detection of the server'sBruce Momjian2010-11-25
| | | | | | | | | status, including a status where the server is running but refuses a postgres connection. Have pg_ctl use this new function. This fixes the case where pg_ctl reports that the server is not running (cannot connect) but in fact it is running.
* Fix getaddrinfo() in pgport to use proper parameters, as detected byBruce Momjian2010-11-25
| | | | Win32 buildfarm members.
* Restructure how libpq includes external C files, for clarity.Bruce Momjian2010-11-25
|
* Object access hook framework, with post-creation hook.Robert Haas2010-11-25
| | | | | | | | | | After a SQL object is created, we provide an opportunity for security or logging plugins to get control; for example, a security label provider could use this to assign an initial security label to newly created objects. The basic infrastructure is (hopefully) reusable for other types of events that might require similar treatment. KaiGai Kohei, with minor adjustments.
* Add inet_net_ntop.c to .gitignore.Robert Haas2010-11-25
|
* Remove belt-and-suspenders guards against buffer pin leaks.Robert Haas2010-11-25
| | | | | | | | Forcibly releasing all leftover buffer pins should be unnecessary now that we have a robust ResourceOwner mechanism, and it significantly increases the cost of process shutdown. Instead, in an assert-enabled build, assert that no pins are held; in a non-assert-enabled build, do nothing.
* Properly add new inet_net_ntop file to libpq Makefile.Bruce Momjian2010-11-24
|
* When reporting the server as not responding, if the hostname wasBruce Momjian2010-11-24
| | | | | | | | | supplied, also print the IP address. This allows IPv4 and IPv6 failures to be distinguished. Also useful when a hostname resolves to multiple IP addresses. Also, remove use of inet_ntoa() and use our own inet_net_ntop() in all places, including in libpq, because it is thread-safe.
* Create the system catalog infrastructure needed for KNNGIST.Tom Lane2010-11-24
| | | | | | | | | | | | | | | | This commit adds columns amoppurpose and amopsortfamily to pg_amop, and column amcanorderbyop to pg_am. For the moment all the entries in amcanorderbyop are "false", since the underlying support isn't there yet. Also, extend the CREATE OPERATOR CLASS/ALTER OPERATOR FAMILY commands with [ FOR SEARCH | FOR ORDER BY sort_operator_family ] clauses to allow the new columns of pg_amop to be populated, and create pg_dump support for dumping that information. I also added some documentation, although it's perhaps a bit premature given that the feature doesn't do anything useful yet. Teodor Sigaev, Robert Haas, Tom Lane
* Propagate ALTER TYPE operations to typed tablesPeter Eisentraut2010-11-23
| | | | | This adds RESTRICT/CASCADE flags to ALTER TYPE ... ADD/DROP/ALTER/ RENAME ATTRIBUTE to control whether to alter typed tables as well.
* Remove useless whitespace at end of linesPeter Eisentraut2010-11-23
|
* Centralize some ALTER <whatever> .. SET SCHEMA checks.Robert Haas2010-11-22
| | | | | | | | Any flavor of ALTER <whatever> .. SET SCHEMA fails if (1) the object is already in the new schema, (2) either the old or new schema is a temp schema, or (3) either the old or new schema is the TOAST schema. Extraced from a patch by Dimitri Fontaine, with additional hacking by me.
* Remove GucContext parameter from ParseConfigFileAlvaro Herrera2010-11-22
|
* Put back accidentally-deleted quote_literal() regression tests.Robert Haas2010-11-21
|
* Bump catversion. Should have done this as part of format(text) patch.Robert Haas2010-11-21
|
* Add new SQL function, format(text).Robert Haas2010-11-20
| | | | | | | | | | | Currently, three conversion format specifiers are supported: %s for a string, %L for an SQL literal, and %I for an SQL identifier. The latter two are deliberately designed not to overlap with what sprintf() already supports, in case we want to add more of sprintf()'s functionality here later. Patch by Pavel Stehule, heavily revised by me. Reviewed by Jeff Janes and, in earlier versions, by Itagaki Takahiro and Tom Lane.
* Further cleanup of indxpath logic related to IndexOptInfo.opfamily array.Tom Lane2010-11-20
| | | | | | | We no longer need the terminating zero entry in opfamily[], so get rid of it. Also replace assorted ad-hoc looping logic with simple for and foreach constructs. This code is now noticeably more readable than it was an hour ago; credit to Robert for seeing that it could be simplified.
* Minor cleanup of indxpath.c.Robert Haas2010-11-20
| | | | | | Eliminate some superfluous notational complexity around match_clause_to_indexcol(), and rip out the DoneMatchingIndexKeys crock.
* Assorted further cleanup for integer-conversion patch.Tom Lane2010-11-20
| | | | | | | | Avoid depending on LL notation, which is likely to not work in pre-C99 compilers; don't pointlessly use INT32_MIN/INT64_MIN in code that has the numerical value hard-wired into it anyway; remove some gratuitous style inconsistencies between pg_ltoa and pg_lltoa; fix int2 test case so it actually tests int2.
* Expose quote_literal_cstr() from core.Robert Haas2010-11-20
| | | | | | | | | This eliminates the need for inefficient implementions of this functionality in both contrib/dblink and contrib/tablefunc, so remove them. The upcoming patch implementing an in-core format() function will also require this functionality. In passing, add some regression tests.
* Update int8-exp-three-digits.out to match new contents of int8.out.Robert Haas2010-11-20
|
* Attempt to fix breakage caused by signed integer conversion patch.Robert Haas2010-11-20
| | | | | | | Use INT_MIN rather than INT32_MIN as we do elsewhere in the code, and try to work around nonexistence of INT64_MIN if necessary. Adjust the new regression tests to something hopefully saner, per observation by Tom Lane.
* Fix leakage of cost_limit when multiple autovacuum workers are active.Tom Lane2010-11-19
| | | | | | | | | | | | | | | | When using default autovacuum_vac_cost_limit, autovac_balance_cost relied on VacuumCostLimit to contain the correct global value ... but after the first time through in a particular worker process, it didn't, because we'd trashed it in previous iterations. Depending on the state of other autovac workers, this could result in a steady reduction of the effective cost_limit setting as a particular worker processed more and more tables, causing it to go slower and slower. Spotted by Simon Poole (bug #5759). Fix by saving and restoring the GUC variables in the loop in do_autovacuum. In passing, improve a few comments. Back-patch to 8.3 ... the cost rebalancing code has been buggy since it was put in.
* Speed up conversion of signed integers to C strings.Robert Haas2010-11-19
| | | | | | | A hand-coded implementation turns out to be much faster than calling printf(). In passing, add a few more regresion tests. Andres Freund, with assorted, mostly cosmetic changes.
* Improve relation width estimation for subqueries.Tom Lane2010-11-19
| | | | | | | | | | | | | | | | | As per the ancient comment for set_rel_width, it really wasn't much good for relations that aren't plain tables: it would never find any stats and would always fall back on datatype-based estimates, which are often pretty silly. Fix that by copying up width estimates from the subquery planning process. At some point we might want to do this for CTEs too, but that would be a significantly more invasive patch because the sub-PlannerInfo is no longer accessible by the time it's needed. I refrained from doing anything about that, partly for fear of breaking the unmerged CTE-related patches. In passing, also generate less bogus width estimates for whole-row Vars. Per a gripe from Jon Nelson.
* Improve plpgsql's error reporting for no-such-column cases.Tom Lane2010-11-18
| | | | | | | | | | | | | Given a column reference foo.bar, where there is a composite plpgsql variable foo but it doesn't contain a column bar, the pre-9.0 coding would immediately throw a "record foo has no field bar" error. In 9.0 the parser hook instead falls through to let the core parser see if it can resolve the reference. If not, you get a complaint about "missing FROM-clause entry for table foo", which while in some sense correct isn't terribly helpful. Complicate things a bit so that we can throw the old error message if neither the core parser nor the hook are able to resolve the column reference, while not changing the behavior in any other case. Per bug #5757 from Andrey Galkin.
* Add pg_describe_object functionAlvaro Herrera2010-11-18
| | | | | This function is useful to obtain textual descriptions of objects as stored in pg_depend.
* Dept of second thoughts: don't try to push LIMIT below a SRF.Tom Lane2010-11-18
| | | | | | | | If we have Limit->Result->Sort, the Result might be projecting a tlist that contains a set-returning function. If so, it's possible for the SRF to sometimes return zero rows, which means we could need to fetch more than N rows from the Sort in order to satisfy LIMIT N. So top-N sorting cannot be used in this scenario.
* Remove unused parameter. Patch by Shigeru Hanada.Heikki Linnakangas2010-11-18
|
* Further fallout from the MergeAppend patch.Tom Lane2010-11-18
| | | | | | | | | | | | | | Fix things so that top-N sorting can be used in child Sort nodes of a MergeAppend node, when there is a LIMIT and no intervening joins or grouping. Actually doing this on the executor side isn't too bad, but it's a bit messier to get the planner to cost it properly. Per gripe from Robert Haas. In passing, fix an oversight in the original top-N-sorting patch: query_planner should not assume that a LIMIT can be used to make an explicit sort cheaper when there will be grouping or aggregation in between. Possibly this should be back-patched, but I'm not sure the mistake is serious enough to be a real problem in practice.
* Make TRUNCATE ... RESTART IDENTITY restart sequences transactionally.Tom Lane2010-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the previous coding, we simply issued ALTER SEQUENCE RESTART commands, which do not roll back on error. This meant that an error between truncating and committing left the sequences out of sync with the table contents, with potentially bad consequences as were noted in a Warning on the TRUNCATE man page. To fix, create a new storage file (relfilenode) for a sequence that is to be reset due to RESTART IDENTITY. If the transaction aborts, we'll automatically revert to the old storage file. This acts just like a rewriting ALTER TABLE operation. A penalty is that we have to take exclusive lock on the sequence, but since we've already got exclusive lock on its owning table, that seems unlikely to be much of a problem. The interaction of this with usual nontransactional behaviors of sequence operations is a bit weird, but it's hard to see what would be completely consistent. Our choice is to discard cached-but-unissued sequence values both when the RESTART is executed, and at rollback if any; but to not touch the currval() state either time. In passing, move the sequence reset operations to happen before not after any AFTER TRUNCATE triggers are fired. The previous ordering was not logically sensible, but was forced by the need to minimize inconsistency if the triggers caused an error. Transactional rollback is a much better solution to that. Patch by Steve Singer, rather heavily adjusted by me.
* Additional fixes for parallel makePeter Eisentraut2010-11-17
| | | | | | | | | Add some additional dependencies to constrain the build order to prevent parallel make from failing. In the case of src/Makefile, this is likely to be too complicated to be worth maintaining, so just add .NOTPARALLEL to get the old for-loop-like behavior. More fine-tuning might be necessary for some platforms or configurations.
* Require VALUE keyword when extending an enum type. Based on a patch from ↵Andrew Dunstan2010-11-16
| | | | Alvaro Herrera.
* Send paramHandle to subprocesses as 64-bit on Win64Magnus Hagander2010-11-16
| | | | | | | | | | | The handle to the shared memory segment containing startup parameters was sent as 32-bit even on 64-bit systems. Since HANDLEs appear to be allocated sequentially this shouldn't be a problem until we reach 2^32 open handles in the postmaster, but a 64-bit value should be sent across as 64-bit, and not zero out the top 32 bits. Noted by Tom Lane.
* The GiST scan algorithm uses LSNs to detect concurrent pages splits, butHeikki Linnakangas2010-11-16
| | | | | | | | | | | | | temporary indexes are not WAL-logged. We used a constant LSN for temporary indexes, on the assumption that we don't need to worry about concurrent page splits in temporary indexes because they're only visible to the current session. But that assumption is wrong, it's possible to insert rows and split pages in the same session, while a scan is in progress. For example, by opening a cursor and fetching some rows, and INSERTing new rows before fetching some more. Fix by generating fake increasing LSNs, used in place of real LSNs in temporary GiST indexes.
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-15 09:41:22 +0000