aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Prevent integer overflow within the integer-datetimes version ofTom Lane2008-01-23
| | | | | | | | TimestampTzPlusMilliseconds. An integer argument of more than INT_MAX/1000 milliseconds (ie, about 35 minutes) would provoke a wrong result, resulting in incorrect enforcement of statement_timestamp values larger than that. Bug was introduced in my rewrite of 2006-06-20, which fixed some other overflow risks, but missed this one :-( Per report from Elein.
* Improve lock level choices in pg_shdepend.c. Noticed by Tom Lane.Alvaro Herrera2008-01-23
|
* Document the fix for perl 5.10 with this comment:Andrew Dunstan2008-01-23
| | | | | | | * The temporary enabling of the caller opcode here is to work around a * bug in perl 5.10, which unkindly changed the way its Safe.pm works, without * notice. It is quite safe, as caller is informational only, and in any case * we only enable it while we load the 'strict' module.
* Work around for perl 5.10 bug - fix due to perl hacker Simon Cozens.Andrew Dunstan2008-01-22
|
* Provide a clearer error message if the pg_control version number looksPeter Eisentraut2008-01-21
| | | | wrong because of mismatched byte ordering.
* Fix RS_isRegis() to agree exactly with RS_compile()'s idea of what's a validTom Lane2008-01-21
| | | | | | | regis. Correct the latter's oversight that a bracket-expression needs to be terminated. Reduce the ereports to elogs, since they are now not expected to ever be hit (thus addressing Alvaro's original complaint). In passing, const-ify the string argument to RS_compile.
* Fix psql \h output for case of no parameters (ie, list all the known commands)Tom Lane2008-01-20
| | | | | | | to format properly for the actually needed column width, instead of having a hard-wired assumption about the longest command name length. Also make it respond to the current screen width. In passing, const-ify the constant table.
* Split error message.Alvaro Herrera2008-01-20
|
* Make pg_regress clean out the testtablespace directory only on Windows.Tom Lane2008-01-19
| | | | | | | | On other platforms it's better to let the Makefile handle it, but we want the regression tests to be invokable without make on Windows. A batch file would be a better solution, but no time for that before 8.3. Per my discovery that this breaks testing under SELinux, and subsequent discussion.
* Stamp release for 8.3RC2; configure will be stamped by packager.Bruce Momjian2008-01-18
|
* Insert into getCopyDataMessage() the same logic that already existed in theTom Lane2008-01-17
| | | | | | | | | | | | main code path for enlarging libpq's input buffer in one swoop when needing to read a long data message. Without this, the code will double the buffer size, read more data, notice it still hasn't got the whole message, and repeat till it finally has a large enough buffer. Which wastes a lot of data-moving effort and also memory (since malloc probably can't do anything very useful with the freed-up smaller buffers). Not sure why this wasn't there already; certainly the COPY data path is a place where we're quite likely to see long data messages. I'm not backpatching though, since this is just a marginal performance issue rather than a real bug.
* Fix subselect.c to avoid assuming that a SubLink's testexpr references eachTom Lane2008-01-17
| | | | | | | | | | subquery output column exactly once left-to-right. Although this is the case in the original parser output, it might not be so after rewriting and constant-folding, as illustrated by bug #3882 from Jan Mate. Instead scan the subquery's target list to obtain needed per-column information; this is duplicative of what the parser did, but only a couple dozen lines need be copied, and we can clean up a couple of notational uglinesses. Bug was introduced in 8.2 as part of revision of SubLink representation.
* Fix ALTER INDEX RENAME so that if the index belongs to a unique or primary keyTom Lane2008-01-17
| | | | | | | | constraint, the constraint is renamed as well. This avoids inconsistent situations that could confuse pg_dump (not to mention humans). We might at some point provide ALTER TABLE RENAME CONSTRAINT as a more general solution, but there seems no reason not to allow doing it this way too. Per bug #3854 and related discussions.
* Improve usage message for pgindent.Bruce Momjian2008-01-16
|
* Fix core dump with buffer-overrun by too long infinitive. Add checking of usingTeodor Sigaev2008-01-16
| | | | | fixed length arrays to prevent array's overrun. Per report by Hannes Dorbath <light@theendofthetunnel.de> and comments by Tom.
* Be less wishy-washy in the documentation and comments about whether aTom Lane2008-01-15
| | | | | | ParameterStatus message can be sent during COPY OUT: it's definitely possible, since COPY from a SELECT subquery can trigger any user-defined function.
* Prevent CLUSTER from decreasing a relation's relfrozenxid. BugTom Lane2008-01-15
| | | | introduced in rewrite to make CLUSTER MVCC-safe.
* Revise memory management for libxml calls. Instead of keeping libxml's dataTom Lane2008-01-15
| | | | | | | | | | | in whichever context happens to be current during a call of an xml.c function, use a dedicated context that will not go away until we explicitly delete it (which we do at transaction end or subtransaction abort). This makes recovery after an error much simpler --- we don't have to individually delete the data structures created by libxml. Also, we need to initialize and cleanup libxml only once per transaction (if there's no error) instead of once per function call, so it should be a bit faster. We'll need to keep an eye out for intra-transaction memory leaks, though. Alvaro and Tom.
* Tweak new error message to conform to style guidelines.Tom Lane2008-01-15
|
* Add check of headline method presence. Per report by Yoshiyuki Asaba ↵Teodor Sigaev2008-01-15
| | | | <y-asaba@sraoss.co.jp>
* Re-enabled variables in fetch/move command.Michael Meskes2008-01-15
|
* Somebody forgot to add this ERRCODE everywhere it should go ...Tom Lane2008-01-15
|
* Prevent pg_dump from dumping the comment (if any) on the 'public' schema.Tom Lane2008-01-14
| | | | | | This is to avoid uselessly requiring superuser permissions to restore the dump without errors. Pretty grotty, but no better alternative seems available, at least not in the near term.
* Avoid cluttering the postmaster log with bogus complaintsTom Lane2008-01-14
| | | | during transaction abort, per my note from a couple days ago.
* Fix an ancient oversight in libpq's handling of V3-protocol COPY OUT mode:Tom Lane2008-01-14
| | | | | | | we need to be able to swallow NOTICE messages, and potentially also ParameterStatus messages (although the latter would be a bit weird), without exiting COPY OUT state. Fix it, and adjust the protocol documentation to emphasize the need for this. Per off-list report from Alexander Galler.
* Mark autovacuum entries in pg_stat_activity so that they can be easilyAlvaro Herrera2008-01-14
| | | | distinguished from user-invoked commands. Per suggestion from Tom Lane.
* Set valid return values even in case of an error to prevent segfaults.Michael Meskes2008-01-14
|
* Fix CREATE INDEX CONCURRENTLY so that it won't use synchronized scan forTom Lane2008-01-14
| | | | | | | | its second pass over the table. It has to start at block zero, else the "merge join" logic for detecting which TIDs are already in the index doesn't work. Hence, extend heapam.c's API so that callers can enable or disable syncscan. (I put in an option to disable buffer access strategy, too, just in case somebody needs it.) Per report from Hannes Dorbath.
* Fix a regression test that fails if default_text_search_config isn'tTom Lane2008-01-13
| | | | 'english'.
* Changed prototype for ECPGdo because some compilers don't like int/enum ↵Michael Meskes2008-01-13
| | | | aliasing in there.
* It turns out the LIBXML_TEST_VERSION macro calls xmlInitParser().Tom Lane2008-01-12
| | | | | | | Therefore we must xmlCleanupParser(), or we risk leaving behind dangling pointers to whatever memory context is current when xml_init() is called. This seems to fix bug #3860, though we might still want the more invasive solution being worked on by Alvaro.
* Fix two places in xml.c that neglected to check the return values ofNeil Conway2008-01-12
| | | | SPI_prepare() and SPI_cursor_open(), to silence a Coverity warning.
* Minor perf tweak for _SPI_strdup(): if we're going to call strlen()Neil Conway2008-01-12
| | | | anyway, it is faster to memcpy() than to strcpy().
* Fix logical errors in constraint exclusion: we cannot assume that a CHECKTom Lane2008-01-12
| | | | | | | | | | | | | | | constraint yields TRUE for every row of its table, only that it does not yield FALSE (a NULL result isn't disallowed). This breaks a couple of implications that would be true in two-valued logic. I had put in one such mistake in an 8.2.5 patch: foo IS NULL doesn't refute a strict operator on foo. But there was another in the original 8.2 release: NOT foo doesn't refute an expression whose truth would imply the truth of foo. Per report from Rajesh Kumar Mallah. To preserve the ability to do constraint exclusion with one partition holding NULL values, extend relation_excluded_by_constraints() to check for attnotnull flags, and add col IS NOT NULL expressions to the set of constraints we hope to refute.
* The original implementation of polymorphic aggregates didn't really get theTom Lane2008-01-11
| | | | | | checking of argument compatibility right; although the problem is only exposed with multiple-input aggregates in which some arguments are polymorphic and some are not. Per bug #3852 from Sokolov Yura.
* Fix an old error in clause_selectivity: the default selectivity estimateTom Lane2008-01-11
| | | | | | | | | | | | | for unhandled clause types ought to be 0.5, not 1.0. I fear I introduced this silliness due to misreading the intent of the very-poorly-structured code that was there when we inherited the file from Berkeley. The lack of sanity in this behavior was exposed by an example from Sim Zacks. (Arguably this is a bug fix and should be back-patched, but I'm a bit hesitant to introduce a possible planner behavior change in the back branches; it might detune queries that worked acceptably in the past.) While at it, make estimation for DistinctExpr do something marginally realistic, rather than just defaulting.
* Fixed lexer to correctly parse C quotes.Michael Meskes2008-01-11
|
* Fix a conceptual error in my patch of 2007-10-26 that avoided consideringTom Lane2008-01-11
| | | | | | | | | | | | clauseless joins of relations that have unexploited join clauses. Rather than looking at every other base relation in the query, the correct thing is to examine the other relations in the "initial_rels" list of the current make_rel_from_joinlist() invocation, because those are what we actually have the ability to join against. This might be a subset of the whole query in cases where join_collapse_limit or from_collapse_limit or full joins have prevented merging the whole query into a single join problem. This is a bit untidy because we have to pass those rels down through a new PlannerInfo field, but it's necessary. Per bug #3865 from Oleg Kharin.
* Restructure the shutdown procedure for the archiver process to allow it toTom Lane2008-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | finish archiving everything (when there's no error), and to eliminate various hazards as best we can. This fixes a previous 8.3 patch that caused the postmaster to kill and then restart the archiver during shutdown (!?). The new behavior is that the archiver is allowed to run unmolested until the bgwriter has exited; then it is sent SIGUSR2 to tell it to do a final archiving cycle and quit. We only SIGQUIT the archiver if we want a panic stop; this is important since SIGQUIT will also be sent to any active archive_command. The postmaster also now doesn't SIGQUIT the stats collector until the bgwriter is done, since the bgwriter can send stats messages in 8.3. The postmaster will not exit until both the archiver and stats collector are gone; this provides some defense (not too bulletproof) against conflicting archiver or stats collector processes being started by a new postmaster instance. We continue the prior practice that the archiver will check for postmaster death immediately before issuing any archive_command; that gives some additional protection against conflicting archivers. Also, modify the archiver process to notice SIGTERM and refuse to issue any more archive commands if it gets it. The postmaster doesn't ever send it SIGTERM; we assume that any such signal came from init and is a notice of impending whole-system shutdown. In this situation it seems imprudent to try to start new archive commands --- if they aren't extremely quick they're likely to get SIGKILL'd by init. All per discussion.
* Generate and include manifest in standalone libpq build on Windows.Magnus Hagander2008-01-10
| | | | Hiroshi Saito
* vacuum_cost_limit has a minimum value of 1, not zero; updateBruce Momjian2008-01-10
| | | | postgresql.conf comment to match.
* Remove incorrect (and ill-advised anyway) pfree's in pg_convert_from andTom Lane2008-01-09
| | | | pg_convert_to. Per bug #3866 from Andrew Gilligan.
* Fix CREATE INDEX CONCURRENTLY to not deadlock against an automatic or manualTom Lane2008-01-09
| | | | | VACUUM that is blocked waiting to get lock on the table being indexed. Per report and fix suggestion from Greg Stark.
* Fix some planner issues found while investigating Kevin Grittner's reportTom Lane2008-01-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of poorer planning in 8.3 than 8.2: 1. After pushing a constant across an outer join --- ie, given "a LEFT JOIN b ON (a.x = b.y) WHERE a.x = 42", we can deduce that b.y is sort of equal to 42, in the sense that we needn't fetch any b rows where it isn't 42 --- loop to see if any additional deductions can be made. Previous releases did that by recursing, but I had mistakenly thought that this was no longer necessary given the EquivalenceClass machinery. 2. Allow pushing constants across outer join conditions even if the condition is outerjoin_delayed due to a lower outer join. This is safe as long as the condition is strict and we re-test it at the upper join. 3. Keep the outer-join clause even if we successfully push a constant across it. This is *necessary* in the outerjoin_delayed case, but even in the simple case, it seems better to do this to ensure that the join search order heuristics will consider the join as reasonable to make. Mark such a clause as having selectivity 1.0, though, since it's not going to eliminate very many rows after application of the constant condition. 4. Tweak have_relevant_eclass_joinclause to report that two relations are joinable when they have vars that are equated to the same constant. We won't actually generate any joinclause from such an EquivalenceClass, but again it seems that in such a case it's a good idea to consider the join as worth costing out. 5. Fix a bug in select_mergejoin_clauses that was exposed by these changes: we have to reject candidate mergejoin clauses if either side was equated to a constant, because we can't construct a canonical pathkey list for such a clause. This is an implementation restriction that might be worth fixing someday, but it doesn't seem critical to get it done for 8.3.
* Don't enforce 32-bit time_t for FRONTEND apps. Fixes standaloneMagnus Hagander2008-01-09
| | | | builds of libpq in both 32 and 64-bit. Per gripe from Hiroshi Saito.
* Fix an omission in the outfuncs.c support for Agg nodes: the grpColIdxNeil Conway2008-01-09
| | | | and grpOperators fields were not emitted by _outAgg().
* lmgr.c:DescribeLockTag was never taught about virtual xids, per Greg Stark.Tom Lane2008-01-08
| | | | | Also a couple of minor tweaks to try to future-proof the code a bit better against future locktag additions.
* informix.c was violating the coding rule about not including anyTom Lane2008-01-08
| | | | system headers before c.h. Per report from J6M.
* Remove unnecessary comma in enum definition ... some C compilers don'tTom Lane2008-01-08
| | | | like that. Per report from J6M.
* Mention use of src/tools/major_release_split for creating back-branchBruce Momjian2008-01-07
| | | | release notes.
generated by cgit v1.2.3 (git 2.25.1) at 2025-07-14 16:48:18 +0000