aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* Make sure pg_control is opened in binary mode, to dealMagnus Hagander2008-09-24
| | | | | | | with situtations when the file contains an EOF maker (0x1A) on Windows. ITAGAKI Takahiro
* Only show source file and line numbers to superusers, for consistentMagnus Hagander2008-09-23
| | | | | | security level with other parts of the system. Per gripe from Tom
* Add comment about the use of EXEC_BACKEND.Bruce Momjian2008-09-23
|
* Tighten the check in initdb and CREATE DATABASE that the chosen encodingHeikki Linnakangas2008-09-23
| | | | | matches the encoding of the locale. LC_COLLATE is now checked in addition to LC_CTYPE.
* Make LC_COLLATE and LC_CTYPE database-level settings. Collation andHeikki Linnakangas2008-09-23
| | | | | | | | ctype are now more like encoding, stored in new datcollate and datctype columns in pg_database. This is a stripped-down version of Radek Strnad's patch, with further changes by me.
* Get rid of pgpass_from_client tracking inside libpq --- given the conclusionTom Lane2008-09-22
| | | | | | | that presence of the password in the conninfo string must be checked *before* risking a connection attempt, there is no point in checking it afterwards. This makes the specification of PQconnectionUsedPassword() a bit simpler and perhaps more generally useful, too.
* Fix dblink_connect() so that it verifies that a password is supplied in theTom Lane2008-09-22
| | | | | | | | | | | | conninfo string *before* trying to connect to the remote server, not after. As pointed out by Marko Kreen, in certain not-very-plausible situations this could result in sending a password from the postgres user's .pgpass file, or other places that non-superusers shouldn't have access to, to an untrustworthy remote server. The cleanest fix seems to be to expose libpq's conninfo-string-parsing code so that dblink can check for a password option without duplicating the parsing logic. Joe Conway, with a little cleanup by Tom Lane
* Simplify the definitions of a couple of system views by using SELECT *Tom Lane2008-09-21
| | | | | | | | instead of listing all the columns returned by the underlying function. initdb not forced since this patch doesn't actually change anything about the stored form of the views. It just means there's one less place to change if someone wants to add columns to them.
* Add a PQfireResultCreateEvents function to allow applications to mimic theTom Lane2008-09-19
| | | | | | sequence of operations that libpq goes through while creating a PGresult. Also, remove ill-considered "const" decoration on parameters passed to event procedures.
* Create a selectivity estimation function for the text search @@ operator.Tom Lane2008-09-19
| | | | Jan Urbanski
* Improve the recently-added libpq events code to provide more consistentTom Lane2008-09-19
| | | | | | | | guarantees about whether event procedures will receive DESTROY events. They no longer need to defend themselves against getting a DESTROY without a successful prior CREATE. Andrew Chernow
* Mark SessionReplicationRole as PGDLLIMPORT so itMagnus Hagander2008-09-19
| | | | | | can be used from Slony functions. Per report from Hiroshi Saito.
* Add additional rules so that make init-po for ecpg gets up to date flex andPeter Eisentraut2008-09-19
| | | | | | | | bison output. Without these, make can sometimes be tempted to invoke its built-in rules using lex and yacc, which can fail if those commands are not available. This was a main cause for the NLS web site breakage.
* Optimize CleanupTempFiles by having a boolean flag that keeps track of whetherAlvaro Herrera2008-09-19
| | | | | | | | there are FD_XACT_TEMPORARY files to clean up at transaction end. Per performance profiling results on AWeber's huge systems. Patch by me after an idea suggested by Simon Riggs.
* Update time zone data files to tzdata release 2008f (DST law changes inTom Lane2008-09-17
| | | | Argentina, Bahamas, Brazil, Mauritius, Morocco, Pakistan, Palestine, Paraguay).
* Allow ShowBufferUsage() to report the number of reads/writes that haveTom Lane2008-09-17
| | | | | | | occurred to temporary files. This replaces the unused NDirectFileRead/NDirectFileWrite counters. Itagaki Takahiro
* Add an "events" system to libpq, whereby applications can get callbacks thatTom Lane2008-09-17
| | | | | | enable them to manage private data associated with PGconns and PGresults. Andrew Chernow and Merlin Moncure
* Clean up a couple of weird corner cases in interval parsing: make -yyyy-mm beTom Lane2008-09-16
| | | | | | | | | interpreted as expected (the sign should affect months too), and get rid of hard-wired assumption that unmarked signed values must be hours (if integers) or seconds (if floats). The former was just a bug in my previous patch, while the latter may have made sense at one time but seems illogical now that we support determination of the units from typmod information. Ron Mayer and myself.
* Widen the nLocks counts in local lock tables from int to int64. ThisTom Lane2008-09-16
| | | | | | | | | | | | | forestalls potential overflow when the same table (or other object, but usually tables) is accessed by very many successive queries within a single transaction. Per report from Michael Milligan. Back-patch to 8.0, which is as far back as the patch conveniently applies. There have been no reports of overflow in pre-8.3 releases, but clearly the risk existed all along. (Michael's report suggests that 8.3 may consume lock counts faster than prior releases, but with no test case to look at it's hard to be sure about that. Widening the counts seems a good future-proofing measure in any event.)
* Fix multiple memory leaks in xml_out(). Per report from Matt Magoffin.Tom Lane2008-09-16
|
* Fix caching of foreign-key-checking queries so that when a replan is needed,Tom Lane2008-09-15
| | | | | | | | we regenerate the SQL query text not merely the plan derived from it. This is needed to handle contingencies such as renaming of a table or column used in an FK. Pre-8.3, such cases worked despite the lack of replanning (because the cached plan needn't actually change), so this is a regression. Per bug #4417 from Benjamin Bihler.
* Fix error messages from recent pg_hba parsing patch to use errcontext()Magnus Hagander2008-09-15
| | | | to indicate where the error occurred.
* Change hash indexes to store only the hash code rather than the whole indexedTom Lane2008-09-15
| | | | | | | | | | | | | | | | value. This means that hash index lookups are always lossy and have to be rechecked when the heap is visited; however, the gain in index compactness outweighs this when the indexed values are wide. Also, we only need to perform datatype comparisons when the hash codes match exactly, rather than for every entry in the hash bucket; so it could also win for datatypes that have expensive comparison functions. A small additional win is gained by keeping hash index pages sorted by hash code and using binary search to reduce the number of index tuples we have to look at. Xiao Meng This commit also incorporates Zdenek Kotala's patch to isolate hash metapages and hash bitmaps a bit better from the page header datastructures.
* Parse pg_hba.conf in postmaster, instead of once in each backend forMagnus Hagander2008-09-15
| | | | | | | | | each connection. This makes it possible to catch errors in the pg_hba file when it's being reloaded, instead of silently reloading a broken file and failing only when a user tries to connect. This patch also makes the "sameuser" argument to ident authentication optional.
* Avoid compiler warning about variable used before assigned.Peter Eisentraut2008-09-15
|
* Skip opfamily check in eclass_matches_any_index() when the index isn't aTom Lane2008-09-12
| | | | | | | | | btree. We can't easily tell whether clauses generated from the equivalence class could be used with such an index, so just assume that they might be. This bit of over-optimization prevented use of non-btree indexes for nestloop inner indexscans, in any case where the join uses an equality operator that is also a btree operator --- which in particular is typically true for hash indexes. Noted while trying to test the current hash index patch.
* Tighten up to_date/to_timestamp so that they are more likely to rejectTom Lane2008-09-11
| | | | | | | erroneous input, rather than silently producing bizarre results as formerly happened. Brendan Jurd
* Adjust the parser to accept the typename syntax INTERVAL ... SECOND(n)Tom Lane2008-09-11
| | | | | | | | | | | | | | | | | | | and the literal syntax INTERVAL 'string' ... SECOND(n), as required by the SQL standard. Our old syntax put (n) directly after INTERVAL, which was a mistake, but will still be accepted for backward compatibility as well as symmetry with the TIMESTAMP cases. Change intervaltypmodout to show it in the spec's way, too. (This could potentially affect clients, if there are any that analyze the typmod of an INTERVAL in any detail.) Also fix interval input to handle 'min:sec.frac' properly; I had overlooked this case in my previous patch. Document the use of the interval fields qualifier, which up to now we had never mentioned in the docs. (I think the omission was intentional because it didn't work per spec; but it does now, or at least close enough to be credible.)
* Initialize the minimum frozen Xid in vac_update_datfrozenxid usingAlvaro Herrera2008-09-11
| | | | | | | | | | | | | | | | | | | | GetOldestXmin() instead of RecentGlobalXmin; this is safer because we do not depend on the latter being correctly set elsewhere, and while it is more expensive, this code path is not performance-critical. This is a real risk for autovacuum, because it can execute whole cycles without doing a single vacuum, which would mean that RecentGlobalXmin would stay at its initialization value, FirstNormalTransactionId, causing a bogus value to be inserted in pg_database. This bug could explain some recent reports of failure to truncate pg_clog. At the same time, change the initialization of RecentGlobalXmin to InvalidTransactionId, and ensure that it's set to something else whenever it's going to be used. Using it as FirstNormalTransactionId in HOT page pruning could incur in data loss. InitPostgres takes care of setting it to a valid value, but the extra checks are there to prevent "special" backends from behaving in unusual ways. Per Tom Lane's detailed problem dissection in 29544.1221061979@sss.pgh.pa.us
* Tweak newly added set_config_sourcefile() so that the target recordTom Lane2008-09-10
| | | | isn't left corrupt if guc_strdup should fail.
* Make our parsing of INTERVAL literals spec-compliant (or at least a heck ofTom Lane2008-09-10
| | | | | | | | | | | | | | | a lot closer than it was before). To do this, tweak coerce_type() to pass through the typmod information when invoking interval_in() on an UNKNOWN constant; then fix DecodeInterval to pay attention to the typmod when deciding how to interpret a units-less integer value. I changed one or two other details as well. I believe the code now reacts as expected by spec for all the literal syntaxes that are specifically enumerated in the spec. There are corner cases involving strings that don't exactly match the set of fields called out by the typmod, for which we might want to tweak the behavior some more; but I think this is an area of user friendliness rather than spec compliance. There remain some non-compliant details about the SQL syntax (as opposed to what's inside the literal string); but at least we'll throw error rather than silently doing the wrong thing in those cases.
* Add "source file" and "source line" information to each GUC variable.Alvaro Herrera2008-09-10
| | | | | | initdb forced due to changes in the pg_settings view. Magnus Hagander and Alvaro Herrera.
* Avoid using sprintf() for a simple octal conversion in PQescapeByteaInternal.Tom Lane2008-09-10
| | | | | Improves performance, per suggestion from Rudolf Leitgeb (bug #4414). The backend did this right already, but not libpq.
* Fix a couple of places where the plpgsql grammar would produce an unhelpfulTom Lane2008-09-10
| | | | | | 'syntax error' message, rather than something that might draw one's attention to a missing or wrong-type variable declaration. Per recent gripe.
* Improve the plan cache invalidation mechanism to make it invalidate plansTom Lane2008-09-09
| | | | | | | | | when user-defined functions used in a plan are modified. Also invalidate plans when schemas, operators, or operator classes are modified; but for these cases we just invalidate everything rather than tracking exact dependencies, since these types of objects seldom change in a production database. Tom Lane; loosely based on a patch by Martin Pihlak.
* Improve plpgsql's ability to report tuple incompatibility problems.Alvaro Herrera2008-09-09
| | | | Volkan YAZICI
* Fix a couple of problems pointed out by Fujii Masao in the 2008-Apr-05 patchTom Lane2008-09-08
| | | | | | | | | | for pg_stop_backup. First, it is possible that the history file name is not alphabetically later than the last WAL file name, so we should explicitly check that both have been archived. Second, the previous coding would wait forever if a checkpoint had managed to remove the WAL file before we look for it. Simon Riggs, plus some code cleanup by me.
* Make pg_dump --data-only try to order the table dumps so that foreign keys'Tom Lane2008-09-08
| | | | | | | referenced tables are dumped before the referencing tables. This avoids failures when the data is loaded with the FK constraints already active. If no such ordering is possible because of circular or self-referential constraints, print a NOTICE to warn the user about it.
* Create a separate grantable privilege for TRUNCATE, rather than having it beTom Lane2008-09-08
| | | | | | | always owner-only. The TRUNCATE privilege works identically to the DELETE privilege so far as interactions with the rest of the system go. Robert Haas
* Support set-returning functions in the target lists of Agg and Group planTom Lane2008-09-08
| | | | | | nodes. This is a pretty ugly feature but since we don't yet have a plausible substitute, we'd better support it everywhere. Per gripe from Jeff Davis.
* Reimplement text_position and related functions to use Boyer-Moore-HorspoolTom Lane2008-09-07
| | | | | | | | searching instead of naive matching. In the worst case this has the same O(M*N) complexity as the naive method, but the worst case is hard to hit, and the average case is very fast, especially with longer patterns. David Rowley
* Adjust psql's new \ef command to present an empty CREATE FUNCTION templateTom Lane2008-09-06
| | | | | | | | | | for editing if no function name is specified. This seems a much cleaner way to offer that functionality than the original patch had. In passing, de-clutter the error displays that are given for a bogus function-name argument, and standardize on "$function$" as the default delimiter for the function body. (The original coding would use the shortest possible dollar-quote delimiter, which seems to create unnecessarily high risk of later conflicts with the user-modified function body.)
* Implement a psql command "\ef" to edit the definition of a function.Tom Lane2008-09-06
| | | | | | | In support of that, create a backend function pg_get_functiondef(). The psql command is functional but maybe a bit rough around the edges... Abhijit Menon-Sen
* Add comment about why pg_dump doesn't dump the public schema comment.Bruce Momjian2008-09-05
|
* Fix an oversight in the 8.2 patch that improved mergejoin performance byTom Lane2008-09-05
| | | | | | | | | | | | | | | | | | inserting a materialize node above an inner-side sort node, when the sort is expected to spill to disk. (The materialize protects the sort from having to support mark/restore, allowing it to do its final merge pass on-the-fly.) We neglected to teach cost_mergejoin about that hack, so it was failing to include the materialize's costs in the estimated cost of the mergejoin. The materialize's costs are generally going to be pretty negligible in comparison to the sort's, so this is only a small error and probably not worth back-patching; but it's still wrong. In the similar case where a materialize is inserted to protect an inner-side node that can't do mark/restore at all, it's still true that the materialize should not spill to disk, and so we should cost it cheaply rather than expensively. Noted while thinking about a question from Tom Raney.
* Add Win32 MSVC code to support this recent patch:Bruce Momjian2008-09-05
| | | | | | Add missing descriptions for aggregates, functions and conversions. Bernd Helmle
* Code coverage testing with gcov. Documentation is in the regression testPeter Eisentraut2008-09-05
| | | | | | chapter. Author: Michelle Caisse <Michelle.Caisse@Sun.COM>
* Fix strategy propagation to scanEntry for partial match by moving propagationTeodor Sigaev2008-09-04
| | | | to initializaion of scanEntry.
* If a loadable module has wrong values in its magic block, spell outTom Lane2008-09-03
| | | | | exactly what they are in the complaint message. Marko Kreen, some editorialization by me.
* Prevent memory leaks in our various bison parsers when an error occursTom Lane2008-09-02
| | | | | | | during parsing. Formerly the parser's stack was allocated with malloc and so wouldn't be reclaimed; this patch makes it use palloc instead, so that flushing the current context will reclaim the memory. Per Marko Kreen.