aboutsummaryrefslogtreecommitdiff
path: root/doc/src
Commit message (Collapse)AuthorAge
...
* Doc: use true|false rather than on|off for "failover" optionDavid Rowley2024-05-17
| | | | | | | | | | | | | The CREATE SUBSCRIPTION documentation mentions "false" is the default option, so let's use true|false rather than on|off in the text which talks about this option in the ALTER SUBSCRIPTION page. The other boolean options mentioned in create_subscription.sgml use true and false so it makes sense to be consistent with these. The "failover" option is new to v17. Author: Peter Smith Discussion: https://postgr.es/m/CAHut+Ps-RqrggaJU5w85BbeQzw9CLmmLgADVJoJ=xx_4D5CWvw@mail.gmail.com
* pg_amcheck: Put new options in consistent order in --help and man pagePeter Eisentraut2024-05-16
|
* Revert temporal primary keys and foreign keysPeter Eisentraut2024-05-16
| | | | | | | | | | | | | | | | | | | | This feature set did not handle empty ranges correctly, and it's now too late for PostgreSQL 17 to fix it. The following commits are reverted: 6db4598fcb8 Add stratnum GiST support function 46a0cd4cefb Add temporal PRIMARY KEY and UNIQUE constraints 86232a49a43 Fix comment on gist_stratnum_btree 030e10ff1a3 Rename pg_constraint.conwithoutoverlaps to conperiod a88c800deb6 Use daterange and YMD in without_overlaps tests instead of tsrange. 5577a71fb0c Use half-open interval notation in without_overlaps tests 34768ee3616 Add temporal FOREIGN KEY contraints 482e108cd38 Add test for REPLICA IDENTITY with a temporal key c3db1f30cba doc: clarify PERIOD and WITHOUT OVERLAPS in CREATE TABLE 144c2ce0cc7 Fix ON CONFLICT DO NOTHING/UPDATE for temporal indexes Discussion: https://www.postgresql.org/message-id/d0b64a7a-dfe4-4b84-a906-c7dedfa40a3e@eisentraut.org
* doc PG 17 relnotes: wording adjustmentsBruce Momjian2024-05-15
| | | | | | | | | | Reported-by: jian he Discussion: https://postgr.es/m/CACJufxHTJBqDmBC4iPgte_xd4aMgONRm680Ji5m5gCA8+YEmJg@mail.gmail.com Co-authored-by: jian he Backpatch-through: master
* doc PG 17 relnotes: add item about vacuum storage/limits/WALBruce Momjian2024-05-15
| | | | | | | | Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/202405150838.sg5ddcexyyf4@alvherre.pgsql Backpatch-through: master
* doc: Mention more variant --name=value of -c name=value for postgresMichael Paquier2024-05-16
| | | | | | | | | | | | | | postgres --name=value and -c name=value are equivalents. This commit expands the documentation of libpq's "option" connection parameter and the server startup sequence for shell interactions to mention both rather than only -c. Extracted from a larger patch by the same authors. Reported-by: Alexey Palazhchenko Author: David Johnston, Aleksander Alekseev Reviewed-by: Nathan Bossart, Peter Eisentraut, Álvaro Herrera Discussion: https://postgr.es/m/CAJ7c6TMkuLiLfrA+EFCPYfhXoMKRxxssB5c86+ibxfaz6+=Sdg@mail.gmail.com
* doc: Add standard Environment section to pg_upgrade ref pagePeter Eisentraut2024-05-15
| | | | | Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org
* doc: Add standard Environment section to pg_amcheck ref pagePeter Eisentraut2024-05-15
| | | | | Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org
* doc: Remove claims that initdb and pg_ctl use libpq environment variablesPeter Eisentraut2024-05-15
| | | | | | | Erroneously introduced by 571df93cff8. Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://www.postgresql.org/message-id/flat/8458c9c5-18f1-46d7-94c4-1c30e4f44908%40eisentraut.org
* doc PG 17 relnotes: add logical replication apply subtrans itemBruce Momjian2024-05-14
| | | | | | | | Reported-by: Masahiko Sawada Discussion: https://postgr.es/m/CAD21AoD5jjB+M+BK5JTis8=W1g8KsS1961FyMqRpj=NBFXrJeA@mail.gmail.com Backpatch-through: master
* doc PG 17 relnotes: remove NOT NULL revert, add ALPN itemBruce Momjian2024-05-14
| | | | | | Make current as of 2024-05-14 Backpatch-through: master
* doc PG 17 relnotes: wording fixBruce Momjian2024-05-14
| | | | | | | | Reported-by: Pantelis Theodosiou Discussion: https://postgr.es/m/CAE3TBxxvkSGJGv7S0SMLSAe0khrQJBHsTca799r=vDJTn+BDAw@mail.gmail.com Backpatch-through: master
* doc PG 17 relnotes: wording fixesBruce Momjian2024-05-14
| | | | | | | | | | Reported-by: Elena Indrupskaya Discussion: https://postgr.es/m/22110133-bca5-4a99-889c-aa0096423456@postgrespro.ru Author: Elena Indrupskaya Backpatch-through: master
* doc PG 17 relnotes: add two optimizer itemsBruce Momjian2024-05-14
| | | | | | | | | | | | | One is about subqueries becoming joins and the other is about optimizing LIMIT by improving startup cost. Reported-by: Andy Fan Discussion: https://postgr.es/m/87h6f4ncc6.fsf@163.com Reviewed-by: David Rowley Backpatch-through: master
* doc PG 17 relnotes: add item about libpq large data transfersBruce Momjian2024-05-13
| | | | | | | | | | Reported-by: Jelte Fennema-Nio Discussion: https://postgr.es/m/CAGECzQTz5aUqLEL6daLd2Hu2FXS_LOSh4keDndJ1fwThsb_b5w@mail.gmail.com Reviewed-by: Joe Conway Backpatch-through: master
* doc PG 17 relnotes: add psql connection control-C itemBruce Momjian2024-05-13
| | | | | | | | | | Reported-by: Jelte Fennema-Nio Discussion: https://postgr.es/m/CAGECzQTz5aUqLEL6daLd2Hu2FXS_LOSh4keDndJ1fwThsb_b5w@mail.gmail.com Reviewed-by: Tom Lane Backpatch-through: master
* Fix pg_sequence_last_value() for unlogged sequences on standbys.Nathan Bossart2024-05-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Presently, when this function is called for an unlogged sequence on a standby server, it will error out with a message like ERROR: could not open file "base/5/16388": No such file or directory Since the pg_sequences system view uses pg_sequence_last_value(), it can error similarly. To fix, modify the function to return NULL for unlogged sequences on standby servers. Since this bug is present on all versions since v15, this approach is preferable to making the ERROR nicer because we need to repair the pg_sequences view without modifying its definition on released versions. For consistency, this commit also modifies the function to return NULL for other sessions' temporary sequences. The pg_sequences view already appropriately filters out such sequences, so there's no bug there, but we might as well offer some defense in case someone invokes this function directly. Unlogged sequences were first introduced in v15, but temporary sequences are much older, so while the fix for unlogged sequences is only back-patched to v15, the temporary sequence portion is back-patched to all supported versions. We could also remove the privilege check in the pg_sequences view definition in v18 if we modify this function to return NULL for sequences for which the current user lacks privileges, but that is left as a future exercise for when v18 development begins. Reviewed-by: Tom Lane, Michael Paquier Discussion: https://postgr.es/m/20240501005730.GA594666%40nathanxps13 Backpatch-through: 12
* Fix typoAlvaro Herrera2024-05-13
|
* Revert structural changes to not-null constraintsAlvaro Herrera2024-05-13
| | | | | | | | | | | | | | | | | | | | | | | | | There are some problems with the new way to handle these constraints that were detected at the last minute, and require fixes that appear too invasive to be doing this late in the cycle. Revert this (again) for now, we'll try again with these problems fixed. The following commits are reverted: b0e96f311985 Catalog not-null constraints 9b581c534186 Disallow changing NO INHERIT status of a not-null constraint d0ec2ddbe088 Fix not-null constraint test ac22a9545ca9 Move privilege check to the right place b0f7dd915bca Check stack depth in new recursive functions 3af721794272 Update information_schema definition for not-null constraints c3709100be73 Fix propagating attnotnull in multiple inheritance d9f686a72ee9 Fix restore of not-null constraints with inheritance d72d32f52d26 Don't try to assign smart names to constraints 0cd711271d42 Better handle indirect constraint drops 13daa33fa5a6 Disallow NO INHERIT not-null constraints on partitioned tables d45597f72fe5 Disallow direct change of NO INHERIT of not-null constraints 21ac38f498b3 Fix inconsistencies in error messages Discussion: https://postgr.es/m/202405110940.joxlqcx4dogd@alvherre.pgsql
* Introduce private data area for injection pointsMichael Paquier2024-05-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit extends the backend-side infrastructure of injection points so as it becomes possible to register some input data when attaching a point. This private data can be registered with the function name and the library name of the callback when attaching a point, then it is given as input argument to the callback. This gives the possibility for modules to pass down custom data at runtime when attaching a point without managing that internally, in a manner consistent with the callback entry retrieved from the hash shmem table storing the injection point data. InjectionPointAttach() gains two arguments, to be able to define the private data contents and its size. A follow-up commit will rely on this infrastructure to close a race condition with the injection point detach in the module injection_points. While on it, this changes InjectionPointDetach() to return a boolean, returning false if a point cannot be detached. This has been mentioned by Noah as useful when it comes to implement more complex tests with concurrent point detach, solid with the automatic detach done for local points in the test module. Documentation is adjusted in consequence. Per discussion with Noah Misch. Reviewed-by: Noah Misch Discussion: https://postgr.es/m/20240509031553.47@rfd.leadboat.com
* Change ALPN protocol ID to IANA-approved "postgresql"Heikki Linnakangas2024-05-11
| | | | | | | | "TBD-pgsql" was a placeholder until the IANA registration was approved. Discussion: https://www.postgresql.org/message-id/87jzk2hj2n.fsf%40wibble.ilmari.org Discussion: https://mailarchive.ietf.org/arch/msg/tls-reg-review/9LWPzQfOpbc8dTT7vc9ahNeNaiw/
* doc PG 17 relnotes: move FETCH_COUNT item, and clarifyBruce Momjian2024-05-10
| | | | Backpatch-through: master
* doc PG 17 relnotes: add FETCH_COUNT itemBruce Momjian2024-05-10
| | | | | | | | Reported-by: Daniel Verite Discussion: https://postgr.es/m/82569de4-9b2a-4311-beb2-81d5418491ec@manitou-mail.org Backpatch-through: master
* Doc: update the "Using EXPLAIN" examples to match current code.Tom Lane2024-05-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | A lot of the examples in this section are quite ancient and no longer match the system's current behavior. I ran through them and updated the sample output to match what I get today. Notably, it seems that the tenk1 table got a few pages smaller back around v12, so that a lot of the cost estimates for queries on that table are a little different now. (This also caused some examples to surprisingly not match others, depending on when they were made.) One mergejoin-based example no longer produces the same plan at all, so I had to work around that, including switching to a different example of using an enable_xxx setting. I also changed a couple of examples that were relying on nonexistent tables or indexes. IMO the premise of this section is that the examples should be more-or-less reproducible against the regression database, so that these examples were unhelpful as given. It's not that hard to find a corresponding example with the tables we do have. Some of the EXPLAIN ANALYZE examples were out of date in that we show more numbers than we did at the time. Possibly chapter 68 could use similar review, but I'm out of energy for today.
* doc PG 17 relnotes: fix author of LLVM itemBruce Momjian2024-05-09
| | | | | | Discussion: https://postgr.es/m/CA+hUKG+yU4+YqsCuQuzdCeETPdU+FjebXgV5Fkp6xrtr7EKC3w@mail.gmail.com Backpatch-through: master
* doc: clarify PERIOD and WITHOUT OVERLAPS in CREATE TABLEBruce Momjian2024-05-09
| | | | | | | | Discussion: https://postgr.es/m/04938501-fc8f-46f3-97a4-9a81a3f24530@illuminatedcomputing.com Author: Paul Jungwirth Backpatch-through: master
* doc PG 17 relnotes: Visual Studio clarificationBruce Momjian2024-05-09
| | | | | | Reported-by: Andrew Dunstan Backpatch-through: master
* doc PG 17 relnotes: Fixes from jian heBruce Momjian2024-05-09
| | | | Backpatch-through: master
* doc PG 17 relnotes: various fixesBruce Momjian2024-05-09
| | | | | | | Fixes suggested by David Rowley, Bertrand Drouvot, Masahiko Sawada, Richard Guo, jian he, Dagfinn Ilmari Mannsåker Backpatch-through: master
* doc: Use better placeholder in COPY synopsisPeter Eisentraut2024-05-09
|
* doc: first draft of Postgres 17 release notesBruce Momjian2024-05-08
| | | | Backpatch-through: master
* Doc: document that triggers can break referential integrity.Tom Lane2024-05-08
| | | | | | | | | | | | | | | | | | | | | | User-written triggers can modify or block the effects of SQL update and delete operations. That includes operations that are executed to implement foreign keys' referential integrity actions (such as ON UPDATE SET NULL or ON DELETE CASCADE). Therefore it's possible for a misdesigned trigger to result in a database state that violates the foreign key constraint. While this isn't great, the alternatives seem worse: in particular, refusing to fire triggers for such updates would break many valuable use-cases. We could also try to recheck the constraint after the action, but that'd roughly double the already-high cost of FK constraint enforcement, for no benefit in normal cases. So we've always considered that it's on the trigger programmer's head to avoid breaking RI actions. This was never documented anywhere, though. Add a para to the Triggers chapter to explain it. Laurenz Albe, David Johnston, Tom Lane Discussion: https://postgr.es/m/b81fe38fcc25a81be6e2e5b3fc1ff624130762fa.camel@cybertec.at
* doc: Improve order of options on pg_upgrade reference pagePeter Eisentraut2024-05-08
| | | | | Put the new long-only options in a location that is consistent with the existing long-only options and also the --help output.
* doc: Improve order of options on pgbench reference pagePeter Eisentraut2024-05-07
| | | | | | | Both the pgbench --help output and the reference page have sections for initialization options, benchmarking options, and common options. But the --debug option ended up in the wrong place on the reference page. Fix that by making the documentation match the --help output.
* Fix privilege checks in pg_stats_ext and pg_stats_ext_exprs.Nathan Bossart2024-05-06
| | | | | | | | | | | | | | | | | | | | | | | The catalog view pg_stats_ext fails to consider privileges for expression statistics. The catalog view pg_stats_ext_exprs fails to consider privileges and row-level security policies. To fix, restrict the data in these views to table owners or roles that inherit privileges of the table owner. It may be possible to apply less restrictive privilege checks in some cases, but that is left as a future exercise. Furthermore, for pg_stats_ext_exprs, do not return data for tables with row-level security enabled, as is already done for pg_stats_ext. On the back-branches, a fix-CVE-2024-4317.sql script is provided that will install into the "share" directory. This file can be used to apply the fix to existing clusters. Bumps catversion on 'master' branch only. Reported-by: Lukas Fittl Reviewed-by: Noah Misch, Tomas Vondra, Tom Lane Security: CVE-2024-4317 Backpatch-through: 14
* Revert: Remove useless self-joinsAlexander Korotkov2024-05-06
| | | | | | | | | | | | | | | | | This commit reverts d3d55ce5713 and subsequent fixes 2b26a694554, 93c85db3b5b, b44a1708abe, b7f315c9d7d, 8a8ed916f73, b5fb6736ed3, 0a93f803f45, e0477837ce4, a7928a57b9f, 5ef34a8fc38, 30b4955a466, 8c441c08279, 028b15405b4, fe093994db4, 489072ab7a9, and 466979ef031. We are quite late in the release cycle and new bugs continue to appear. Even though we have fixes for all known bugs, there is a risk of throwing many bugs to end users. The plan for self-join elimination would be to do more review and testing, then re-commit in the early v18 cycle. Reported-by: Tom Lane Discussion: https://postgr.es/m/2422119.1714691974%40sss.pgh.pa.us
* Remove mention of ncharAlvaro Herrera2024-05-06
| | | | | | | This datatype is purposefully not documented. Erik Wienhold <ewie@ewie.name> Discussion: https://postgr.es/m/om3g7p7u3ztlrdp4tfswgulavljgn2fe6u2agk34mrr65dffuu@cpzlzuv6flko
* doc: Improve order of options on initdb reference pagePeter Eisentraut2024-05-06
| | | | | | | Both the initdb --help output and the reference page have a section for options and a section for less commonly used options. But some recently added options were sprinkled around inconsistently. Fix that by making the documentation match the --help output.
* Fix an assortment of typosDavid Rowley2024-05-04
| | | | | Author: Alexander Lakhin Discussion: https://postgr.es/m/ae9f2fcb-4b24-5bb0-4240-efbbbd944ca1@gmail.com
* Disallow direct change of NO INHERIT of not-null constraintsAlvaro Herrera2024-05-02
| | | | | | | | | | | | | | | | | | | | | | | We support changing NO INHERIT constraint to INHERIT for constraints in child relations when adding a constraint to some ancestor relation, and also during pg_upgrade's schema restore; but other than those special cases, command ALTER TABLE ADD CONSTRAINT should not be allowed to change an existing constraint from NO INHERIT to INHERIT, as that would require to process child relations so that they also acquire an appropriate constraint, which we may not be in a position to do. (It'd also be surprising behavior.) It is conceivable that we want to allow ALTER TABLE SET NOT NULL to make such a change; but in that case some more code is needed to implement it correctly, so for now I've made that throw the same error message. Also, during the prep phase of ALTER TABLE ADD CONSTRAINT, acquire locks on all descendant tables; otherwise we might operate on child tables on which no locks are held, particularly in the mode where a primary key causes not-null constraints to be created on children. Reported-by: Alexander Lakhin <exclusion@gmail.com> Discussion: https://postgr.es/m/7d923a66-55f0-3395-cd40-81c142b5448b@gmail.com
* doc: Fix incorrectly spelled structnameDaniel Gustafsson2024-05-02
| | | | | | | | Commit 61461a300c1 accidentally misspelled the PGcancelConn struct using the PQ prefix (which admittedly is a very easy typo to make). Reported off-list. Reported-by: Alexander Lakhin <exclusion@gmail.com>
* doc: Fix description of deterministic flag of CREATE COLLATIONPeter Eisentraut2024-05-02
| | | | | | | | | | | The documentation said that you need to pick a suitable LC_COLLATE setting in addition to setting the DETERMINISTIC flag. This would have been correct if the libc provider supported nondeterministic collations, but since it doesn't, you actually need to set the LOCALE option. Reviewed-by: Kashif Zeeshan <kashi.zeeshan@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/a71023c2-0ae0-45ad-9688-cf3b93d0d65b%40eisentraut.org
* doc: Fix description of configure --with-icu optionPeter Eisentraut2024-05-02
| | | | | | | | | | It was claiming that the ICU locale provider is used by default, which is not correct. (From commit fcb21b3acdc; it was once contemplated to make it the default, but it wouldn't have been part of that patch in any case.) Reviewed-by: Kashif Zeeshan <kashi.zeeshan@gmail.com> Discussion: https://www.postgresql.org/message-id/flat/a71023c2-0ae0-45ad-9688-cf3b93d0d65b%40eisentraut.org
* doc: Remove one example related to pg_input_error_info()Michael Paquier2024-04-30
| | | | | | | | | This slightly bloated the contents of the function table for this entry, without really bringing extra value. Per discussion with Jian He and David G. Johnston. Discussion: https://postgr.es/m/CACJufxGdyoBJQMSxwdxNK=k8M5WUth5FDFd4Wq_K4f7+1J2xuQ@mail.gmail.com
* Inherit parent's AM for partition MERGE/SPLIT operationsAlexander Korotkov2024-04-30
| | | | | | | | | | This commit makes new partitions created by ALTER TABLE ... SPLIT PARTITION and ALTER TABLE ... MERGE PARTITIONS commands inherit the paret table access method. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/84ada05b-be5c-473e-6d1c-ebe5dd21b190%40gmail.com Reviewed-by: Pavel Borisov
* Make new partitions with parent's persistence during MERGE/SPLITAlexander Korotkov2024-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | The createPartitionTable() function is responsible for creating new partitions for ALTER TABLE ... MERGE PARTITIONS, and ALTER TABLE ... SPLIT PARTITION commands. It emulates the behaviour of CREATE TABLE ... (LIKE ...), where new table persistence should be specified by the user. In the table partitioning persistent of the partition and its parent must match. So, this commit makes createPartitionTable() copy the persistence of the parent partition. Also, this commit makes createPartitionTable() recheck the persistence after the new table creation. This is needed because persistence might be affected by pg_temp in search_path. This commit also changes the signature of createPartitionTable() making it take the parent's Relation itself instead of the name of the parent relation, and return the Relation of new partition. That doesn't lead to complications, because both callers have the parent table open and need to open the new partition. Reported-by: Alexander Lakhin Discussion: https://postgr.es/m/dbc8b96c-3cf0-d1ee-860d-0e491da20485%40gmail.com Author: Dmitry Koval Reviewed-by: Alexander Korotkov, Robert Haas, Justin Pryzby, Pavel Borisov
* Document the way partition MERGE/SPLIT operations create new partitionsAlexander Korotkov2024-04-30
| | | | | | Reported-by: Justin Pryzby Discussion: https://postgr.es/m/ZilrByTp-pbz6Mvf%40pryzbyj2023 Reviewed-by: Justin Pryzby
* Fix failure to track role dependencies of pg_init_privs entries.Tom Lane2024-04-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If an ACL recorded in pg_init_privs mentions a non-pinned role, that reference must also be noted in pg_shdepend so that we know that the role can't go away without removing the ACL reference. Otherwise, DROP ROLE could succeed and leave dangling entries behind, which is what's causing the recent upgrade-check failures on buildfarm member copperhead. This has been wrong since pg_init_privs was introduced, but it's escaped notice because typical pg_init_privs entries would only mention the bootstrap superuser (pinned) or at worst the owner of the extension (who can't go away before the extension does). We lack even a representation of such a role reference for pg_shdepend. My first thought for a solution was entries listing pg_init_privs in classid, but that doesn't work because then there's noplace to put the granted-on object's classid. Rather than adding a new column to pg_shdepend, let's add a new deptype code SHARED_DEPENDENCY_INITACL. Much of the associated boilerplate code can be cribbed from code for SHARED_DEPENDENCY_ACL. A lot of the bulk of this patch just stems from the new need to pass the object's owner ID to recordExtensionInitPriv, so that we can consult it while updating pg_shdepend. While many callers have that at hand already, a few places now need to fetch the owner ID of an arbitrary privilege-bearing object. For that, we assume that there is a catcache on the relevant catalog's OID column, which is an assumption already made in ExecGrant_common so it seems okay here. We do need an entirely new routine RemoveRoleFromInitPriv to perform cleanup of pg_init_privs ACLs during DROP OWNED BY. It's analogous to RemoveRoleFromObjectACL, but we can't share logic because that function operates by building a command parsetree and invoking existing GRANT/REVOKE infrastructure. There is of course no SQL command that would update pg_init_privs entries when we're not in process of creating their extension, so we need a routine that can do the updates directly. catversion bump because this changes the expected contents of pg_shdepend. For the same reason, there's no hope of back-patching this, even though it fixes a longstanding bug. Fortunately, the case where it's a problem seems to be near nonexistent in the field. If it weren't for the buildfarm breakage, I'd have been content to leave this for v18. Patch by me; thanks to Daniel Gustafsson for review and discussion. Discussion: https://postgr.es/m/1745535.1712358659@sss.pgh.pa.us
* Revert "Add GUC backtrace_on_internal_error"Peter Eisentraut2024-04-29
| | | | | | | | | | | | This reverts commit a740b213d4b4d3360ad0cac696e47e5ec0eb8864. Subsequent discussion showed that there was interest in a more general facility to configure when server log events would produce backtraces, and this existing limited way couldn't be extended in a compatible way. So the consensus was to revert this for PostgreSQL 17 and reconsider this topic for PostgreSQL 18. Discussion: https://www.postgresql.org/message-id/flat/CAGECzQTChkvn5Xj772LB3%3Dxo2x_LcaO5O0HQvXqobm1xVp6%2B4w%40mail.gmail.com#764bcdbb73e162787e1ad984935e51e3
* Fix documentation and comments on what happens after GSS rejectionHeikki Linnakangas2024-04-28
| | | | | | | | | | | | | | The paragraph in the docs and the comment applied to sslnegotiaton=direct, but not sslnegotiation=requiredirect. In 'requiredirect' mode, negotiated SSL is never used. Move the paragraph in the docs under the description of 'direct' mode, and rephrase it. Also the comment's reference to reusing a plaintext connection was bogus. Authentication failure in plaintext mode only happens after sending the startup packet, so the connection cannot be reused. Reported-by: Jacob Champion Discussion: https://www.postgresql.org/message-id/CAOYmi+=sj+1uydS0NR4nYzw-LRWp3Q-s5speBug5UCLSPMbvGA@mail.gmail.com