aboutsummaryrefslogtreecommitdiff
path: root/src/interfaces/ecpg/lib
diff options
context:
space:
mode:
Diffstat (limited to 'src/interfaces/ecpg/lib')
-rw-r--r--src/interfaces/ecpg/lib/README.dynSQL20
-rw-r--r--src/interfaces/ecpg/lib/dynamic.c17
2 files changed, 21 insertions, 16 deletions
diff --git a/src/interfaces/ecpg/lib/README.dynSQL b/src/interfaces/ecpg/lib/README.dynSQL
new file mode 100644
index 00000000000..fedcf80402d
--- /dev/null
+++ b/src/interfaces/ecpg/lib/README.dynSQL
@@ -0,0 +1,20 @@
+descriptor statements have the following shortcomings
+
+- up to now the only reasonable statement is
+ FETCH ... INTO SQL DESCRIPTOR <name>
+ no input variables allowed!
+
+ Reason: to fully support dynamic SQL the frontend/backend communication
+ should change to recognize input parameters.
+ Since this is not likely to happen in the near future and you
+ can cover the same functionality with the existing infrastructure
+ I'll leave the work to someone else.
+
+- string buffer overflow does not always generate warnings
+ (beware: terminating 0 may be missing because strncpy is used)
+ :var=data sets sqlwarn accordingly (but not indicator)
+
+- char variables pointing to NULL are not allocated on demand
+
+- string truncation does not show up in indicator
+
diff --git a/src/interfaces/ecpg/lib/dynamic.c b/src/interfaces/ecpg/lib/dynamic.c
index ec8e927d649..752c02cfc0d 100644
--- a/src/interfaces/ecpg/lib/dynamic.c
+++ b/src/interfaces/ecpg/lib/dynamic.c
@@ -2,26 +2,11 @@
*
* Copyright (c) 2000, Christof Petig <christof.petig@wtal.de>
*
- * $Header: /cvsroot/pgsql/src/interfaces/ecpg/lib/Attic/dynamic.c,v 1.1 2000/02/16 16:18:12 meskes Exp $
+ * $Header: /cvsroot/pgsql/src/interfaces/ecpg/lib/Attic/dynamic.c,v 1.2 2000/02/17 19:48:41 meskes Exp $
*/
/* I borrowed the include files from ecpglib.c, maybe we don't need all of them */
-#if 0
-#include <stdio.h>
-#include <stdlib.h>
-#include <unistd.h>
-#include <stdarg.h>
-#include <string.h>
-#include <ctype.h>
-#include <locale.h>
-
-#include <libpq-fe.h>
-#include <libpq/pqcomm.h>
-#include <ecpgtype.h>
-#include <ecpglib.h>
-#include <sqlca.h>
-#endif
#include <sql3types.h>
static struct descriptor