]> git.kaiwu.me - nginx.git/log
nginx.git
2 years agoRemoved README.
Roman Arutyunyan [Sun, 14 May 2023 06:31:24 +0000 (10:31 +0400)]
Removed README.

3 years agoHTTP/3: removed server push support.
Roman Arutyunyan [Fri, 12 May 2023 06:02:10 +0000 (10:02 +0400)]
HTTP/3: removed server push support.

2 years agoCommon tree insert function for QUIC and UDP connections.
Roman Arutyunyan [Sun, 14 May 2023 08:30:11 +0000 (12:30 +0400)]
Common tree insert function for QUIC and UDP connections.

Previously, ngx_udp_rbtree_insert_value() was used for plain UDP and
ngx_quic_rbtree_insert_value() was used for QUIC.  Because of this it was
impossible to initialize connection tree in ngx_create_listening() since
this function is not aware what kind of listening it creates.

Now ngx_udp_rbtree_insert_value() is used for both QUIC and UDP.  To make
is possible, a generic key field is added to ngx_udp_connection_t.  It keeps
client address for UDP and connection ID for QUIC.

2 years agoStream: removed QUIC support.
Roman Arutyunyan [Sun, 14 May 2023 08:05:35 +0000 (12:05 +0400)]
Stream: removed QUIC support.

3 years agoQUIC: style.
Maxim Dounin [Thu, 11 May 2023 15:48:01 +0000 (18:48 +0300)]
QUIC: style.

3 years agoHTTP/3: removed "http3" parameter of "listen" directive.
Roman Arutyunyan [Thu, 11 May 2023 09:22:10 +0000 (13:22 +0400)]
HTTP/3: removed "http3" parameter of "listen" directive.

The parameter has been deprecated since c851a2ed5ce8.

3 years agoQUIC: removed "quic_mtu" directive.
Roman Arutyunyan [Thu, 11 May 2023 06:37:51 +0000 (10:37 +0400)]
QUIC: removed "quic_mtu" directive.

The directive used to set the value of the "max_udp_payload_size" transport
parameter.  According to RFC 9000, Section 18.2, the value specifies the size
of buffer for reading incoming datagrams:

    This limit does act as an additional constraint on datagram size in
    the same way as the path MTU, but it is a property of the endpoint
    and not the path; see Section 14. It is expected that this is the
    space an endpoint dedicates to holding incoming packets.

Current QUIC implementation uses the maximum possible buffer size (65527) for
reading datagrams.

3 years agoQUIC: resized input datagram buffer from 65535 to 65527.
Roman Arutyunyan [Thu, 11 May 2023 05:49:34 +0000 (09:49 +0400)]
QUIC: resized input datagram buffer from 65535 to 65527.

The value of 65527 is the maximum permitted UDP payload size.

3 years agoQUIC: keep stream sockaddr and addr_text constant.
Roman Arutyunyan [Thu, 11 May 2023 15:40:11 +0000 (19:40 +0400)]
QUIC: keep stream sockaddr and addr_text constant.

HTTP and Stream variables $remote_addr and $binary_remote_addr rely on
constant client address, particularly because they are cacheable.
However, QUIC client may migrate to a new address.  While there's no perfect
way to handle this, the proposed solution is to copy client address to QUIC
stream at stream creation.

The change also fixes truncated $remote_addr if migration happened while the
stream was active.  The reason is addr_text string was copied to stream by
value.

3 years agoQUIC: set c->socklen for streams.
Roman Arutyunyan [Thu, 27 Apr 2023 15:49:05 +0000 (19:49 +0400)]
QUIC: set c->socklen for streams.

Previously, the value was not set and remained zero.  While in nginx code the
value of c->sockaddr is accessed without taking c->socklen into account,
invalid c->socklen could lead to unexpected results in third-party modules.

3 years agoQUIC: fixed addr_text after migration (ticket #2488).
Roman Arutyunyan [Thu, 27 Apr 2023 15:52:40 +0000 (19:52 +0400)]
QUIC: fixed addr_text after migration (ticket #2488).

Previously, the post-migration value of addr_text could be truncated, if
it was longer than the previous one.  Also, the new value always included
port, which should not be there.

3 years agoQUIC: reschedule path validation on path insertion/removal.
Sergey Kandaurov [Tue, 9 May 2023 15:42:40 +0000 (19:42 +0400)]
QUIC: reschedule path validation on path insertion/removal.

Two issues fixed:
- new path validation could be scheduled late
- a validated path could leave a spurious timer

3 years agoQUIC: lower bound path validation PTO.
Sergey Kandaurov [Tue, 9 May 2023 15:42:40 +0000 (19:42 +0400)]
QUIC: lower bound path validation PTO.

According to RFC 9000, 8.2.4. Failed Path Validation,
the following value is recommended as a validation timeout:

  A value of three times the larger of the current PTO
  or the PTO for the new path (using kInitialRtt, as
  defined in [QUIC-RECOVERY]) is RECOMMENDED.

The change adds PTO of the new path to the equation as the lower bound.

3 years agoQUIC: separated path validation retransmit backoff.
Sergey Kandaurov [Tue, 9 May 2023 15:42:39 +0000 (19:42 +0400)]
QUIC: separated path validation retransmit backoff.

Path validation packets containing PATH_CHALLENGE frames are sent separately
from regular frame queue, because of the need to use a decicated path and pad
the packets.  The packets are sent periodically, separately from the regular
probe/lost detection mechanism.  A path validation packet is resent up to 3
times, each time after PTO expiration, with increasing per-path PTO backoff.

3 years agoQUIC: removed check for in-flight packets in computing PTO.
Sergey Kandaurov [Tue, 9 May 2023 15:42:38 +0000 (19:42 +0400)]
QUIC: removed check for in-flight packets in computing PTO.

The check is needed for clients in order to unblock a server due to
anti-amplification limits, and it seems to make no sense for servers.
See RFC 9002, A.6 and A.8 for a further explanation.

This makes max_ack_delay to now always account, notably including
PATH_CHALLENGE timers as noted in the last paragraph of 9000, 9.4,
unlike when it was only used when there are packets in flight.

While here, fixed nearby style.

3 years agoQUIC: disabled datagram fragmentation.
Roman Arutyunyan [Sat, 6 May 2023 12:23:27 +0000 (16:23 +0400)]
QUIC: disabled datagram fragmentation.

As per RFC 9000, Section 14:

  UDP datagrams MUST NOT be fragmented at the IP layer.

3 years agoQUIC: fixed encryption level in ngx_quic_frame_sendto().
Roman Arutyunyan [Thu, 4 May 2023 15:29:34 +0000 (19:29 +0400)]
QUIC: fixed encryption level in ngx_quic_frame_sendto().

Previously, ssl_encryption_application was hardcoded.  Before 9553eea74f2a,
ngx_quic_frame_sendto() was used only for PATH_CHALLENGE/PATH_RESPONSE sent
at the application level only.  Since 9553eea74f2a, ngx_quic_frame_sendto()
is also used for CONNECTION_CLOSE, which can be sent at initial level after
SSL handshake error or rejection.  This resulted in packet encryption error.
Now level is copied from frame, which fixes the error.

3 years agoQUIC: optimized immediate close.
Roman Arutyunyan [Tue, 2 May 2023 13:54:53 +0000 (17:54 +0400)]
QUIC: optimized immediate close.

Previously, before sending CONNECTION_CLOSE to client, all pending frames
were sent.  This is redundant and could prevent CONNECTION_CLOSE from being
sent due to congestion control.  Now pending frames are freed and
CONNECTION_CLOSE is sent without congestion control, as advised by RFC 9002:

  Packets containing frames besides ACK or CONNECTION_CLOSE frames
  count toward congestion control limits and are considered to be in flight.

3 years agoQUIC: fixed split frames error handling.
Sergey Kandaurov [Thu, 4 May 2023 11:52:23 +0000 (15:52 +0400)]
QUIC: fixed split frames error handling.

Do not corrupt frame data chain pointer on ngx_quic_read_buffer() error.
The error leads to closing a QUIC connection where the frame may be used
as part of the QUIC connection tear down, which envolves writing pending
frames, including this one.

3 years agoHTTP/3: fixed ngx_http_v3_init_session() error handling.
Sergey Kandaurov [Thu, 4 May 2023 11:52:22 +0000 (15:52 +0400)]
HTTP/3: fixed ngx_http_v3_init_session() error handling.

A QUIC connection is not usable yet at this early stage of spin up.

3 years agoREADME: revised TLSv1.3 requirement for QUIC.
Roman Arutyunyan [Tue, 11 Apr 2023 14:29:20 +0000 (18:29 +0400)]
README: revised TLSv1.3 requirement for QUIC.

TLSv1.3 is enabled by default since d1cf09451ae8.

3 years agoStream: allow waiting on a blocked QUIC stream (ticket #2479).
Roman Arutyunyan [Thu, 6 Apr 2023 11:39:48 +0000 (15:39 +0400)]
Stream: allow waiting on a blocked QUIC stream (ticket #2479).

Previously, waiting on a shared connection was not allowed, because the only
type of such connection was plain UDP.  However, QUIC stream connections are
also shared since they share socket descriptor with the listen connection.
Meanwhile, it's perfectly normal to wait on such connections.

The issue manifested itself with stream write errors when the amount of data
exceeded stream buffer size or flow control.  Now no error is triggered
and Stream write module is allowed to wait for buffer space to become available.

3 years agoHTTP/3: fixed CANCEL_PUSH handling.
Sergey Kandaurov [Thu, 6 Apr 2023 14:18:41 +0000 (18:18 +0400)]
HTTP/3: fixed CANCEL_PUSH handling.

3 years agoQUIC: optimized sending stream response.
Roman Arutyunyan [Mon, 3 Apr 2023 12:17:12 +0000 (16:17 +0400)]
QUIC: optimized sending stream response.

When a stream is created by client, it's often the case that nginx will send
immediate response on that stream.  An example is HTTP/3 request stream, which
in most cases quickly replies with at least HTTP headers.

QUIC stream init handlers are called from a posted event.  Output QUIC
frames are also sent to client from a posted event, called the push event.
If the push event is posted before the stream init event, then output produced
by stream may trigger sending an extra UDP datagram.  To address this, push
event is now re-posted when a new stream init event is posted.

An example is handling 0-RTT packets.  Client typically sends an init packet
coalesced with a 0-RTT packet.  Previously, nginx replied with a padded CRYPTO
datagram, followed by a 1-RTT stream reply datagram.  Now CRYPTO and STREAM
packets are coalesced in one reply datagram, which saves bandwidth.

Other examples include coalescing 1-RTT first stream response, and
MAX_STREAMS/STREAM sent in response to ACK/STREAM.

3 years agoMerged with the default branch.
Sergey Kandaurov [Wed, 29 Mar 2023 07:14:25 +0000 (11:14 +0400)]
Merged with the default branch.

3 years agorelease-1.23.4 tag
Maxim Dounin [Tue, 28 Mar 2023 15:01:54 +0000 (18:01 +0300)]
release-1.23.4 tag

3 years agonginx-1.23.4-RELEASE release-1.23.4
Maxim Dounin [Tue, 28 Mar 2023 15:01:53 +0000 (18:01 +0300)]
nginx-1.23.4-RELEASE

3 years agoUpdated OpenSSL used for win32 builds.
Maxim Dounin [Mon, 27 Mar 2023 23:25:55 +0000 (02:25 +0300)]
Updated OpenSSL used for win32 builds.

3 years agoGzip: compatibility with recent zlib-ng versions.
Maxim Dounin [Mon, 27 Mar 2023 18:25:05 +0000 (21:25 +0300)]
Gzip: compatibility with recent zlib-ng versions.

It now uses custom alloc_aligned() wrapper for all allocations,
therefore all allocations are larger than expected by (64 + sizeof(void*)).
Further, they are seen as allocations of 1 element.  Relevant calculations
were adjusted to reflect this, and state allocation is now protected
with a flag to avoid misinterpreting other allocations as the zlib
deflate_state allocation.

Further, it no longer forces window bits to 13 on compression level 1,
so the comment was adjusted to reflect this.

3 years agoSSL: enabled TLSv1.3 by default.
Maxim Dounin [Thu, 23 Mar 2023 23:57:43 +0000 (02:57 +0300)]
SSL: enabled TLSv1.3 by default.

3 years agoMail: fixed handling of blocked client read events in proxy.
Maxim Dounin [Thu, 23 Mar 2023 23:53:21 +0000 (02:53 +0300)]
Mail: fixed handling of blocked client read events in proxy.

When establishing a connection to the backend, nginx blocks reading
from the client with ngx_mail_proxy_block_read().  Previously, such
events were lost, and in some cases this resulted in connection hangs.

Notably, this affected mail_imap_ssl.t on Windows, since the test
closes connections after requesting authentication, but without
waiting for any responses (so the connection close events might be
lost).

Fix is to post an event to read from the client after connecting to
the backend if there were blocked events.

3 years agoQUIC: style.
Roman Arutyunyan [Wed, 15 Mar 2023 15:57:15 +0000 (19:57 +0400)]
QUIC: style.

3 years agoHTTP/3: fixed OpenSSL compatibility layer initialization.
Sergey Kandaurov [Fri, 24 Mar 2023 15:49:50 +0000 (19:49 +0400)]
HTTP/3: fixed OpenSSL compatibility layer initialization.

SSL context is not present if the default server has neither certificates nor
ssl_reject_handshake enabled.  Previously, this led to null pointer dereference
before it would be caught with configuration checks.

Additionally, non-default servers with distinct SSL contexts need to initialize
compatibility layer in order to complete a QUIC handshake.

3 years agoSyslog: introduced error log handler.
Maxim Dounin [Fri, 10 Mar 2023 04:43:50 +0000 (07:43 +0300)]
Syslog: introduced error log handler.

This ensures that errors which happen during logging to syslog are logged
with proper context, such as "while logging to syslog" and the server name.

Prodded by Safar Safarly.

3 years agoSyslog: removed usage of ngx_cycle->log and ngx_cycle->hostname.
Maxim Dounin [Fri, 10 Mar 2023 04:43:40 +0000 (07:43 +0300)]
Syslog: removed usage of ngx_cycle->log and ngx_cycle->hostname.

During initial startup the ngx_cycle->hostname is not available, and
previously this resulted in incorrect logging.  Instead, hostname from the
configuration being parsed is now preserved in the syslog peer structure
and then used during logging.

Similarly, ngx_cycle->log might not match the configuration where the
syslog peer is defined if the configuration is not yet fully applied,
and previously this resulted in unexpected logging of syslog errors
and debug information.  Instead, cf->cycle->new_log is now referenced
in the syslog peer structure and used for logging, similarly to how it
is done in other modules.

3 years agoHTTP/2: finalize request as bad if header validation fails.
Maxim Dounin [Fri, 10 Mar 2023 03:47:53 +0000 (06:47 +0300)]
HTTP/2: finalize request as bad if header validation fails.

Similarly to 7192:d5a535774861, this avoids spurious zero statuses
in access.log, and in line with other header-related errors.

3 years agoHTTP/2: socket leak with "return 444" in error_page (ticket #2455).
Maxim Dounin [Fri, 10 Mar 2023 03:47:48 +0000 (06:47 +0300)]
HTTP/2: socket leak with "return 444" in error_page (ticket #2455).

Similarly to ticket #274 (7354:1812f1d79d84), early request finalization
without calling ngx_http_run_posted_requests() resulted in a connection
hang (a socket leak) if the 400 (Bad Request) error was generated in
ngx_http_v2_state_process_header() due to invalid request headers and
"return 444" was used in error_page 400.

3 years agoSSL: logging levels of errors observed with BoringSSL.
Maxim Dounin [Wed, 8 Mar 2023 19:22:47 +0000 (22:22 +0300)]
SSL: logging levels of errors observed with BoringSSL.

As tested with tlsfuzzer with BoringSSL, the following errors are
certainly client-related:

SSL_do_handshake() failed (SSL: error:10000066:SSL routines:OPENSSL_internal:BAD_ALERT)
SSL_do_handshake() failed (SSL: error:10000089:SSL routines:OPENSSL_internal:DECODE_ERROR)
SSL_do_handshake() failed (SSL: error:100000dc:SSL routines:OPENSSL_internal:TOO_MANY_WARNING_ALERTS)
SSL_do_handshake() failed (SSL: error:10000100:SSL routines:OPENSSL_internal:INVALID_COMPRESSION_LIST)
SSL_do_handshake() failed (SSL: error:10000102:SSL routines:OPENSSL_internal:MISSING_KEY_SHARE)
SSL_do_handshake() failed (SSL: error:1000010e:SSL routines:OPENSSL_internal:TOO_MUCH_SKIPPED_EARLY_DATA)
SSL_read() failed (SSL: error:100000b6:SSL routines:OPENSSL_internal:NO_RENEGOTIATION)

Accordingly, the SSL_R_BAD_ALERT, SSL_R_DECODE_ERROR,
SSL_R_TOO_MANY_WARNING_ALERTS, SSL_R_INVALID_COMPRESSION_LIST,
SSL_R_MISSING_KEY_SHARE, SSL_R_TOO_MUCH_SKIPPED_EARLY_DATA,
and SSL_R_NO_RENEGOTIATION errors are now logged at the "info" level.

3 years agoSSL: logging levels of errors observed with tlsfuzzer and LibreSSL.
Maxim Dounin [Wed, 8 Mar 2023 19:22:34 +0000 (22:22 +0300)]
SSL: logging levels of errors observed with tlsfuzzer and LibreSSL.

As tested with tlsfuzzer with LibreSSL 3.7.0, the following errors are
certainly client-related:

SSL_do_handshake() failed (SSL: error:14026073:SSL routines:ACCEPT_SR_CLNT_HELLO:bad packet length)
SSL_do_handshake() failed (SSL: error:1402612C:SSL routines:ACCEPT_SR_CLNT_HELLO:ssl3 session id too long)
SSL_do_handshake() failed (SSL: error:140380EA:SSL routines:ACCEPT_SR_KEY_EXCH:tls rsa encrypted value length is wrong)

Accordingly, the SSL_R_BAD_PACKET_LENGTH ("bad packet length"),
SSL_R_SSL3_SESSION_ID_TOO_LONG ("ssl3 session id too long"),
SSL_R_TLS_RSA_ENCRYPTED_VALUE_LENGTH_IS_WRONG ("tls rsa encrypted value
length is wrong") errors are now logged at the "info" level.

3 years agoSSL: logging levels of various errors reported with tlsfuzzer.
Maxim Dounin [Wed, 8 Mar 2023 19:21:59 +0000 (22:21 +0300)]
SSL: logging levels of various errors reported with tlsfuzzer.

To further differentiate client-related errors and adjust logging levels
of various SSL errors, nginx was tested with tlsfuzzer with multiple
OpenSSL versions (3.1.0-beta1, 3.0.8, 1.1.1t, 1.1.0l, 1.0.2u, 1.0.1u,
1.0.0s, 0.9.8zh).

The following errors were observed during tlsfuzzer runs with OpenSSL 3.0.8,
and are clearly client-related:

SSL_do_handshake() failed (SSL: error:0A000092:SSL routines::data length too long)
SSL_do_handshake() failed (SSL: error:0A0000A0:SSL routines::length too short)
SSL_do_handshake() failed (SSL: error:0A000124:SSL routines::bad legacy version)
SSL_do_handshake() failed (SSL: error:0A000178:SSL routines::no shared signature algorithms)

Accordingly, the SSL_R_DATA_LENGTH_TOO_LONG ("data length too long"),
SSL_R_LENGTH_TOO_SHORT ("length too short"), SSL_R_BAD_LEGACY_VERSION
("bad legacy version"), and SSL_R_NO_SHARED_SIGNATURE_ALGORITHMS
("no shared signature algorithms", misspelled as "sigature" in OpenSSL 1.0.2)
errors are now logged at the "info" level.

Additionally, the following errors were observed with OpenSSL 3.0.8 and
with TLSv1.3 enabled:

SSL_do_handshake() failed (SSL: error:0A00006F:SSL routines::bad digest length)
SSL_do_handshake() failed (SSL: error:0A000070:SSL routines::missing sigalgs extension)
SSL_do_handshake() failed (SSL: error:0A000096:SSL routines::encrypted length too long)
SSL_do_handshake() failed (SSL: error:0A00010F:SSL routines::bad length)
SSL_read() failed (SSL: error:0A00007A:SSL routines::bad key update)
SSL_read() failed (SSL: error:0A000125:SSL routines::mixed handshake and non handshake data)

Accordingly, the SSL_R_BAD_DIGEST_LENGTH ("bad digest length"),
SSL_R_MISSING_SIGALGS_EXTENSION ("missing sigalgs extension"),
SSL_R_ENCRYPTED_LENGTH_TOO_LONG ("encrypted length too long"),
SSL_R_BAD_LENGTH ("bad length"), SSL_R_BAD_KEY_UPDATE ("bad key update"),
and SSL_R_MIXED_HANDSHAKE_AND_NON_HANDSHAKE_DATA ("mixed handshake and non
handshake data") errors are now logged at the "info" level.

Additionally, the following errors were observed with OpenSSL 1.1.1t:

SSL_do_handshake() failed (SSL: error:14094091:SSL routines:ssl3_read_bytes:data between ccs and finished)
SSL_do_handshake() failed (SSL: error:14094199:SSL routines:ssl3_read_bytes:too many warn alerts)
SSL_read() failed (SSL: error:1408F0C6:SSL routines:ssl3_get_record:packet length too long)
SSL_read() failed (SSL: error:14094085:SSL routines:ssl3_read_bytes:ccs received early)

Accordingly, the SSL_R_CCS_RECEIVED_EARLY ("ccs received early"),
SSL_R_DATA_BETWEEN_CCS_AND_FINISHED ("data between ccs and finished"),
SSL_R_PACKET_LENGTH_TOO_LONG ("packet length too long"), and
SSL_R_TOO_MANY_WARN_ALERTS ("too many warn alerts") errors are now logged
at the "info" level.

Additionally, the following errors were observed with OpenSSL 1.0.2u:

SSL_do_handshake() failed (SSL: error:1407612A:SSL routines:SSL23_GET_CLIENT_HELLO:record too small)
SSL_do_handshake() failed (SSL: error:1408C09A:SSL routines:ssl3_get_finished:got a fin before a ccs)

Accordingly, the SSL_R_RECORD_TOO_SMALL ("record too small") and
SSL_R_GOT_A_FIN_BEFORE_A_CCS ("got a fin before a ccs") errors are now
logged at the "info" level.

No additional client-related errors were observed while testing with
OpenSSL 3.1.0-beta1, OpenSSL 1.1.0l, OpenSSL 1.0.1u, OpenSSL 1.0.0s,
and OpenSSL 0.9.8zh.

3 years agoSSL: switched to detect log level based on the last error.
Maxim Dounin [Wed, 8 Mar 2023 19:21:53 +0000 (22:21 +0300)]
SSL: switched to detect log level based on the last error.

In some cases there might be multiple errors in the OpenSSL error queue,
notably when a libcrypto call fails, and then the SSL layer generates
an error itself.  For example, the following errors were observed
with OpenSSL 3.0.8 with TLSv1.3 enabled:

SSL_do_handshake() failed (SSL: error:02800066:Diffie-Hellman routines::invalid public key error:0A000132:SSL routines::bad ecpoint)
SSL_do_handshake() failed (SSL: error:08000066:elliptic curve routines::invalid encoding error:0A000132:SSL routines::bad ecpoint)
SSL_do_handshake() failed (SSL: error:0800006B:elliptic curve routines::point is not on curve error:0A000132:SSL routines::bad ecpoint)

In such cases it seems to be better to determine logging level based on
the last error in the error queue (the one added by the SSL layer,
SSL_R_BAD_ECPOINT in all of the above example example errors).  To do so,
the ngx_ssl_connection_error() function was changed to use
ERR_peek_last_error().

3 years agoCore: stricter UTF-8 handling in ngx_utf8_decode().
Yugo Horie [Wed, 22 Feb 2023 23:09:50 +0000 (08:09 +0900)]
Core: stricter UTF-8 handling in ngx_utf8_decode().

An UTF-8 octet sequence cannot start with a 11111xxx byte (above 0xf8),
see https://datatracker.ietf.org/doc/html/rfc3629#section-3.  Previously,
such bytes were accepted by ngx_utf8_decode() and misinterpreted as 11110xxx
bytes (as in a 4-byte sequence).  While unlikely, this can potentially cause
issues.

Fix is to explicitly reject such bytes in ngx_utf8_decode().

3 years agoWin32: non-ASCII names in ngx_fs_bsize(), ngx_fs_available().
Maxim Dounin [Thu, 23 Feb 2023 17:50:03 +0000 (20:50 +0300)]
Win32: non-ASCII names in ngx_fs_bsize(), ngx_fs_available().

This fixes potentially incorrect cache size calculations and non-working
"min_free" when using cache in directories with non-ASCII names.

3 years agoWin32: removed attempt to use a drive letter in ngx_fs_bsize().
Maxim Dounin [Thu, 23 Feb 2023 17:50:00 +0000 (20:50 +0300)]
Win32: removed attempt to use a drive letter in ngx_fs_bsize().

Just a drive letter might not correctly represent file system being used,
notably when using symlinks (as created by "mklink /d").  As such, instead
of trying to call GetDiskFreeSpace() with just a drive letter, we now always
use GetDiskFreeSpace() with full path.

Further, it looks like the code to use just a drive letter never worked,
since it tried to test name[2] instead of name[1] to be ':'.

3 years agoWin32: non-ASCII names support in ngx_open_tempfile().
Maxim Dounin [Thu, 23 Feb 2023 17:49:57 +0000 (20:49 +0300)]
Win32: non-ASCII names support in ngx_open_tempfile().

This makes it possible to use temporary directories with non-ASCII characters,
either explicitly or via a prefix with non-ASCII characters in it.

3 years agoWin32: non-ASCII names support in ngx_rename_file().
Maxim Dounin [Thu, 23 Feb 2023 17:49:55 +0000 (20:49 +0300)]
Win32: non-ASCII names support in ngx_rename_file().

This makes it possible to upload files with non-ASCII characters
when using the dav module (ticket #1433).

3 years agoWin32: non-ASCII names support in ngx_delete_file().
Maxim Dounin [Thu, 23 Feb 2023 17:49:54 +0000 (20:49 +0300)]
Win32: non-ASCII names support in ngx_delete_file().

This makes it possible to delete files with non-ASCII characters
when using the dav module (ticket #1433).

3 years agoWin32: reworked ngx_win32_rename_file() to use nginx wrappers.
Maxim Dounin [Thu, 23 Feb 2023 17:49:52 +0000 (20:49 +0300)]
Win32: reworked ngx_win32_rename_file() to use nginx wrappers.

This ensures that ngx_win32_rename_file() will support non-ASCII names
when supported by the wrappers.

Notably, this is used by PUT requests in the dav module when overwriting
existing files with non-ASCII names (ticket #1433).

3 years agoWin32: reworked ngx_win32_rename_file() to check errors.
Maxim Dounin [Thu, 23 Feb 2023 17:49:50 +0000 (20:49 +0300)]
Win32: reworked ngx_win32_rename_file() to check errors.

Previously, ngx_win32_rename_file() retried on all errors returned by
MoveFile() to a temporary name.  It only make sense, however, to retry
when the destination file already exists, similarly to the condition
when ngx_win32_rename_file() is called.  Retrying on other errors is
meaningless and might result in an infinite loop.

3 years agoWin32: non-ASCII directory names support in ngx_delete_dir().
Maxim Dounin [Thu, 23 Feb 2023 17:49:47 +0000 (20:49 +0300)]
Win32: non-ASCII directory names support in ngx_delete_dir().

This makes it possible to delete directories with non-ASCII characters
when using the dav module (ticket #1433).

3 years agoWin32: non-ASCII directory names support in ngx_create_dir().
Maxim Dounin [Thu, 23 Feb 2023 17:49:45 +0000 (20:49 +0300)]
Win32: non-ASCII directory names support in ngx_create_dir().

This makes it possible to create directories under prefix with non-ASCII
characters, as well as makes it possible to create directories with non-ASCII
characters when using the dav module (ticket #1433).

To ensure that the dav module operations are restricted similarly to
other file operations (in particular, short names are not allowed), the
ngx_win32_check_filename() function is used.  It improved to support
checking of just dirname, and now can be used to check paths when creating
files or directories.

3 years agoWin32: non-ASCII directory names support in ngx_getcwd().
Maxim Dounin [Thu, 23 Feb 2023 17:49:44 +0000 (20:49 +0300)]
Win32: non-ASCII directory names support in ngx_getcwd().

This makes it possible to start nginx without a prefix explicitly set
in a directory with non-ASCII characters in it.

3 years agoWin32: non-ASCII names support in "include" with wildcards.
Maxim Dounin [Thu, 23 Feb 2023 17:49:41 +0000 (20:49 +0300)]
Win32: non-ASCII names support in "include" with wildcards.

Notably, ngx_open_glob() now supports opening directories with non-ASCII
characters, and pathnames returned by ngx_read_glob() are converted to UTF-8.

3 years agoWin32: non-ASCII names support in autoindex (ticket #458).
Maxim Dounin [Thu, 23 Feb 2023 17:49:39 +0000 (20:49 +0300)]
Win32: non-ASCII names support in autoindex (ticket #458).

Notably, ngx_open_dir() now supports opening directories with non-ASCII
characters, and directory entries returned by ngx_read_dir() are properly
converted to UTF-8.

3 years agoWin32: OpenSSL compilation for x64 targets with MSVC.
Maxim Dounin [Thu, 23 Feb 2023 15:16:08 +0000 (18:16 +0300)]
Win32: OpenSSL compilation for x64 targets with MSVC.

To ensure proper target selection the NGX_MACHINE variable is now set
based on the MSVC compiler output, and the OpenSSL target is set based
on it.

This is not important as long as "no-asm" is used (as in misc/GNUmakefile
and win32 build instructions), but might be beneficial if someone is trying
to build OpenSSL with assembler code.

3 years agoWin32: i386 now assumed when crossbuilding (ticket #2416).
Maxim Dounin [Thu, 23 Feb 2023 15:15:59 +0000 (18:15 +0300)]
Win32: i386 now assumed when crossbuilding (ticket #2416).

Previously, NGX_MACHINE was not set when crossbuilding, resulting in
NGX_ALIGNMENT=16 being used in 32-bit builds (if not explicitly set to a
correct value).  This in turn might result in memory corruption in
ngx_palloc() (as there are no usable aligned allocator on Windows, and
normal malloc() is used instead, which provides 8 byte alignment on
32-bit platforms).

To fix this, now i386 machine is set when crossbuilding, so nginx won't
assume strict alignment requirements.

3 years agoWin32: handling of localized MSVC cl output.
Maxim Dounin [Thu, 23 Feb 2023 15:15:57 +0000 (18:15 +0300)]
Win32: handling of localized MSVC cl output.

Output examples in English, Russian, and Spanish:

Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 16.00.30319.01 for 80x86
Оптимизирующий 32-разрядный компилятор Microsoft (R) C/C++ версии 16.00.30319.01 для 80x86
Compilador de optimización de C/C++ de Microsoft (R) versión 16.00.30319.01 para x64

Since most of the words are translated, instead of looking for the words
"Compiler Version" we now search for "C/C++" and the version number.

3 years agoWin32: removed unneeded wildcard in NGX_CC_NAME test for msvc.
Maxim Dounin [Thu, 23 Feb 2023 15:15:53 +0000 (18:15 +0300)]
Win32: removed unneeded wildcard in NGX_CC_NAME test for msvc.

Wildcards for msvc in NGX_CC_NAME tests are not needed since 78f8ac479735.

3 years agoLingering close for connections with pipelined requests.
Maxim Dounin [Thu, 2 Feb 2023 20:38:48 +0000 (23:38 +0300)]
Lingering close for connections with pipelined requests.

This is expected to help with clients using pipelining with some constant
depth, such as apt[1][2].

When downloading many resources, apt uses pipelining with some constant
depth, a number of requests in flight.  This essentially means that after
receiving a response it sends an additional request to the server, and
this can result in requests arriving to the server at any time.  Further,
additional requests are sent one-by-one, and can be easily seen as such
(neither as pipelined, nor followed by pipelined requests).

The only safe approach to close such connections (for example, when
keepalive_requests is reached) is with lingering.  To do so, now nginx
monitors if pipelining was used on the connection, and if it was, closes
the connection with lingering.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973861#10
[2] https://mailman.nginx.org/pipermail/nginx-devel/2023-January/ZA2SP5SJU55LHEBCJMFDB2AZVELRLTHI.html

3 years agoFixed "zero size buf" alerts with subrequests.
Maxim Dounin [Sat, 28 Jan 2023 02:23:33 +0000 (05:23 +0300)]
Fixed "zero size buf" alerts with subrequests.

Since 4611:2b6cb7528409 responses from the gzip static, flv, and mp4 modules
can be used with subrequests, though empty files were not properly handled.
Empty gzipped, flv, and mp4 files thus resulted in "zero size buf in output"
alerts.  While valid corresponding files are not expected to be empty, such
files shouldn't result in alerts.

Fix is to set b->sync on such empty subrequest responses, similarly to what
ngx_http_send_special() does.

Additionally, the static module, the ngx_http_send_response() function, and
file cache are modified to do the same instead of not sending the response
body at all in such cases, since not sending the response body at all is
believed to be at least questionable, and might break various filters
which do not expect such behaviour.

3 years agoStyle.
Maxim Dounin [Sat, 28 Jan 2023 02:20:23 +0000 (05:20 +0300)]
Style.

3 years agoAdded warning about redefinition of listen socket protocol options.
Maxim Dounin [Fri, 27 Jan 2023 22:29:45 +0000 (01:29 +0300)]
Added warning about redefinition of listen socket protocol options.

The "listen" directive in the http module can be used multiple times
in different server blocks.  Originally, it was supposed to be specified
once with various socket options, and without any parameters in virtual
server blocks.  For example:

    server { listen 80 backlog=1024; server_name foo; ... }
    server { listen 80; server_name bar; ... }
    server { listen 80; server_name bazz; ... }

The address part of the syntax ("address[:port]" / "port" / "unix:path")
uniquely identifies the listening socket, and therefore is enough for
name-based virtual servers (to let nginx know that the virtual server
accepts requests on the listening socket in question).

To ensure that listening options do not conflict between virtual servers,
they were allowed only once.  For example, the following configuration
will be rejected ("duplicate listen options for 0.0.0.0:80 in ..."):

    server { listen 80 backlog=1024; server_name foo; ... }
    server { listen 80 backlog=512; server_name bar; ... }

At some point it was, however, noticed, that it is sometimes convenient
to repeat some options for clarity.  In nginx 0.8.51 the "ssl" parameter
was allowed to be specified multiple times, e.g.:

    server { listen 443 ssl backlog=1024; server_name foo; ... }
    server { listen 443 ssl; server_name bar; ... }
    server { listen 443 ssl; server_name bazz; ... }

This approach makes configuration more readable, since SSL sockets are
immediately visible in the configuration.  If this is not needed, just the
address can still be used.

Later, additional protocol-specific options similar to "ssl" were
introduced, notably "http2" and "proxy_protocol".  With these options,
one can write:

    server { listen 443 ssl backlog=1024; server_name foo; ... }
    server { listen 443 http2; server_name bar; ... }
    server { listen 443 proxy_protocol; server_name bazz; ... }

The resulting socket will use ssl, http2, and proxy_protocol, but this
is not really obvious from the configuration.

To emphasize such misleading configurations are discouraged, nginx now
warns as long as the "listen" directive is used with options different
from the options previously used if this is potentially confusing.

In particular, the following configurations are allowed:

    server { listen 8401 ssl backlog=1024; server_name foo; }
    server { listen 8401 ssl; server_name bar; }
    server { listen 8401 ssl; server_name bazz; }

    server { listen 8402 ssl http2 backlog=1024; server_name foo; }
    server { listen 8402 ssl; server_name bar; }
    server { listen 8402 ssl; server_name bazz; }

    server { listen 8403 ssl; server_name bar; }
    server { listen 8403 ssl; server_name bazz; }
    server { listen 8403 ssl http2; server_name foo; }

    server { listen 8404 ssl http2 backlog=1024; server_name foo; }
    server { listen 8404 http2; server_name bar; }
    server { listen 8404 http2; server_name bazz; }

    server { listen 8405 ssl http2 backlog=1024; server_name foo; }
    server { listen 8405 ssl http2; server_name bar; }
    server { listen 8405 ssl http2; server_name bazz; }

    server { listen 8406 ssl; server_name foo; }
    server { listen 8406; server_name bar; }
    server { listen 8406; server_name bazz; }

And the following configurations will generate warnings:

    server { listen 8501 ssl http2 backlog=1024; server_name foo; }
    server { listen 8501 http2; server_name bar; }
    server { listen 8501 ssl; server_name bazz; }

    server { listen 8502 backlog=1024; server_name foo; }
    server { listen 8502 ssl; server_name bar; }

    server { listen 8503 ssl; server_name foo; }
    server { listen 8503 http2; server_name bar; }

    server { listen 8504 ssl; server_name foo; }
    server { listen 8504 http2; server_name bar; }
    server { listen 8504 proxy_protocol; server_name bazz; }

    server { listen 8505 ssl http2 proxy_protocol; server_name foo; }
    server { listen 8505 ssl http2; server_name bar; }
    server { listen 8505 ssl; server_name bazz; }

    server { listen 8506 ssl http2; server_name foo; }
    server { listen 8506 ssl; server_name bar; }
    server { listen 8506; server_name bazz; }

    server { listen 8507 ssl; server_name bar; }
    server { listen 8507; server_name bazz; }
    server { listen 8507 ssl http2; server_name foo; }

    server { listen 8508 ssl; server_name bar; }
    server { listen 8508; server_name bazz; }
    server { listen 8508 ssl backlog=1024; server_name foo; }

    server { listen 8509; server_name bazz; }
    server { listen 8509 ssl; server_name bar; }
    server { listen 8509 ssl backlog=1024; server_name foo; }

The basic idea is that at most two sets of protocol options are allowed:
the main one (with socket options, if any), and a shorter one, with options
being a subset of the main options, repeated for clarity.  As long as the
shorter set of protocol options is used, all listen directives except the
main one should use it.

3 years agoHTTP/3: trigger more compatibility errors for "listen quic".
Roman Arutyunyan [Thu, 26 Jan 2023 11:25:33 +0000 (15:25 +0400)]
HTTP/3: trigger more compatibility errors for "listen quic".

Now "ssl", "proxy_protocol" and "http2" are not allowed with "quic" in "listen"
directive.  Previously, only "ssl" was not allowed.

3 years agoHTTP/3: "quic" parameter of "listen" directive.
Roman Arutyunyan [Mon, 27 Feb 2023 10:00:56 +0000 (14:00 +0400)]
HTTP/3: "quic" parameter of "listen" directive.

Now "listen" directve has a new "quic" parameter which enables QUIC protocol
for the address.  Further, to enable HTTP/3, a new directive "http3" is
introduced.  The hq-interop protocol is enabled by "http3_hq" as before.
Now application protocol is chosen by ALPN.

Previously used "http3" parameter of "listen" is deprecated.

3 years agoQUIC: OpenSSL compatibility layer.
Roman Arutyunyan [Wed, 22 Feb 2023 15:16:53 +0000 (19:16 +0400)]
QUIC: OpenSSL compatibility layer.

The change allows to compile QUIC with OpenSSL which lacks BoringSSL QUIC API.

This implementation does not support 0-RTT.

3 years agoQUIC: improved ssl_reject_handshake error logging.
Sergey Kandaurov [Thu, 23 Feb 2023 12:26:38 +0000 (16:26 +0400)]
QUIC: improved ssl_reject_handshake error logging.

The check follows the ngx_ssl_handshake() change in 59e1c73fe02b.

3 years agoQUIC: using ngx_ssl_handshake_log().
Sergey Kandaurov [Thu, 23 Feb 2023 12:17:29 +0000 (16:17 +0400)]
QUIC: using ngx_ssl_handshake_log().

3 years agoQUIC: moved "handshake failed" reason to send_alert.
Sergey Kandaurov [Thu, 23 Feb 2023 12:16:56 +0000 (16:16 +0400)]
QUIC: moved "handshake failed" reason to send_alert.

A QUIC handshake failure breaks down into several cases:
- a handshake error which leads to a send_alert call
- an error triggered by the add_handshake_data callback
- internal errors (allocation etc)

Previously, in the first case, only error code was set in the send_alert
callback.  Now the "handshake failed" reason phrase is set there as well.
In the second case, both code and reason are set by add_handshake_data.
In the last case, setting reason phrase is removed: returning NGX_ERROR
now leads to closing the connection with just INTERNAL_ERROR.

Reported by Jiuzhou Cui.

3 years agoQUIC: using NGX_QUIC_ERR_CRYPTO macro in ALPN checks.
Sergey Kandaurov [Thu, 23 Feb 2023 11:49:59 +0000 (15:49 +0400)]
QUIC: using NGX_QUIC_ERR_CRYPTO macro in ALPN checks.

Patch by Jiuzhou Cui.

3 years agoQUIC: fixed indentation.
Sergey Kandaurov [Mon, 13 Feb 2023 10:01:50 +0000 (14:01 +0400)]
QUIC: fixed indentation.

3 years agoREADME: fixed toc.
Sergey Kandaurov [Mon, 13 Feb 2023 09:41:35 +0000 (13:41 +0400)]
README: fixed toc.

While here, updated link to mailman.

3 years agoREADME: updated building from sources, added directives reference.
Sergey Kandaurov [Wed, 8 Feb 2023 08:47:35 +0000 (12:47 +0400)]
README: updated building from sources, added directives reference.

3 years agoQUIC: fixed broken token in NEW_TOKEN (ticket #2446).
Roman Arutyunyan [Tue, 31 Jan 2023 11:26:33 +0000 (15:26 +0400)]
QUIC: fixed broken token in NEW_TOKEN (ticket #2446).

Previously, since 3550b00d9dc8, the token was allocated on stack, to get
rid of pool usage.  Now the token is allocated by ngx_quic_copy_buffer()
in QUIC buffers, also used for STREAM, CRYPTO and ACK frames.

3 years agoQUIC: ngx_quic_copy_buffer() function.
Roman Arutyunyan [Tue, 31 Jan 2023 10:12:18 +0000 (14:12 +0400)]
QUIC: ngx_quic_copy_buffer() function.

The function copies passed data to QUIC buffer chain and returns it.
The chain can be used in ngx_quic_frame_t data field.

3 years agoFixed handling of very long locations (ticket #2435).
Maxim Dounin [Thu, 26 Jan 2023 00:34:44 +0000 (03:34 +0300)]
Fixed handling of very long locations (ticket #2435).

Previously, location prefix length in ngx_http_location_tree_node_t was
stored as "u_char", and therefore location prefixes longer than 255 bytes
were handled incorrectly.

Fix is to use "u_short" instead.  With "u_short", prefixes up to 65535 bytes
can be safely used, and this isn't reachable due to NGX_CONF_BUFFER, which
is 4096 bytes.

3 years agoGzip static: ranges support (ticket #2349).
Maxim Dounin [Tue, 24 Jan 2023 00:01:51 +0000 (03:01 +0300)]
Gzip static: ranges support (ticket #2349).

In contrast to on-the-fly gzipping with gzip filter, static gzipped
representation as returned by gzip_static is persistent, and therefore
the same binary representation is available for future requests, making
it possible to use range requests.

Further, if a gzipped representation is re-generated with different
compression settings, it is expected to result in different ETag and
different size reported in the Content-Range header, making it possible
to safely use range requests anyway.

As such, ranges are now allowed for files returned by gzip_static.

3 years agoQUIC: improved SO_COOKIE configure test.
Maxim Dounin [Mon, 23 Jan 2023 23:57:42 +0000 (02:57 +0300)]
QUIC: improved SO_COOKIE configure test.

In nginx source code the inttypes.h include, if available, is used to define
standard integer types.  Changed the SO_COOKIE configure test to follow this.

3 years agoConfigure: removed unneeded header from UDP_SEGMENT test.
Maxim Dounin [Mon, 23 Jan 2023 02:01:01 +0000 (05:01 +0300)]
Configure: removed unneeded header from UDP_SEGMENT test.

3 years agoQUIC: defer setting the active flag for client stream events.
Sergey Kandaurov [Wed, 18 Jan 2023 15:20:18 +0000 (19:20 +0400)]
QUIC: defer setting the active flag for client stream events.

Specifically, now it is kept unset until streams are initialized.
Notably, this unbreaks OCSP with client certificates after 35e27117b593.
Previously, the read event could be posted prematurely via ngx_quic_set_event()
e.g., as part of handling a STREAM frame.

3 years agoQUIC: relocated ngx_quic_init_streams() for 0-RTT.
Roman Arutyunyan [Tue, 10 Jan 2023 13:24:10 +0000 (17:24 +0400)]
QUIC: relocated ngx_quic_init_streams() for 0-RTT.

Previously, streams were initialized in early keys handler.  However, client
transport parameters may not be available by then.  This happens, for example,
when using QuicTLS.  Now streams are initialized in ngx_quic_crypto_input()
after calling SSL_do_handshake() for both 0-RTT and 1-RTT.

3 years agoHTTP/3: insert count block timeout.
Roman Arutyunyan [Thu, 5 Jan 2023 15:03:22 +0000 (19:03 +0400)]
HTTP/3: insert count block timeout.

Previously, there was no timeout for a request stream blocked on insert count,
which could result in infinite wait.  Now client_header_timeout is set when
stream is first blocked.

3 years agoHTTP/3: trigger 400 (Bad Request) on stream error while blocked.
Roman Arutyunyan [Thu, 5 Jan 2023 14:15:46 +0000 (18:15 +0400)]
HTTP/3: trigger 400 (Bad Request) on stream error while blocked.

Previously, stream was closed with NGX_HTTP_CLOSE.  However, in a similar case
when recv() returns eof or error, status 400 is triggered.

3 years agoQUIC: set stream error flag on reset.
Roman Arutyunyan [Tue, 10 Jan 2023 13:42:40 +0000 (17:42 +0400)]
QUIC: set stream error flag on reset.

Now, when RESET_STREAM is sent or received, or when streams are closed,
stream connection error flag is set.  Previously, only stream state was
changed, which resulted in setting the error flag only after calling
recv()/send()/send_chain().  However, there are cases when none of these
functions is called, but it's still important to know if the stream is being
closed.  For example, when an HTTP/3 request stream is blocked on insert count,
receiving RESET_STREAM should trigger stream closure, which was not the case.

The change also fixes ngx_http_upstream_check_broken_connection() and
ngx_http_test_reading() with QUIC streams.

3 years agoQUIC: automatically add and never delete stream events.
Roman Arutyunyan [Tue, 10 Jan 2023 10:05:18 +0000 (14:05 +0400)]
QUIC: automatically add and never delete stream events.

Previously, stream events were added and deleted by ngx_handle_read_event() and
ngx_handle_write_event() in a way similar to level-triggered events.  However,
QUIC stream events are effectively edge-triggered and can stay active all time.
Moreover, the events are now active since the moment a stream is created.

3 years agoHTTP/3: fixed $connection_time.
Sergey Kandaurov [Tue, 10 Jan 2023 13:59:16 +0000 (17:59 +0400)]
HTTP/3: fixed $connection_time.

Previously, start_time wasn't set for a new stream.
The fix is to derive it from the parent connection.
Also it's used to simplify tracking keepalive_time.

3 years agoHTTP/3: handled insertion reference to a going to be evicted entry.
Roman Arutyunyan [Tue, 3 Jan 2023 12:24:45 +0000 (16:24 +0400)]
HTTP/3: handled insertion reference to a going to be evicted entry.

As per RFC 9204, section 3.2.2, a new entry can reference an entry in the
dynamic table that will be evicted when adding this new entry into the dynamic
table.

Previously, such inserts resulted in use-after-free since the old entry was
evicted before the insertion (ticket #2431).  Now it's evicted after the
insertion.

This change fixes Insert with Name Reference and Duplicate encoder instructions.

3 years agoMerged with the default branch.
Sergey Kandaurov [Mon, 2 Jan 2023 13:10:22 +0000 (17:10 +0400)]
Merged with the default branch.

3 years agoUpdated link to OpenVZ suspend/resume bug.
Maxim Dounin [Wed, 21 Dec 2022 11:53:27 +0000 (14:53 +0300)]
Updated link to OpenVZ suspend/resume bug.

3 years agoFixed port ranges support in the listen directive.
Valentin Bartenev [Sun, 18 Dec 2022 18:29:02 +0000 (21:29 +0300)]
Fixed port ranges support in the listen directive.

Ports difference must be respected when checking addresses for duplicates,
otherwise configurations like this are broken:

  listen 127.0.0.1:6000-6005

It was broken by 4cc2bfeff46c (nginx 1.23.3).

3 years agoStyle.
BullerDu [Thu, 15 Dec 2022 21:15:15 +0000 (01:15 +0400)]
Style.

3 years agoVersion bump.
Sergey Kandaurov [Thu, 15 Dec 2022 21:15:13 +0000 (01:15 +0400)]
Version bump.

3 years agoMerged with the default branch.
Sergey Kandaurov [Thu, 15 Dec 2022 15:40:44 +0000 (19:40 +0400)]
Merged with the default branch.

3 years agorelease-1.23.3 tag
Maxim Dounin [Tue, 13 Dec 2022 15:53:53 +0000 (18:53 +0300)]
release-1.23.3 tag

3 years agonginx-1.23.3-RELEASE release-1.23.3
Maxim Dounin [Tue, 13 Dec 2022 15:53:53 +0000 (18:53 +0300)]
nginx-1.23.3-RELEASE

3 years agoUpdated OpenSSL and zlib used for win32 builds.
Maxim Dounin [Tue, 13 Dec 2022 00:32:57 +0000 (03:32 +0300)]
Updated OpenSSL and zlib used for win32 builds.

3 years agoWin32: event flags handling edge cases in ngx_wsarecv().
Maxim Dounin [Thu, 1 Dec 2022 01:22:36 +0000 (04:22 +0300)]
Win32: event flags handling edge cases in ngx_wsarecv().

Fixed event flags handling edge cases in ngx_wsarecv() and ngx_wsarecv_chain(),
notably to always reset rev->ready in case of errors (which wasn't the case
after ngx_socket_nread() errors), and after EOF (rev->ready was not cleared
if due to a misconfiguration a zero-sized buffer was used for reading).

3 years agoSSL: fixed ngx_ssl_recv() to reset c->read->ready after errors.
Maxim Dounin [Thu, 1 Dec 2022 01:22:31 +0000 (04:22 +0300)]
SSL: fixed ngx_ssl_recv() to reset c->read->ready after errors.

With this change, behaviour of ngx_ssl_recv() now matches ngx_unix_recv(),
which used to always reset c->read->ready to 0 when returning errors.

This fixes an infinite loop in unbuffered SSL proxying if writing to the
client is blocked and an SSL error happens (ticket #2418).

With this change, the fix for a similar issue in the stream module
(6868:ee3645078759), which used a different approach of explicitly
testing c->read->error instead, is no longer needed and was reverted.

3 years agoRemoved casts from ngx_memcmp() macro.
Maxim Dounin [Wed, 30 Nov 2022 15:01:53 +0000 (18:01 +0300)]
Removed casts from ngx_memcmp() macro.

Casts are believed to be not needed, since memcmp() has "const void *"
arguments since introduction of the "void" type in C89.  And on pre-C89
platforms nginx is unlikely to compile without warnings anyway, as there
are no casts in memcpy() and memmove() calls.

These casts were added in 1648:89a47f19b9ec without any details on why they
were added, and Igor does not remember details either.  The most plausible
explanation is that they were copied from ngx_strcmp() and were not really
needed even at that time.

Prodded by Alejandro Colomar.

3 years agoFixed alignment of ngx_memmove()/ngx_movemem() macro definitions.
Maxim Dounin [Wed, 30 Nov 2022 15:01:43 +0000 (18:01 +0300)]
Fixed alignment of ngx_memmove()/ngx_movemem() macro definitions.

3 years agoSSL: fixed debug logging of SSL_sendfile() return value.
Sergey Kandaurov [Thu, 24 Nov 2022 19:08:30 +0000 (23:08 +0400)]
SSL: fixed debug logging of SSL_sendfile() return value.