From: Zurab Kvachadze <zurabid2016@gmail.com>
Date: Mon, 26 Jan 2026 14:54:51 +0000 (+0100)
Subject: auto/cc: Use portable/POSIX 'command -v' instead of 'which'
X-Git-Tag: 0.9.6~29
X-Git-Url: http://www.kaiwu.me/postgresql/commit/static/gitweb.js?a=commitdiff_plain;h=d0460580f383cff55e246dc6dc90791d4be1f024;p=njs.git

auto/cc: Use portable/POSIX 'command -v' instead of 'which'

'which' is not a portable utility as it is not specified by POSIX. Since
auto/cc is already a shell script, use the more direct and portable
'command' builtin to detect $CC.

There are two bugs linked here. The first one is a downstream report of
this issue. The second one is more general information on why 'which'
usage is an issue and should be avoided.

Bug: https://bugs.gentoo.org/969288
Bug: https://bugs.gentoo.org/646588
Signed-off-by: Zurab Kvachadze <zurabid2016@gmail.com>
---

diff --git a/auto/cc b/auto/cc
index 8a615ec4..5b21e17e 100644
--- a/auto/cc
+++ b/auto/cc
@@ -13,7 +13,7 @@ END
 # Allow error exit status.
 set +e
 
-if [ -z "$(which $CC)" ]; then
+if ! command -v "${CC}" >/dev/null; then
     echo
     echo $0: error: $CC not found.
     echo