From: Ruslan Ermilov Date: Tue, 30 Jan 2018 11:44:31 +0000 (+0300) Subject: HTTP/2: finalize request as bad if parsing of pseudo-headers fails. X-Git-Tag: release-1.13.9~18 X-Git-Url: http://www.kaiwu.me/postgresql/commit/static/gitweb.js?a=commitdiff_plain;h=22136953689e4f48c2bc90a01f39e23a4b6428af;p=nginx.git HTTP/2: finalize request as bad if parsing of pseudo-headers fails. This is in line when the required pseudo-headers are missing, and avoids spurious zero statuses in access.log. --- diff --git a/src/http/v2/ngx_http_v2.c b/src/http/v2/ngx_http_v2.c index 8507eac26..8c752db65 100644 --- a/src/http/v2/ngx_http_v2.c +++ b/src/http/v2/ngx_http_v2.c @@ -1583,14 +1583,7 @@ ngx_http_v2_state_process_header(ngx_http_v2_connection_t *h2c, u_char *pos, } if (rc == NGX_DECLINED) { - if (ngx_http_v2_terminate_stream(h2c, h2c->state.stream, - NGX_HTTP_V2_PROTOCOL_ERROR) - == NGX_ERROR) - { - return ngx_http_v2_connection_error(h2c, - NGX_HTTP_V2_INTERNAL_ERROR); - } - + ngx_http_finalize_request(r, NGX_HTTP_BAD_REQUEST); goto error; }