]> git.kaiwu.me - nginx.git/commitdiff
Revert "Rejecting new connections with non-zero Initial packet."
authorSergey Kandaurov <pluknet@nginx.com>
Fri, 17 Apr 2020 09:01:45 +0000 (12:01 +0300)
committerSergey Kandaurov <pluknet@nginx.com>
Fri, 17 Apr 2020 09:01:45 +0000 (12:01 +0300)
chrome-unstable 83.0.4103.7 starts with Initial packet number 1.

I couldn't find a proper explanation besides this text in quic-transport:
    An endpoint MAY skip packet numbers when sending
    packets to detect this (Optimistic ACK Attack) behavior.

src/event/ngx_event_quic.c

index 34a51f71f08c147eca715a3ee27b5d018663c072..4c9a658a95c3a254d5648549adeb754f4447a91b 100644 (file)
@@ -583,12 +583,6 @@ ngx_quic_new_connection(ngx_connection_t *c, ngx_ssl_t *ssl, ngx_quic_tp_t *tp,
         return NGX_ERROR;
     }
 
-    if (pkt->pn != 0) {
-        ngx_log_error(NGX_LOG_INFO, c->log, 0,
-                      "invalid initial packet number %L", pkt->pn);
-        return NGX_ERROR;
-    }
-
     if (ngx_quic_init_connection(c) != NGX_OK) {
         return NGX_ERROR;
     }