]> git.kaiwu.me - nginx.git/commitdiff
Switched to using posted next events after sendfile_max_chunk.
authorMaxim Dounin <mdounin@mdounin.ru>
Fri, 29 Oct 2021 17:21:43 +0000 (20:21 +0300)
committerMaxim Dounin <mdounin@mdounin.ru>
Fri, 29 Oct 2021 17:21:43 +0000 (20:21 +0300)
Previously, 1 millisecond delay was used instead.  In certain edge cases
this might result in noticeable performance degradation though, notably on
Linux with typical CONFIG_HZ=250 (so 1ms delay becomes 4ms),
sendfile_max_chunk 2m, and link speed above 2.5 Gbps.

Using posted next events removes the artificial delay and makes processing
fast in all cases.

src/http/ngx_http_write_filter_module.c

index 6a5d957b169f98d4dd7f06b53798c7305ea57652..bd37704578119789052e57f713c9c909d17a9888 100644 (file)
@@ -331,8 +331,7 @@ ngx_http_write_filter(ngx_http_request_t *r, ngx_chain_t *in)
         && c->write->ready
         && c->sent - sent >= limit - (off_t) (2 * ngx_pagesize))
     {
-        c->write->delayed = 1;
-        ngx_add_timer(c->write, 1);
+        ngx_post_event(c->write, &ngx_posted_next_events);
     }
 
     for (cl = r->out; cl && cl != chain; /* void */) {