]> git.kaiwu.me - nginx.git/commitdiff
Mail: fixed segfault with ssl/starttls at mail{} level and no cert.
authorMaxim Dounin <mdounin@mdounin.ru>
Mon, 30 Sep 2013 18:10:13 +0000 (22:10 +0400)
committerMaxim Dounin <mdounin@mdounin.ru>
Mon, 30 Sep 2013 18:10:13 +0000 (22:10 +0400)
A configuration like "mail { starttls on; server {}}" triggered NULL
pointer dereference in ngx_mail_ssl_merge_conf() as conf->file was not set.

src/mail/ngx_mail_ssl_module.c

index 66aa18c3bbd0e9bce5a64501d93b158cc193d103..18fd66aed3a35b406d8eb151d662f17ad14e729a 100644 (file)
@@ -235,6 +235,11 @@ ngx_mail_ssl_merge_conf(ngx_conf_t *cf, void *parent, void *child)
        mode = "";
     }
 
+    if (conf->file == NULL) {
+        conf->file = prev->file;
+        conf->line = prev->line;
+    }
+
     if (*mode) {
 
         if (conf->certificate.len == 0) {