]> git.kaiwu.me - nginx.git/commitdiff
Resolver: fixed a race between parallel name and addr resolves.
authorDmitry Volyntsev <xeioex@nginx.com>
Fri, 16 Dec 2016 15:21:55 +0000 (18:21 +0300)
committerDmitry Volyntsev <xeioex@nginx.com>
Fri, 16 Dec 2016 15:21:55 +0000 (18:21 +0300)
Previously, ngx_resolve_name() and ngx_resolve_addr() may have
rescheduled the resend timer while it was already in progress.

src/core/ngx_resolver.c

index d5f06eb1d15b71d2c5cbf4f73697df5e8c11f865..54e037de0044ffe8a444b0417ae3fc2858b7002a 100644 (file)
@@ -875,7 +875,7 @@ ngx_resolve_name_locked(ngx_resolver_t *r, ngx_resolver_ctx_t *ctx,
         ngx_add_timer(ctx->event, ctx->timeout);
     }
 
-    if (ngx_queue_empty(resend_queue)) {
+    if (ngx_resolver_resend_empty(r)) {
         ngx_add_timer(r->event, (ngx_msec_t) (r->resend_timeout * 1000));
     }
 
@@ -1098,7 +1098,7 @@ ngx_resolve_addr(ngx_resolver_ctx_t *ctx)
         ngx_add_timer(ctx->event, ctx->timeout);
     }
 
-    if (ngx_queue_empty(resend_queue)) {
+    if (ngx_resolver_resend_empty(r)) {
         ngx_add_timer(r->event, (ngx_msec_t) (r->resend_timeout * 1000));
     }